https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/GENIUS-237 genius <p>I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, and see extensive "TLAB Allocations" due to what appears to be a clear mistake causing excessive toString() usage in EntityOwnershipUtils.runOnlyInOwnerNode():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-object">char</span>[] java.util.Arrays.copyOf(<span class="code-object">char</span>[], <span class="code-object">int</span>) 939 void java.lang.AbstractStringBuilder.ensureCapacityInternal(<span class="code-object">int</span>) 939 AbstractStringBuilder java.lang.AbstractStringBuilder.append(<span class="code-object">String</span>) 880 StringBuilder java.lang.StringBuilder.append(<span class="code-object">String</span>) 880 <span class="code-object">String</span> org.opendaylight.mdsal.eos.common.api.GenericEntity.toString() 340 void org.opendaylight.genius.utils.clustering.EntityOwnershipUtils.runOnlyInOwnerNode(<span class="code-object">String</span>, <span class="code-object">String</span>, JobCoordinator, <span class="code-object">String</span>, <span class="code-object">Runnable</span>) 340 void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.runOnlyInOwnerNode(<span class="code-object">String</span>, <span class="code-object">Runnable</span>) 340 void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.update(InstanceIdentifier, OvsdbBridgeAugmentation, OvsdbBridgeAugmentation) 340 void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.update(InstanceIdentifier, DataObject, DataObject) 340 void org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase$DataTreeChangeHandler.run() 340 void java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker) 340 void java.util.concurrent.ThreadPoolExecutor$Worker.run() 340 void java.lang.<span class="code-object">Thread</span>.run() 340</pre> </div></div> GENIUS-237

Excessive toString() in EntityOwnershipUtils

Bug Medium Resolved Done Michael Vorburger Michael Vorburger Mon, 12 Nov 2018 17:41:56 +0000 Thu, 22 Nov 2018 11:15:34 +0000 Thu, 22 Nov 2018 11:15:34 +0000 Oxygen-SR3 Oxygen-SR4 Fluorine-SR2 Neon 0 2 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=vorburger" class="user-hover" rel="vorburger">vorburger</a> : Do you want me to assign an owner to this bug, or you are going to fix by yourself? <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Looking more closely at this, we find that EntityOwnershipUtils (by <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=tpantelis" class="user-hover" rel="tpantelis">tpantelis</a>) does, has to do:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">Entity entity = <span class="code-keyword">new</span> Entity(entityType, entityName); coordinator.enqueueJob(entity.toString(), () -&gt; { ...</pre> </div></div> <p>We could improve this if we did <a href="https://jira.opendaylight.org/browse/INFRAUTILS-60" title="JobCoordinator key Object instead String" class="issue-link" data-issue-key="INFRAUTILS-60"><del>INFRAUTILS-60</del></a> ...</p> <p><a href="https://jira.opendaylight.org/browse/INFRAUTILS-60" title="JobCoordinator key Object instead String" class="issue-link" data-issue-key="INFRAUTILS-60"><del>INFRAUTILS-60</del></a> has degenerated into (another) infrautils bashing exercice, and resolving that does not align with the sort of timeframe I would like to wrap up this issue in (ASAP). I've therefore proposed a simple local fix for this in <a href="https://git.opendaylight.org/gerrit/#/c/77901" class="external-link" target="_blank" rel="nofollow noopener">c/77901</a> instead.</p> Blocks INFRAUTILS-60 Development Rank 0|i03kcf: