[GENIUS-260] LockManager should be able to run within an open managed transaction, e.g. when used by IdManager

Wed, 19 Dec 2018 14:53:33 +0000

Discussions in the review of my https://git.opendaylight.org/gerrit/#/c/78055 by skitt have identified that LockManager really should be able to run within an existing transaction instead of creating its own.

For example, when LockManager is used by IdManager's CleanUpJob, the LM should use the open managed TX created in IM. This is not possible today because LM is a YANG RPC, not a "local" (OSGi BP) service. My suggestion is to remove the YANG RPC, as this is only an "internal" technical service, I doubt there is a real world use case where one would want to use this remotely e.g. via RESTCONF. It then becomes trivial to pass a Transaction as an additional argument.

I have a feeling that are many more RPCs which don't actually have to be that, but let's start with LM as a specific example, which perhaps in the future can be applied more generally.

k.faseela you seemed to have some interest in picking this up? Your https://git.opendaylight.org/gerrit/#/c/78869 and https://git.opendaylight.org/gerrit/#/c/78870 from today aren't exactly what this is about, but in the same space. (Readers of this issue should look at the code review feedback on those 2 changes as well.)

tpantelis FYI.

OpenDaylight JIRA

[GENIUS-260] LockManager should be able to run within an open managed transaction, e.g. when used by IdManager