https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/GENIUS-280 genius <p>There are currently 14 places which are splitting a String on ':' and do something with it – usually extracting DPN/DPID. All of this is done though String.split(), which is massively inefficient:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>./itm/itm-impl/src/main/java/org/opendaylight/genius/itm/rpc/ItmManagerRpcService.java: String[] nodeId = node.getId().getValue().split(":"); ./itm/itm-impl/src/main/java/org/opendaylight/genius/itm/recovery/impl/ItmTepInstanceRecoveryHandler.java: String[] params = entityId.split(":"); ./interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/servicebindings/flowbased/listeners/FlowBasedServicesNodeStateListener.java: final String[] node = id.getId().getValue().split(":"); ./interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/pmcounters/NodeConnectorStatsImpl.java: String dpId = nodeId.getValue().split(":")[1]; ./interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/pmcounters/NodeConnectorStatsImpl.java: String dpId = nodeId.getValue().split(":")[1]; ./fcapsapplication/fcapsapplication-impl/src/main/java/org/opendaylight/genius/fcapsapp/performancecounter/PacketInCounterHandler.java: String[] nodeNo = id.split(":"); ./fcapsapplication/fcapsapplication-impl/src/main/java/org/opendaylight/genius/fcapsapp/performancecounter/PacketInCounterHandler.java: dpnId = dpnId.split(":")[1]; ./fcapsapplication/fcapsapplication-impl/src/main/java/org/opendaylight/genius/fcapsapp/performancecounter/FlowNodeConnectorInventoryTranslatorImpl.java: String[] switchId = node.split(":"); ./networkutils/networkutils/src/main/java/org/opendaylight/genius/networkutils/impl/VniUtilsImpl.java: String[] configureVniRangeSplit = configureVniRange.split(":"); ./networkutils/networkutils/src/main/java/org/opendaylight/genius/networkutils/impl/RDUtilsImpl.java: String[] configureRDSplit = NwConstants.RD_DEFAULT_LOW_VALUE.split(":"); ./networkutils/networkutils/src/main/java/org/opendaylight/genius/networkutils/impl/RDUtilsImpl.java: configureRDSplit = configuredRDStartValue.split(":"); ./alivenessmonitor/alivenessmonitor-impl-protocols/src/main/java/org/opendaylight/genius/alivenessmonitor/protocols/internal/AbstractAlivenessProtocolHandler.java: String[] addressPart = macAddress.split(":"); ./ipv6util/api/src/main/java/org/opendaylight/genius/ipv6util/api/Ipv6Util.java: String[] octets = target.split(":"); ./mdsalutil/mdsalutil-impl/src/main/java/org/opendaylight/genius/mdsalutil/internal/MDSALManager.java: String[] split = dpnString.split(":"); </pre> </div></div> <p>Provide an explicitly-documented utility which will perform a split-and-parse operation, in the most efficient manner possible and migrate all appropriate callsites to use it.</p> GENIUS-280

Centralize node identifier parsing

Improvement Medium In Review Unresolved Apurba Mukherjee Robert Varga Fri, 11 Oct 2019 16:56:57 +0000 Tue, 22 Sep 2020 05:17:35 +0000 mdsalutils 0 2 <p>The splitter implementations should work on String.indexOf(':')  – note char! – and then issuing a String.subString(offset + 1), so that we do not instantiate unnecesary objects.</p> <p>Pushed a patch for this. I have done a basic comparison testing. For a dummy string (<font color="#6a8759">openflow:12345678:37:compute:9876540:78:node:564789:21) String.split(":") takes 12 to 17 ms while the new API takes max 1 ms.</font></p> <p><a href="https://git.opendaylight.org/gerrit/c/genius/+/92429" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/genius/+/92429</a> </p> Relates MDSAL-486 Development Rank 0|i03pcv: