https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INFRAUTILS-28 infrautils <p>As per</p> <p><a href="https://lists.opendaylight.org/pipermail/release/2018-January/013604.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/release/2018-January/013604.html</a></p> <p><a href="https://lists.opendaylight.org/pipermail/release/2017-September/012356.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/release/2017-September/012356.html</a></p> <p>infrautils  inter-project dependencies are not expressed correctly in feature definitions, as downstream projects are packaging their ODL upstream's bundles directly in their features, rather than properly depending on upstream's features.</p> <p><em>infrautils/odl-infrautils-ready/1.3.0-SNAPSHOT/odl-infrautils-ready-1.3.0-SNAPSHOT-features.xml: &lt;bundle&gt;wrap:mvn:org.opendaylight.odlparent/bundles-test-lib/3.0.2&lt;/bundle&gt;</em></p> <p><em>Please read the above mails to get full understanding of the issue, and please fix the same in your project</em></p> INFRAUTILS-28

inter-project dependencies are not expressed correctly in feature definitions

Bug Medium Resolved Done Faseela K Faseela K Tue, 13 Feb 2018 14:19:55 +0000 Mon, 19 Feb 2018 10:30:09 +0000 Mon, 19 Feb 2018 10:30:09 +0000 0 2 <p>re-assigning from default assignee to <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a> who already started looking into this... copy/paste of private email exchange:</p> <blockquote><p>On Thu, Feb 15, 2018 at 12:07 PM, Faseela K &lt;faseela.k@ericsson.com&gt; wrote:<br/> Hi,</p> <p> I was trying to correct infrautils ready’s feature pom, based on Robert’s mail.</p> <p> The generated feature.xml shows : &lt;bundle&gt;wrap:mvn:org.opendaylight.odlparent/bundles-test-lib/3.0.2&lt;/bundle&gt;<br/> However I do not see any bundle dependency in the respective pom, only odlparent feature is there.</p> <p> How will that happen?</p></blockquote> <p>With reply:<blockquote> <p>ready/impl/pom.xml has the dependency to bundles-test-lib you are looking for.</p> <p>but that POM has the maven-bundle-plugin configuration instructions for BND to &lt;Embed-Dependency&gt; bundles-test-lib (and awaitility &amp; hamcrest-core...), so I'm surprised that the generated feature.xml shows &lt;bundle&gt;wrap:mvn:bundles-test-lib ... it should not, we do not need that - because bundles-test-lib is embedded in ready-impl-1.3.0-SNAPSHOT.jar (it is; I just double checked, just to be sure).</p> <p>It's funny BTW that in common/features/odl-infrautils-ready/target/feature/feature.xml this problem only affects bundles-test-lib, but not awaitility &amp; hamcrest-core... but that's just a lucky coincence (I suspect because the latter 2 are &lt;scope&gt;test in odlparent, overridden to be scope compile in ready/impl, but that does not affect odl-infrautils-ready).</p> <p>So the real problem here, and possibly elsewhere as well <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/help_16.png" height="16" width="16" align="absmiddle" alt="" border="0"/>, is that the automatic feature generation apparently adds bundle wrap to features for dependencies which are embedded. And I kind of see why... it cannot really know (at the time it generates the feature) that some of dependencies were embedded (in another POM). Some proposed ideas to address this, in the order I would try them:</p> <p>1. Perhaps playing with the &lt;scope&gt; of such dependencies, say provided instead of runtime for bundles-test-lib in ready/impl/pom.xml, can convince the feature generation to ignore them? Just make sure that the embedding then actually still works with that... <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/> Worth a try... do you want to try that, first?</p> <p>2. Otherwise, try adding an &lt;exclusions&gt; to the ready-impl &lt;dependency&gt; of common/features/odl-infrautils-ready/pom.xml for bundles-test-lib. This is more likely to work I expect - but it's a bit uglier than 1. because we would duplicate this in two POM.</p> <p>I expect this problem may affect other features in ODL which depend on bundles which use embedding; I know e.g. in AAA there are some - and think it would be worthwhile to share this more widely - perhaps best after the solution? <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p></blockquote></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/68376/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68376/</a></p> <p>merged - thanks <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a>!</p> Development Rank 0|i03a6v: