https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INFRAUTILS-31 infrautils <p>from <a href="https://lists.opendaylight.org/pipermail/infrautils-dev/2018-March/000635.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/infrautils-dev/2018-March/000635.html</a> and related to <a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-988" title="Openflow Service ERROR state in Fluorine" class="issue-link" data-issue-key="OPNFLWPLUG-988"><del>OPNFLWPLUG-988</del></a>:</p> <blockquote><p>seeing this gives me an idea for an Enhancement, in the infrautils diagstatus code: What I think one would ideally want to see in this output, both on the CLI as well as when used e.g. from a CSIT script via JMX, to avoid having to dig through logs, is WHY something is in Error... so ideally, it should probably be possible to DiagStatusService report() not just a ServiceState in a ServiceDescriptor, but a Throwable to diagstatus, which would set the status to ERROR - and then the CLI/JMX/etc. could include that Throwable as more detailed background about the failure. The code catching exceptions and setting an ERROR ServiceState would then pass that Throwable to the ServiceDescriptor. In this particular case, the NPE that was apparently fixed by c/69657 would then show up there - which would probably help, in the future, to see the real problem more immediately.</p></blockquote> INFRAUTILS-31

diagstatus including cause of failures

Improvement Medium Resolved Done Jamo Luhrsen Michael Vorburger Tue, 20 Mar 2018 21:48:29 +0000 Tue, 15 May 2018 19:23:39 +0000 Tue, 15 May 2018 19:23:39 +0000 Fluorine diagstatus 0 3 <p>There are at least 2 parts - minor extension in infrautils itself, and then using that in opflowplugin, genius, netvirt... </p> <p>For infrautils the starting point would literally be to add a <tt>Throwable</tt> cause to <a href="https://github.com/opendaylight/infrautils/blob/master/diagstatus/api/src/main/java/org/opendaylight/infrautils/diagstatus/ServiceDescriptor.java" class="external-link" target="_blank" rel="nofollow noopener">org.opendaylight.infrautils.diagstatus.ServiceDescriptor</a>. Then <a href="https://github.com/opendaylight/infrautils/blob/master/diagstatus/impl/src/main/java/org/opendaylight/infrautils/diagstatus/internal/DiagStatusServiceMBeanImpl.java" class="external-link" target="_blank" rel="nofollow noopener">use that in DiagStatusServiceMBeanImpl</a>, where it puts together what you see in showSvcStatus and by JMX via Jolokia. </p> <p>Then grep for where other create a new ServiceDescriptor(...), whenever it actually caught any exception (catch Throwable { }) then pass that as cause.</p> <p>This looks like a good idea..I think I can work on it..</p> <p>&gt; This looks like a good idea..I think I can work on it..</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a> note <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jluhrsen" class="user-hover" rel="jluhrsen">jluhrsen</a> self-assigned this to himself to have a go at it, so let him, or just make sure you two sync!</p> <p>That's great then! Would let <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jluhrsen" class="user-hover" rel="jluhrsen">jluhrsen</a> work on the same.. </p> <p>starting to poke around... Not sure on any timetable yet.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/70220/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/70220/</a></p> <p>Thought about this again while thinking about <a href="https://jira.opendaylight.org/browse/INFRAUTILS-33" title="Expose ready and/or diagstatus via a non-authenticated URL" class="issue-link" data-issue-key="INFRAUTILS-33"><del>INFRAUTILS-33</del></a> .. so when this is implemented, we should add that new getErrorCause() to the acquireServiceStatusAsJSON in the DiagStatusServiceMBeanImpl so that the <a href="https://jira.opendaylight.org/browse/INFRAUTILS-33" title="Expose ready and/or diagstatus via a non-authenticated URL" class="issue-link" data-issue-key="INFRAUTILS-33"><del>INFRAUTILS-33</del></a> will report that as well, and not just the CLI which goes through acquireServiceStatusDetailed() where c/70220/1 adds it.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jluhrsen" class="user-hover" rel="jluhrsen">jluhrsen</a> OK to close this JIRA issue now that c/70220 is merged, or wanna keep it open?</p> Duplicate INFRAUTILS-36 Relates OPNFLWPLUG-988 Development Rank 0|i03bxj: