https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INFRAUTILS-41 infrautils <p>Bump io.dropwizard.metrics : metrics-core &amp; Co. from old 3.2.5 to latest current non-RC release 4.0.2.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/72223/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72223/</a> is hitting an interesting OSGi problem:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Running org.opendaylight.odlparent.featuretest.SingleFeatureTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 14.316 sec &lt;&lt;&lt; FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/vorburger/dev/ODL/git/infrautils/common/features/odl-infrautils-metrics/target/feature/feature.xml, Feature: odl-infrautils-metrics 1.4.0.SNAPSHOT] Time elapsed: 14.04 sec &lt;&lt;&lt; ERROR! org.osgi.service.resolver.ResolutionException: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=odl-infrautils-metrics; type=karaf.feature; version="[1.4.0.SNAPSHOT,1.4.0.SNAPSHOT]"; filter:="(&amp;(osgi.identity=odl-infrautils-metrics)(type=karaf.feature)(version&gt;=1.4.0.SNAPSHOT)(version&lt;=1.4.0.SNAPSHOT))" [caused by: Unable to resolve odl-infrautils-metrics/1.4.0.SNAPSHOT: missing requirement [odl-infrautils-metrics/1.4.0.SNAPSHOT] osgi.identity; osgi.identity=org.opendaylight.infrautils.metrics-impl; type=osgi.bundle; version="[1.4.0.SNAPSHOT,1.4.0.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.opendaylight.infrautils.metrics-impl/1.4.0.SNAPSHOT: missing requirement [org.opendaylight.infrautils.metrics-impl/1.4.0.SNAPSHOT] osgi.wiring.package; filter:="(&amp;(osgi.wiring.package=com.codahale.metrics.jvm)(version&gt;=4.0.0)(!(version&gt;=5.0.0)))" [caused by: Unable to resolve io.dropwizard.metrics.jvm/4.0.2: missing requirement [io.dropwizard.metrics.jvm/4.0.2] osgi.wiring.package; filter:="(osgi.wiring.package=com.sun.management)"]]]</pre> </div></div> <p>This <tt>com.sun.management</tt> package seems to be <a href="https://docs.oracle.com/javase/8/docs/jre/api/management/extension/com/sun/management/package-summary.html" class="external-link" target="_blank" rel="nofollow noopener">officially documented</a> (and I guess <a href="https://bugs.openjdk.java.net/browse/JDK-8077953" class="external-link" target="_blank" rel="nofollow noopener">part of OpenJDK as well</a>, not just Oracle's distro).</p> <p>In the <tt>MANIFEST.MF</tt> of ~/.m2/repository/io/dropwizard/metrics/metrics-jvm/4.0.2/metrics-jvm-4.0.2.jar there is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">Import-Package: org.slf4j;version=<span class="code-quote">"[1.6.0,2.0.0)"</span>,com.codahale.metrics ;version=<span class="code-quote">"[4.0,5)"</span>,com.sun.management,javax.management Export-Package: com.codahale.metrics.jvm;uses:=<span class="code-quote">"com.codahale.metrics,javax.management"</span>;version=<span class="code-quote">"4.0.2"</span></pre> </div></div> INFRAUTILS-41

Bump dropwizard.metrics from 3.2.5 to 4.0.2

Improvement Medium Resolved Done Michael Vorburger Michael Vorburger Thu, 24 May 2018 13:05:00 +0000 Tue, 4 Sep 2018 20:51:54 +0000 Tue, 4 Sep 2018 20:51:54 +0000 Fluorine metrics 0 3 <p>&gt; This com.sun.management package ...</p> <p>but it's probably not exposed as an Export-Package by .. "the JDK" - but where is that defined?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=tpantelis" class="user-hover" rel="tpantelis">tpantelis</a> <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a> any suggestion how to best and "correctly" address this where?</p> <p>You can add it to the etc/jre.properties.</p> <p>&gt; You can add it to the etc/jre.properties.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=tpantelis" class="user-hover" rel="tpantelis">tpantelis</a> OMG, yes that works - you're the man! <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> I never noticed etc/jre.properties before - thank you!</p> <p>Therefore so proposed in <a href="https://git.opendaylight.org/gerrit/#/c/72236/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72236/</a> ...</p> <p>I've locally verified that c/72223 passes IFF one grabs c/72236, does an mvn install of odlparent/karaf (NOT just odlparent/karaf/opendaylight-karaf-resources) AND bumps infrautils/common/features/odl-infrautils-metrics from 3.1.0 to 3.1.2-SNAPSHOT.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> any chance will you cut a 3.1.2 some time?</p> <p>Are we sure we want to add com.sun.management? Relying on com.sun.anything is risky. Does dropwizard actually need it and why....</p> <p>In general com.sun.* is certainly bad, but given that this <tt>com.sun.management</tt> package seems to be <a href="https://docs.oracle.com/javase/8/docs/jre/api/management/extension/com/sun/management/package-summary.html" class="external-link" target="_blank" rel="nofollow noopener">officially documented</a> (and I guess <a href="https://bugs.openjdk.java.net/browse/JDK-8077953" class="external-link" target="_blank" rel="nofollow noopener">part of OpenJDK as well</a>, not just Oracle's distro), I'd argue that this seems to be a valid exception to the general rule.</p> <p>I've not dug into the details of what Dropwizard Metrics does with com.sun.management, but that doc gives us a good clue - that stuff all seems useful for exposing to monitoring tools, and not too nefarious.</p> <p>We briefly discused this during the Kernel Projects sync call yesterday:</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a> would really like this package to only be an optional import of Dropwizard Metrics. I'll propose that there.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> seemed to not be against / be OK with <a href="https://git.opendaylight.org/gerrit/#/c/72236/" class="external-link" target="_blank" rel="nofollow noopener">c/72236</a>, based on above (I think).</p> <p> </p> <p>Yes, <a href="https://git.opendaylight.org/gerrit/#/c/72236/" class="external-link" target="_blank" rel="nofollow noopener">c/72236</a> only makes the package available (if it’s there), it doesn’t tie our distribution to its availability, AFAICT. The main problem is really Metrics’ <b>dependency</b> on it.</p> <p><a href="https://github.com/dropwizard/metrics/pull/1317" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/dropwizard/metrics/pull/1317</a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> do you remember if there was anything left to do here? <a href="https://github.com/dropwizard/metrics/pull/1317" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/dropwizard/metrics/pull/1317</a> went in over there, and we'll pick it up in <a href="https://jira.opendaylight.org/browse/INFRAUTILS-40" title="Bump dropwizard.metrics from 4.0.2 to 5.0.0 (or at least 4.1.0) when available" class="issue-link" data-issue-key="INFRAUTILS-40"><del>INFRAUTILS-40</del></a> - so I'm closing this one as Done (this has gone into Fluorine; <a href="https://jira.opendaylight.org/browse/INFRAUTILS-40" title="Bump dropwizard.metrics from 4.0.2 to 5.0.0 (or at least 4.1.0) when available" class="issue-link" data-issue-key="INFRAUTILS-40"><del>INFRAUTILS-40</del></a> will be Neon).</p> Blocks INFRAUTILS-40 Relates TSC-117 Development Rank 0|i03euv: