https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INFRAUTILS-45 infrautils <p>diagstatus currently uses JMX RMI to fetch service status from remote nodes in an ODL cluster.</p> <p>diagstatus implementation already supports fetching the status with JSON over HTTP. And would be good to migrate the CLI to use the same instead of JMX RMI, so that we can reduce the overhead of opening an additional port for RMI, and all other related concerns.</p> INFRAUTILS-45

Use /diagstatus JSON to fetch remote status instead of JMX RMI

Improvement Medium Verified Done Faseela K Faseela K Fri, 27 Jul 2018 11:46:51 +0000 Wed, 12 Dec 2018 17:38:45 +0000 Wed, 12 Dec 2018 17:38:37 +0000 Neon diagstatus 1 2 <p>&gt; diagstatus implementation already supports fetching the status with JSON over HTTP</p> <p><a href="https://jira.opendaylight.org/browse/INFRAUTILS-33" title="Expose ready and/or diagstatus via a non-authenticated URL" class="issue-link" data-issue-key="INFRAUTILS-33"><del>INFRAUTILS-33</del></a> added that. </p> <p>As part of this work, we should just completely remove all of the JMX related code in diagstatus.</p> <p>For the JSON processing, can I suggest that instead of writing the inverse of <a href="https://github.com/opendaylight/infrautils/blob/master/diagstatus/impl/src/main/java/org/opendaylight/infrautils/diagstatus/internal/DiagStatusServiceImpl.java#L106" class="external-link" target="_blank" rel="nofollow noopener">the getAllServiceDescriptorsAsJSON() method</a> with a <tt>JsonReader</tt>, we use this as the opportunity to write a small Java class describing the structure of the JSON message (as it is now, to remain fully backwards compatible), and <a href="https://github.com/google/gson/blob/master/UserGuide.md#object-examples" class="external-link" target="_blank" rel="nofollow noopener">use GSON to map a JSON string from and to that class</a>.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a> while I'm reviewing your <a href="https://git.opendaylight.org/gerrit/#/c/77730/" class="external-link" target="_blank" rel="nofollow noopener">c/77730</a>, I'm realizing that this is a fairly major implementation change, and thought it could be worthwhile to clarify what target Fix Version you had in mind for this? Obviously master/Neon - only? Fine for me. I would be slightly reluctant to accept this e.g. for stable/oxygen - just because we spent some time to stabilize this feature there (with HTTP GET vs. HEAD and IPv6 related and what not other issues we hit over the last few months on this front), personally I would be against rocking that old stable boat.</p> <p>Neon alone should be good enough <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=vorburger" class="user-hover" rel="vorburger">vorburger</a>!</p> Blocks INFRAUTILS-33 Development Rank 0|i03h8f: