https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INTDIST-99 integration-distribution <p>mysql-connector-java is packaged in system/ by karaf-plugin in our default distribution, despite not being license friendly.  More background on <a href="https://lists.opendaylight.org/pipermail/odlparent-dev/2018-February/001761.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/odlparent-dev/2018-February/001761.html</a></p> INTDIST-99

karaf-plugin packages mysql-connector-java

Bug Highest Resolved Done Ryan Goulding Ryan Goulding patch_merged Mon, 26 Feb 2018 23:08:10 +0000 Wed, 4 Jul 2018 10:35:29 +0000 Wed, 28 Feb 2018 14:47:45 +0000 Nitrogen Oxygen 0 7 <p><a href="https://git.opendaylight.org/gerrit/#/c/68789/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68789/</a></p> <blockquote><p><a href="https://git.opendaylight.org/gerrit/#/c/68789/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68789/3</a></p></blockquote> <p>The question I guess is if we can just exclude Karaf's OSGi mySQL(TM)(R) JDBC driver support provided by Pax JDBC in odlparent? Out of curiosity, I did a (very) quick grep, and find JDBC usages at least in AAA (but that AFIK is by embedding h2, so not a problem here) and in TSDR (which I've no idea what it does; but seems again h2 only not mysql?) and something apparently related to Postgres in VTN (again, I've no clue about that ODL project). It's perhaps at least worth a question on wider lists? Not to forget all possible open and closed downstream in-house ODL applications... which this global exclusion of the mysql JDBC driver, theoretically, could break.</p> <p>An alternative could be not to do the exclusion in odlparent/karaf/karaf4-parent/, but instead let projects which build local Karaf distribution, such as netvirt/distribution/karaf and the like, opt in to do such an exclusion themselves?</p> <p>The more durable long term correct solution is probably <a href="https://ops4j1.jira.com/browse/PAXJDBC-128" class="external-link" target="_blank" rel="nofollow noopener">https://ops4j1.jira.com/browse/PAXJDBC-128</a> ... if anyone from the ODL community wants to contribute to that, I'm happy to help with getting that done (but currently don't have enough reason to see to that from A-Z myself).</p> <p>This is new as of Nitrogen (i.e., Karaf 4.0.10).  I highly doubt anything from ODL utilized it last release, but I could be wrong (I know AAA and TSDR did not).</p> <p>Other downstream projects can still utilize the artifact by deploying it using out of band methods;  this simply prevents us from shipping it.</p> <p>I can look into maven-enforcer-plugin instead, but this seemed simpler at the time.</p> <p> </p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rgoulding" class="user-hover" rel="rgoulding">rgoulding</a> just to be clear, I'm not fundamentally against your <a href="https://git.opendaylight.org/gerrit/#/c/68789/" class="external-link" target="_blank" rel="nofollow noopener">c/68789</a> being merged if other odlparent commiters are OK with it; the review &amp; comment above are feedback thoughts, not -1/-2 "I'm against <a href="https://git.opendaylight.org/gerrit/#/c/68789/" class="external-link" target="_blank" rel="nofollow noopener">c/68789</a>".</p> <p>Of course, I appreciate the feedback on it!  There are likely a few more sound ways we can do this long term, but they may require changes in upstream projects as you suggest.  If the odlparent committers like this approach, great.  If not, we will figure out what needs to be done in order to address the issue for this release.  It probably could also be solved with a simple release note, but I'm not an IP expert by any means!</p> <p>It would be easier to ship a fix for this in Oxygen if we can deal with it in integration/distribution; I’m looking into that.</p> <p>Ryan added a post-build task to remove the dependency, nicely dealing with the issue. The fix is <a href="https://git.opendaylight.org/gerrit/68844" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/68844</a> on master, <a href="https://git.opendaylight.org/gerrit/68857" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/68857</a> on Oxygen, and <a href="https://git.opendaylight.org/gerrit/68858" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/68858</a> on Nitrogen.</p> <p>The patches are merged in integration/distribution, so this isn’t a release blocker any more. It might still be worth adding a feature to odlparent to filter out undesirable GAVs, but I’ll mark this bug resolved for now...</p> <p>Patch to be merged for oxygen: <a href="https://git.opendaylight.org/gerrit/#/c/68857/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68857/</a></p> <p>Thanh has merged the oxygen patch.</p> Relates NETVIRT-1126 Development Rank 0|i03atb: