https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INTPAK-218 integration-packaging <p>"upgrade-in-progress" flag is already migrated to serviceutils.</p> <p>However, for backward compatibility the flag in genius is retained, and re-directed to the one in serviceutils. </p> <p>We have to remove this once the northbound starts using directly the flag in serviceutils.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=trozet" class="user-hover" rel="trozet">trozet</a> indicated in <a href="https://jira.opendaylight.org/browse/GENIUS-190" title="Remove upgrade-in-progress flag from GENIUS" class="issue-link" data-issue-key="GENIUS-190"><del>GENIUS-190</del></a> that a Jira needs to be raised in integration-packaging to notify the same. Please do the needful in Neon release for completing the migration, and let us know</p> INTPAK-218

Migrating upgrade-in-progress flag to ServiceUtils

Bug Medium Open Unresolved Daniel Farrell Faseela K Wed, 14 Nov 2018 04:59:50 +0000 Fri, 1 Mar 2019 06:06:30 +0000 0 6 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JankiChhatbar" class="user-hover" rel="JankiChhatbar">JankiChhatbar</a> and <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a>, I'm not sure I really understand this issue, but is this something I can help with?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=dfarrell07" class="user-hover" rel="dfarrell07">dfarrell07</a> i am not sure about the changes involved, but somewhere there is an upgrade-in-progress flag setting, which is currently pointing to a rest URL in genius, and that needs to be modified to use the migrated URL from serviceutils project</p> <p>Okay, I think I tracked down what needs to change:</p> <p><a href="https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/opendaylight-api.yaml" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/opendaylight-api.yaml</a></p> <p>Those are tasks in THT that modify the flag as part of an upgrade process. For sure the REST call needs to change from Genius to Serviceutils. Maybe also something about the match conditions when editing the file to change the var, but need to verify.</p> <p>Just documenting these here so I don't have to include the very long links in commit messages.</p> <p>This is the old Genius upgradeInProgress REST API definition:</p> <p><a href="https://git.opendaylight.org/gerrit/gitweb?p=genius.git;a=blob;f=mdsalutil/mdsalutil-api/src/main/yang/mdsalutil.yang;h=e367a375623627e2aeae516c948390e857eac50f;hb=HEAD" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=genius.git;a=blob;f=mdsalutil/mdsalutil-api/src/main/yang/mdsalutil.yang;h=e367a375623627e2aeae516c948390e857eac50f;hb=HEAD</a></p> <p>This is the new Serviceutils upgradeInProgress REST API definition:</p> <p><a href="https://git.opendaylight.org/gerrit/gitweb?p=serviceutils.git;a=blob;f=upgrade/src/main/yang/upgrade-config.yang;h=553ef966855c0185c3b49857a7ee550c180c6a4b;hb=HEAD" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=serviceutils.git;a=blob;f=upgrade/src/main/yang/upgrade-config.yang;h=553ef966855c0185c3b49857a7ee550c180c6a4b;hb=HEAD</a></p> <p>Comparing the two, you can see what needs to change.</p> <p>Patch: <a href="https://review.openstack.org/#/c/621694/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/621694/</a></p> <p>I am constantly seeing this error in karaf logs for Oxygen. Is this the side effect of this?</p> <p>2018-12-04T08:13:42,175 | ERROR | ConfigFeatureListener - ConfigPusher | AbstractFeatureWrapper           | 52 - config-persister-feature-adapter - 0.8.4.redhat-7 | Could not parse XML file /opt/opendaylight/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml<br/> java.io.FileNotFoundException: /opt/opendaylight/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml (No such file or directory)<br/>         at java.io.FileInputStream.open0(Native Method) ~<span class="error">&#91;?:?&#93;</span><br/>         at java.io.FileInputStream.open(FileInputStream.java:195) <span class="error">&#91;?:?&#93;</span><br/>         at java.io.FileInputStream.&lt;init&gt;(FileInputStream.java:138) <span class="error">&#91;?:?&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.AbstractFeatureWrapper.isConfigSnapshot(AbstractFeatureWrapper.java:116) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.AbstractFeatureWrapper.getFeatureConfigSnapshotHolders(AbstractFeatureWrapper.java:75) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.ChildAwareFeatureWrapper.getFeatureConfigSnapshotHolders(ChildAwareFeatureWrapper.java:89) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.ChildAwareFeatureWrapper.getFeatureConfigSnapshotHolders(ChildAwareFeatureWrapper.java:81) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.FeatureConfigPusher.pushConfig(FeatureConfigPusher.java:101) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.FeatureConfigPusher.pushConfigs(FeatureConfigPusher.java:69) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.ConfigPushingRunnable.processFeatureEvent(ConfigPushingRunnable.java:70) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at org.opendaylight.controller.configpusherfeature.internal.ConfigPushingRunnable.run(ConfigPushingRunnable.java:52) <span class="error">&#91;52:config-persister-feature-adapter:0.8.4.redhat-7&#93;</span><br/>         at java.lang.Thread.run(Thread.java:748) <span class="error">&#91;?:?&#93;</span></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JankiChhatbar" class="user-hover" rel="JankiChhatbar">JankiChhatbar</a> That's initial config file relevant to this, yes. It's not clear to me that it's related to this work exactly though.</p> <p>This same Serviceutils upgrade config is apparently backported all the way back to stable/oxygen:</p> <p><a href="https://git.opendaylight.org/gerrit/gitweb?p=serviceutils.git;a=blob;f=upgrade/src/main/yang/upgrade-config.yang;h=553ef966855c0185c3b49857a7ee550c180c6a4b;hb=refs/heads/stable/oxygen" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=serviceutils.git;a=blob;f=upgrade/src/main/yang/upgrade-config.yang;h=553ef966855c0185c3b49857a7ee550c180c6a4b;hb=refs/heads/stable/oxygen</a></p> <p>It seems to me like something in ODL is expecting that config file and logging the error when it's missing. That doesn't seem right, as the initial config should be optional.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JankiChhatbar" class="user-hover" rel="JankiChhatbar">JankiChhatbar</a> and <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=dfarrell07" class="user-hover" rel="dfarrell07">dfarrell07</a> the error above means that <tt>/opt/opendaylight/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml</tt> is missing ... that is <a href="https://github.com/opendaylight/serviceutils/blob/stable/oxygen/upgrade/src/main/resources/initial/serviceutils-upgrade-config.xml" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/serviceutils/blob/stable/oxygen/upgrade/src/main/resources/initial/serviceutils-upgrade-config.xml</a> which yes is the "initial config file relevant to this" (which you can then override by RESTCONF). That file should be there... it's weird that you "lost" it... <a href="https://github.com/opendaylight/serviceutils/blob/stable/oxygen/features/odl-serviceutils-tools/pom.xml" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/serviceutils/blob/stable/oxygen/features/odl-serviceutils-tools/pom.xml</a> should have installed this. (We could try to loally build an Oxygen netvirt/karaf to "prove" it's normally there?) Because <a href="https://github.com/opendaylight/serviceutils/blob/stable/oxygen/upgrade/src/main/yang/upgrade-config.yang#L21" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/serviceutils/blob/stable/oxygen/upgrade/src/main/yang/upgrade-config.yang#L21</a> defaults to false anyway (it's not nice how we duplicate stuff...), it's probably not breaking anything, but this error will likely lead to confusion, so would be good to clarify how we "loose" the serviceutils-upgrade-config.xml and make sure it's there.</p> <p>Atleast I do see this file in the target folder :</p> <p> </p> <p>C:\netvirt\karaf\target\assembly\etc\opendaylight\datastore\initial\config&gt;ls<br/> aaa-cert-config.xml default-openflow-connection-config.xml genius-itm-config.xml legacy-openflow-connection-config.xml<br/> aaa-encrypt-service-config.xml genius-ifm-config.xml genius-mdsalutil-config.xml serviceutils-upgrade-config.xml</p> <p>C:\Users\efaseel\repo\odl_upstream\netvirt\karaf\target\assembly\etc\opendaylight\datastore\initial\config&gt;</p> <p>Just to be extra sure, I just tested that in a locally freshly built Oxygen netvirt Karaf, after <tt>feature:install odl-netvirt-openstack</tt> it's OK, and indeed I do have <tt>/home/vorburger/dev/ODL/git/netvirt/karaf/target/assembly/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml</tt> present there (on Oxygen already, not just master), so it would seem like this somehow gets lost / removed / deleted by something in INTPACK somewhere...</p> <p>&gt; so it would seem like this somehow gets lost / removed / deleted by something in INTPACK somewhere...</p> <p>That would be very surprising to me, but I can't rule it out without some digging.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JankiChhatbar" class="user-hover" rel="JankiChhatbar">JankiChhatbar</a> - This is just a normal, out of the box deployment where you're seeing this error?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=dfarrell07" class="user-hover" rel="dfarrell07">dfarrell07</a> Yes. But this downstream RPM deployment so probably all patches are not available downstream yet. Would any of you mind confirming if they are.</p> <p>Actually, this sounds a lot like it could be another problem caused by <a href="https://bugs.launchpad.net/tripleo/+bug/1805859." class="external-link" target="_blank" rel="nofollow noopener">https://bugs.launchpad.net/tripleo/+bug/1805859.</a></p> <p>I have that file too. Looks like the error is well before the file was generated.</p> <p>2018-12-06T10:30:36,616 | ERROR | ConfigFeatureListener - ConfigPusher | AbstractFeatureWrapper           | 52 - config-persister-feature-adapter - 0.8.4.redhat-7 | Could not parse XML file /opt/opendaylight/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml<br/> java.io.FileNotFoundException: /opt/opendaylight/etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml (No such file or directory)</p> <p>$ ls -l etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml<br/> <del>rw-r</del><del>r</del>-. 1 odl odl 130 Dec  6 14:27 etc/opendaylight/datastore/initial/config/serviceutils-upgrade-config.xml</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JankiChhatbar" class="user-hover" rel="JankiChhatbar">JankiChhatbar</a> now that's really curious... and you obviously were in /opt/opendaylight when you did that ls?</p> <p>Not sure what's going on there. Perhaps some ordering thing, I suspect it wasn't there yet when it ran but was there when you checked... FYI it's the <tt>feature:install odl-netvirt-openstack</tt> that lays down that file there (it's not in the original ZIP and probably RPM), but that <em>ConfigFeatureListener - ConfigPusher | AbstractFeatureWrapper | config-persister-feature-adapter</em> thing should only run after that feature:install. Given how confusing this is, I would say ignore it for now, unless you are seeing a "real" problem.</p> <p>Is there a patch for this, which I can take a look at?</p> <p>Just an FYI that, we are going to merge the Genius patch soon.</p> <p>Trying to remember the details for <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a>, didn't this end up being part of <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1623123" class="external-link" target="_blank" rel="nofollow noopener">https://bugzilla.redhat.com/show_bug.cgi?id=1623123</a> and fixed in OpenStack?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=dfarrell07" class="user-hover" rel="dfarrell07">dfarrell07</a> : Thanks, if so can you close this, so that I can just focus on the CSIT side changes and genius side changes alone?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=dfarrell07" class="user-hover" rel="dfarrell07">dfarrell07</a> : Do you think this patch is still needed, and it needs to be merged?</p> <p><a href="https://review.openstack.org/#/c/621694/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/621694/</a></p> <p> </p> <p>Genius side changes are merged, just FYI</p> Blocks GENIUS-190 Development Priority Rank 0|i03khj: