https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/INTTEST-34 integration-test <h1><a name="ListOfImprovements"></a>List Of Improvements</h1> <ol> <li>Install Openstack using Robot Keywords - <a href="https://git.opendaylight.org/gerrit/#/c/63168/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/63168/</a></li> <li>Fix the Comments in the PAtch  (Documentation for all tests)</li> <li>Fix Comments in  the patch (Fix Logging in the Cases)</li> <li>Create a VM image with all Openstack Components Installed, Configured, so that the job does not use much time to install.</li> <li> Create a job that uses deployer and the image</li> <li>The job must only install ODL and networking-odl</li> </ol> INTTEST-34

Improvement for all Openstack CSIT

Improvement Medium Open Unresolved Unassigned Venkatrangan Govindarajan Wed, 21 Feb 2018 20:31:22 +0000 Wed, 21 Feb 2018 20:33:06 +0000 0 2 <p>Comments in the Patch<br/> Patch Set 40:</p> <p>(16 comments)</p> <p>I reviewed the first 5 files for now. <span class="error">&#91;Documentation&#93;</span> is missing in most (if not all) keywords. Cool stuff. looking forward to seeing how it looks in the sandbox and how much time we might save during setup.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/40//COMMIT_MSG" class="external-link" target="_blank" rel="nofollow noopener">Commit Message</a><br/> File Comment<br/> need a better commit message. I think this patch is large enough that some good details in the commit messages is warranted<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OVSDB.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@203" class="external-link" target="_blank" rel="nofollow noopener">203</a>:<br/> don't need ALL CAPS, and (for me) I don't know what Alt Approach really means. Is it not possible to use the existing keyword to get UUID? or enhance it?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@207" class="external-link" target="_blank" rel="nofollow noopener">207</a>:<br/> double check if needed, but I think the RARRAO keyword in line 206 above will give us the output for free. no need to add extra logs to the already giant output.xml<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@208" class="external-link" target="_blank" rel="nofollow noopener">208</a>:<br/> Sam showed me this:</p> <p>Should Be True '${rc}' == '0'</p> <p>I think that's more clear. If you agree, let's use that. I'll try to re-factor this in other places that already exist.<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@211" class="external-link" target="_blank" rel="nofollow noopener">211</a>:<br/> I think 'on' is better than 'to'</p> <p>same below for the other config keyword<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@217" class="external-link" target="_blank" rel="nofollow noopener">217</a>:<br/> don't think we need it.<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@222" class="external-link" target="_blank" rel="nofollow noopener">222</a>:<br/> ws<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OVSDB.robot@227" class="external-link" target="_blank" rel="nofollow noopener">227</a>:<br/> don't need it, I think.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackInstallUtils.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpenStackInstallUtils.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackInstallUtils.robot@40" class="external-link" target="_blank" rel="nofollow noopener">40</a>:<br/> probably can be a little more clean and scalable if we use loops.</p> <p>psuedo code:</p> <p>for i in num_control_nodes:<br/> ${control_${i}_connection}= Get Ssh Connection ...<br/> Set Suite Variable ${control_${i}_connection}</p> <p>then the same for compute nodes<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackInstallUtils.robot@41" class="external-link" target="_blank" rel="nofollow noopener">41</a>:<br/> ws<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackOperations.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpenStackOperations.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackOperations.robot@140" class="external-link" target="_blank" rel="nofollow noopener">140</a>:<br/> don't need Log and change Should Not Be True to</p> <p>Should Be True '${rc}' == '0'</p> <p>this applies in multiple places, so I wont make it a comment again.<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpenStackOperations.robot@1106" class="external-link" target="_blank" rel="nofollow noopener">1106</a>:<br/> ws<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpendaylightInstallUtils.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpendaylightInstallUtils.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpendaylightInstallUtils.robot@13" class="external-link" target="_blank" rel="nofollow noopener">13</a>:<br/> maybe a better name is "Configure Boot Features"?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpendaylightInstallUtils.robot@16" class="external-link" target="_blank" rel="nofollow noopener">16</a>:<br/> ws<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpendaylightInstallUtils.robot@17" class="external-link" target="_blank" rel="nofollow noopener">17</a>:<br/> interesting. does this work? does it overwrite the default featuresBoot features that are there?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/40/csit/libraries/OpendaylightInstallUtils.robot@23" class="external-link" target="_blank" rel="nofollow noopener">23</a>:<br/> ws</p> <p>Can we add more details in the commit message on how this works? Biggest confusion I have is this looks to be doing some of the work that the builder side was doing, so not sure what the work split is now.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpenStackInstallUtils.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot@2" class="external-link" target="_blank" rel="nofollow noopener">2</a>:<br/> this comment should be more about openstack install utilities<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot@10" class="external-link" target="_blank" rel="nofollow noopener">10</a>:<br/> would this stuff be better to add to DevstackUtils?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot@16" class="external-link" target="_blank" rel="nofollow noopener">16</a>:<br/> temporarily</p> <p>Does selinux really need to be disabled or do we need to open something up? I thought we fixed everything in builder to open up the right access.<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot@21" class="external-link" target="_blank" rel="nofollow noopener">21</a>:<br/> DevstackUtils.Devstack Suite Setup has code to connect to the nodes. could that be used?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackInstallUtils.robot@41" class="external-link" target="_blank" rel="nofollow noopener">41</a>:<br/> is this a standard prompt defined somewhere already? And password. Maybe they should at least be defaults on the Setup Basic Ssh keyword.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackOperations.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpenStackOperations.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackOperations.robot@143" class="external-link" target="_blank" rel="nofollow noopener">143</a>:<br/> everything is now wrapped with the OpenStack CLI keyword<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackOperations.robot@332" class="external-link" target="_blank" rel="nofollow noopener">332</a>:<br/> this is deleted now - do you need it?<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpenStackOperations.robot@457" class="external-link" target="_blank" rel="nofollow noopener">457</a>:<br/> do we need this extra log - the command logs the fip already?<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpendaylightInstallUtils.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/libraries/OpendaylightInstallUtils.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/libraries/OpendaylightInstallUtils.robot@2" class="external-link" target="_blank" rel="nofollow noopener">2</a>:<br/> odl comment<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/suites/netvirt/install/deploy_odl_with_netvirt.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/suites/netvirt/install/deploy_odl_with_netvirt.robot</a><br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/suites/netvirt/install/deploy_odl_with_netvirt.robot@2" class="external-link" target="_blank" rel="nofollow noopener">2</a>:<br/> all<br/> Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/suites/netvirt/install/deploy_odl_with_netvirt.robot@24" class="external-link" target="_blank" rel="nofollow noopener">24</a>:<br/> whitespace<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/suites/openstack/connectivity/external_network.robot" class="external-link" target="_blank" rel="nofollow noopener">csit/suites/openstack/connectivity/external_network.robot</a><br/> Base, Line <a href="https://git.opendaylight.org/gerrit/#/c/63168/67/csit/suites/openstack/connectivity/external_network.robot@a114" class="external-link" target="_blank" rel="nofollow noopener">114</a>:<br/> does this need to be removed? Is it replaced with a different test?</p> Development Rank 0|i03anj: