[L2SWITCH-25] L2switch sample fails to handle topology updates, uses deprecated APIs

Mon, 30 Oct 2017 15:41:44 +0000

When updated and original data are equal, but new data nodes are created ... TopologyDataChangeHandler's onDataChanged doesn't properly schedule a topology update.

if(linkOriginalData != null && linkUpdatedData != null
&& (linkOriginalData.size() != 0 || linkUpdatedData.size() != 0)
&& !networkGraphRefreshScheduled) {
networkGraphRefreshScheduled = linkOriginalData.size() != linkUpdatedData.size();
if(networkGraphRefreshScheduled)

{ networkGraphRefreshScheduler.schedule(new NetworkGraphRefresher(), graphRefreshDelayInSec, TimeUnit.SECONDS); }
}

This needs to be modified to use change.getCreatedOperationalData() and handle the case where only created nodes exist.

Map<InstanceIdentifier<?>, DataObject> linkCreatedData = dataChangeEvent.getCreatedOperationalData();
// change this logic, once MD-SAL start populating DeletedOperationData Set
if(linkOriginalData != null && linkUpdatedData != null && linkCreatedData != null
&& (linkOriginalData.size() != 0 || linkUpdatedData.size() != 0 || linkCreatedData.size() != 0)
&& !networkGraphRefreshScheduled) {
networkGraphRefreshScheduled = true;
if(networkGraphRefreshScheduled) { networkGraphRefreshScheduler.schedule(new NetworkGraphRefresher(), graphRefreshDelayInSec, TimeUnit.SECONDS); }

}

OpenDaylight JIRA

[L2SWITCH-25] L2switch sample fails to handle topology updates, uses deprecated APIs