https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/L2SWITCH-57 l2switch <p>Two buggy sites may raise NullPointerException in HostTracker module if concurrent remove operation occurs.</p> <p>The first case is for "transHost" variable, if a concurrent remove upon "hostsDB" variable. The corresponding snippets are attached:</p> <p> HostNodeConnector transHost = hostsDB.get(networkAddr);<br/> transHost.setStaticHost(true);</p> <p>The second case is for "existinghost" variable. The following are snippets:</p> <p> HostNodeConnector existinghost = hostsDB.get(id);<br/> existinghost.initArpSendCountDown();</p> <p>To solve the issue, the simplest way is to add a null checker for these variable since we cannot guarantee the result from hostsDB is not NULL.</p> <p>Operating System: All<br/> Platform: All</p> L2SWITCH-57

NullPointerException in HostTracker.java

Bug Resolved Won't Do Unassigned lei xu Sat, 16 Jan 2016 04:40:04 +0000 Thu, 19 Oct 2017 21:28:01 +0000 Wed, 25 May 2016 19:04:20 +0000 unspecified General 0 3 <p>(In reply to lei xu from comment #0)<br/> &gt; Two buggy sites may raise NullPointerException in HostTracker module if<br/> &gt; concurrent remove operation occurs.<br/> &gt; <br/> &gt; The first case is for "transHost" variable, if a concurrent remove upon<br/> &gt; "hostsDB" variable. The corresponding snippets are attached:<br/> &gt; <br/> &gt; HostNodeConnector transHost = hostsDB.get(networkAddr);<br/> &gt; transHost.setStaticHost(true);<br/> &gt; <br/> &gt; The second case is for "existinghost" variable. The following are snippets:<br/> &gt; <br/> &gt; HostNodeConnector existinghost = hostsDB.get(id);<br/> &gt; existinghost.initArpSendCountDown();<br/> &gt; <br/> &gt; To solve the issue, the simplest way is to add a null checker for these<br/> &gt; variable since we cannot guarantee the result from hostsDB is not NULL.</p> <p>Hi,</p> <p>I would like to take up this bug, so could you please provide me the more details.</p> <p>Thanks,<br/> Suvitha Balu</p> <p>Hi Suvitha Balu,</p> <p>I have checked the latest sorce code of HostTracker.java in <br/> <a href="https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/controller/hosttracker.implementation/0.6.5-SNAPSHOT/" class="external-link" target="_blank" rel="nofollow noopener">https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/controller/hosttracker.implementation/0.6.5-SNAPSHOT/</a></p> <p>It seems the concurrency bugs are still there. </p> <p>First, in the line of 547 and 548, <br/> 545: if (hostExists(host)) {<br/> ...<br/> 547: HostNodeConnector existinghost = hostsDB.get(id);<br/> 548:　existinghost.initArpSendCountDown();<br/> The Line 545 cannot guarantee the id is in hostsDB, in the case, I think we can use the same reference in line 545 and 547, for example,<br/> h = hostsDB.get(id)<br/> 545: if (h != null){</p> <p>Hi Lei,<br/> Thanks for the information.</p> <p>I have checked-out the ODL Origin/master controller and L2switch code and could not find the HostTracker.java file. Is the part of any new feature or specific to any release?</p> <p>This appears to be referring to the now-defunct HostTracker that used to be in the controller using the AD-SAL. The AD-SAL was completely removed in Beryllium and the recommendation is to use the Host Tracker in the l2switch project as described here:<br/> <a href="https://wiki.opendaylight.org/view/L2_Switch:HostTracker" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/L2_Switch:HostTracker</a></p> <p>You should be able to install it by installing the Karaf feature for odl-l2switch-hosttracker.</p> Development External issue ID 4983 External issue URL Priority Rank 0|i01z9z: