https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/LISPMAP-136 lispflowmapping <p>When a southbound originated mapping lookup triggers the lazy removal of an expired mapping, said mapping is only removed from the map-cache, but not from the operational MD-SAL data-store.</p> <p>Operating System: All<br/> Platform: All</p> LISPMAP-136

Expired mapping removed from map-cache, not removed from MD-SAL

Bug Resolved Done Unassigned Lori Jakab Thu, 25 Aug 2016 23:25:31 +0000 Thu, 19 Oct 2017 21:29:17 +0000 Wed, 6 Sep 2017 06:38:40 +0000 Boron Service 0 2 <p>I have gone through the mapRequest from Lisp Southbound services which ultimately calls getMapping(src, dst) and which calls getSbMappingWithExpiration(src, dst) which I think is the function being called to get a south bound mapping. If we look at the following piece of code,</p> <p>private Object getSbMappingWithExpiration(Eid src, Eid dst) {<br/> Object mappingObject = smc.getMapping(src, dst);<br/> if (mappingObject instanceof MappingRecord) {<br/> MappingRecord mapping = (MappingRecord) mappingObject;<br/> if (MappingMergeUtil.mappingIsExpired(mapping)) </p> { dsbe.removeMapping(DSBEInputUtil.toMapping(MappingOrigin.Southbound, mapping.getEid(), new SiteId(mapping.getSiteId()), mapping)); return null; } <p> }<br/> return mappingObject;<br/> }</p> <p>This actually deletes the mapping from Data Store Back End but not from the map cache itself.</p> <p>Thi sis actually reversed: Mapping is removed from MD-SAL, but not from the local map-cache, and also not from other cluster nodes' map caches.</p> <p>Fix: <a href="https://git.opendaylight.org/gerrit/#/c/45121/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45121/</a> Pending review</p> <p>No, the bug description is correct. The mapping is removed from the map-cache inside SimpleMapCache#getMappingLpmEid, on lines 177-178. However, 'MappingMergeUtil.mappingIsExpired(mapping)' no longer works, since we removed the timestamp from MappingRecord, so 'dsbe.removeMapping()' is not invoked.</p> <p>I have a different approach in mind, which will help with <a href="https://jira.opendaylight.org/browse/LISPMAP-127" title="Expired xTR-ID mappings are not removed" class="issue-link" data-issue-key="LISPMAP-127"><del>LISPMAP-127</del></a> too. We can discuss offline more details.</p> <p>I have taken a deep look and Lori is right. I also have a solution in my thought and will love to discuss it with you. Please let me know when you are free.</p> <p>Old bug, need to see if it is still valid.</p> <p>Fixed by the time bucket patch series, verified manually.</p> Development External issue ID 6537 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i01nyf: