OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[MDSAL-1] Binding Specification: Grouping, data, typedef and identity namespaces collide https://jira.opendaylight.org/browse/MDSAL-1 mdsal <p>Simple yang of:</p> <p>grouping foo-input {<br/> leaf whatever </p> { type boolean; } <p>}</p> <p>rpc foo {<br/> input </p> { uses foo-input; } <p> <br/> }</p> <p>results in a class in the form of</p> <p>'interface FooInput extends FooInput'</p> <p>which fails to compile.</p> <p>Operating System: All<br/> Platform: All</p> MDSAL-1

Binding Specification: Grouping, data, typedef and identity namespaces collide

Improvement Resolved Done Jakub Toth Robert Varga Wed, 6 Nov 2013 13:01:02 +0000 Fri, 9 Mar 2018 18:00:01 +0000 Fri, 10 Mar 2017 11:56:47 +0000 0 8 <p>This will be addressed in next version of binding specification.</p> <p>There are two possible options how to address this:</p> <ul class="alternate" type="square"> <li>add an implicit prefix/suffix to all generated interfaces, which will say what sort of object it is (Grouping, DataContainer, etc.)</li> <li>split the top-level package namespace into appropriate packages: org.opendaylight.yang.gen.v1. {rpc,grouping,data,notification,typedef} <p>.<Namespace>...</p></li> </ul> <p>An example without grouping, in combination with case-insensitiveness of first letter:</p> <p> typedef Foo </p> { type string; } <p> container foo {<br/> leaf bar </p> { type Foo; } <p> }</p> <p>This should be fixed by <a href="https://git.opendaylight.org/gerrit/#/c/52007/27" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/52007/27</a>.</p> <p>JUnit tests example:</p> <ul> <li>Same class names in same package<br/> public void sameClassNamesSamePackageTest() { String normalizeIdentifier1 = NonJavaCharsConverter.normalizeClassIdentifier("org.example.same.package", "Foo"); String normalizeIdentifier2 = NonJavaCharsConverter.normalizeClassIdentifier("org.example.same.package", "fOo"); final String normalizeIdentifier3 = NonJavaCharsConverter.normalizeClassIdentifier("org.example.same.package", "foo"); assertEquals(normalizeIdentifier1, "Foo"); assertEquals(normalizeIdentifier2, "Foo1"); assertEquals(normalizeIdentifier3, "Foo2"); ... }</li> </ul> <p>(In reply to Robert Varga from comment #0)<br/> > Simple yang of:<br/> > <br/> > grouping foo-input {<br/> > leaf whatever </p> { > type boolean; > } <p>> }<br/> > <br/> > rpc foo {<br/> > input </p> { > uses foo-input; > } <p> <br/> > }<br/> > <br/> > results in a class in the form of<br/> > <br/> > 'interface FooInput extends FooInput'<br/> > <br/> > which fails to compile.</p> <p>So after use of NonJavaCharsConverter from <a href="https://git.opendaylight.org/gerrit/#/c/52007/27" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/52007/27</a> this will never happen. The result will -></p> <p>'interface FooInput extends FooInput1' -> acceptable</p> <p>(In reply to Vratko Polák from comment #6)<br/> > An example without grouping, in combination with case-insensitiveness of<br/> > first letter:<br/> > <br/> > typedef Foo </p> { > type string; > } <p>> container foo {<br/> > leaf bar </p> { > type Foo; > } <p>> }</p> <p>The same here. After use of NonJavaCharsConverter will be result -> </p> <p>'Foo and the next one Foo (or foo or fOo ..) will be Foo1'</p> Blocks MDSAL-40 Duplicate MDSAL-6 MDSAL-179 MDSAL-207 YANGTOOLS-405 YANGTOOLS-406 Development External issue ID 138 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02vpb: