https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-131 mdsal <p>In the lispflowmapping project we're trying to add support for binary IPv4 and IPv6 address types to use internally to improve performance when we don't need a string representation of the addresses. (See lines 24-51 in <a href="https://git.opendaylight.org/gerrit/gitweb?p=lispflowmapping.git;a=blob;f=mappingservice/lisp-proto/src/main/yang/odl-lisp-proto.yang;h=58bf372611c9937ec6c9a373966a3c8275f548a4;hb=HEAD" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=lispflowmapping.git;a=blob;f=mappingservice/lisp-proto/src/main/yang/odl-lisp-proto.yang;h=58bf372611c9937ec6c9a373966a3c8275f548a4;hb=HEAD</a>) However, when we do try to get a string representation of the binary object, we get the following stack trace:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>2016-03-01 15:47:28,756 | ERROR | pool-28-thread-1 | DOMNotificationRouterEvent | 140 - org.opendaylight.controller.sal-broker-impl - 1.4.0.SNAPSHOT | Delivery of notification org.opendaylight.controller.md.sal.binding.impl.LazySerializedDOMNotification@352556f7 caused an error in listener org.opendaylight.controller.md.sal.binding.impl.BindingDOMNotificationListenerAdapter@1c213c0c java.lang.IllegalStateException: Could not construct instance at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:71)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:329)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:122)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:69)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] at com.sun.proxy.$Proxy86.getSourceRloc(Unknown Source)[237:org.opendaylight.lispflowmapping.mappingservice.lisp-proto:1.4.0.SNAPSHOT] at org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.mapping.record.container.MappingRecordBuilder$MappingRecordImpl.equals(MappingRecordBuilder.java:462)[237:org.opendaylight.lispflowmapping.mappingservice.lisp-proto:1.4.0.SNAPSHOT] at org.opendaylight.lispflowmapping.implementation.lisp.MapServer.handleMapRegister(MapServer.java:116)[240:org.opendaylight.lispflowmapping.mappingservice.implementation:1.4.0.SNAPSHOT] at org.opendaylight.lispflowmapping.implementation.LispMappingService.handleMapRegister(LispMappingService.java:156)[240:org.opendaylight.lispflowmapping.mappingservice.implementation:1.4.0.SNAPSHOT] at org.opendaylight.lispflowmapping.implementation.LispMappingService.onAddMapping(LispMappingService.java:184)[240:org.opendaylight.lispflowmapping.mappingservice.implementation:1.4.0.SNAPSHOT] at org.opendaylight.yangtools.yang.binding.util.NotificationListenerInvoker.invokeNotification(NotificationListenerInvoker.java:91)[70:org.opendaylight.mdsal.yang-binding:0.9.0.SNAPSHOT] at org.opendaylight.controller.md.sal.binding.impl.BindingDOMNotificationListenerAdapter.onNotification(BindingDOMNotificationListenerAdapter.java:44)[142:org.opendaylight.controller.sal-binding-broker-impl:1.4.0.SNAPSHOT] at org.opendaylight.controller.md.sal.dom.broker.impl.DOMNotificationRouterEvent.deliverNotification(DOMNotificationRouterEvent.java:56)[140:org.opendaylight.controller.sal-broker-impl:1.4.0.SNAPSHOT] at org.opendaylight.controller.md.sal.dom.broker.impl.DOMNotificationRouter$1.onEvent(DOMNotificationRouter.java:68)[140:org.opendaylight.controller.sal-broker-impl:1.4.0.SNAPSHOT] at org.opendaylight.controller.md.sal.dom.broker.impl.DOMNotificationRouter$1.onEvent(DOMNotificationRouter.java:65)[140:org.opendaylight.controller.sal-broker-impl:1.4.0.SNAPSHOT] at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:128)[137:com.lmax.disruptor:3.3.2] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_74] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_74] at java.lang.Thread.run(Thread.java:745)[:1.8.0_74] Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.GeneratedConstructorAccessor75.newInstance(Unknown Source)[:1.8.0_74] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)[:1.8.0_74] at java.lang.reflect.Constructor.newInstance(Constructor.java:423)[:1.8.0_74] at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:69)[91:org.opendaylight.mdsal.binding-dom-codec:0.9.0.SNAPSHOT] ... 18 more Caused by: java.lang.IllegalArgumentException: com.google.common.io.BaseEncoding$DecodingException: Unrecognized character: [ at com.google.common.io.BaseEncoding.decode(BaseEncoding.java:228)[62:com.google.guava:18.0.0] at org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.Ipv4AddressBinary.getDefaultInstance(Ipv4AddressBinary.java:51)[237:org.opendaylight.lispflowmapping.mappingservice.lisp-proto:1.4.0.SNAPSHOT] at org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.IpAddressBinaryBuilder.getDefaultInstance(IpAddressBinaryBuilder.java:16)[237:org.opendaylight.lispflowmapping.mappingservice.lisp-proto:1.4.0.SNAPSHOT] at org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.IpAddressBinary.&lt;init&gt;(IpAddressBinary.java:37)[237:org.opendaylight.lispflowmapping.mappingservice.lisp-proto:1.4.0.SNAPSHOT] ... 22 more Caused by: com.google.common.io.BaseEncoding$DecodingException: Unrecognized character: [ at com.google.common.io.BaseEncoding$Alphabet.decode(BaseEncoding.java:503)[62:com.google.guava:18.0.0] at com.google.common.io.BaseEncoding$StandardBaseEncoding$2.read(BaseEncoding.java:675)[62:com.google.guava:18.0.0] at com.google.common.io.BaseEncoding.decodeChecked(BaseEncoding.java:245)[62:com.google.guava:18.0.0] at com.google.common.io.BaseEncoding.decode(BaseEncoding.java:226)[62:com.google.guava:18.0.0] ... 25 more </pre> </div></div> <p>Operating System: All<br/> Platform: All</p> MDSAL-131

toString() throws exception for 'type binary' binding

Bug Verified Done Peter Kajsa Lori Jakab Wed, 2 Mar 2016 00:14:38 +0000 Fri, 8 Apr 2022 20:53:40 +0000 Fri, 13 May 2016 09:07:29 +0000 0 6 <p>Could you please point to the model which triggered this and also binary data you were trying to set?</p> <p>The module is odl-lisp-proto.yang, lines 24-51, see my initial report for a link to gitweb. The binary data we tried to set was an byte[] taken from am InetAddress. The problem happens not when trying to set it, but when it has to be converted to text with .toString().</p> <p>From the error log, may be you use Ipv4AddressBinary.getDefaultInstance("XXXX") to set binary data, and the "XXXX" contains '[', so you have the error.</p> <p>Any updates on this? Would really appreciate a fix.</p> <p>Thanks,<br/> Vina</p> <p>(In reply to Tony Tkacik from comment #1)<br/> &gt; Could you please point to the model which triggered this and also binary<br/> &gt; data you were trying to set?</p> <p>On line 42 of the model that I linked to in the original bug report (odl-lisp-proto.yang) I'm defining a union of two binary types ipv4-address-binary and ipv6-address-binary as ip-address-binary. Yangtools autogenerates the IpAddressBinaryBuilder.java file under src/main/java instead of generated-sources/mdsal-binding, because it needs to be implemented. The implementation looks like this:</p> <p><a href="https://git.opendaylight.org/gerrit/gitweb?p=lispflowmapping.git;a=blob;f=mappingservice/lisp-proto/src/main/java/org/opendaylight/yang/gen/v1/urn/opendaylight/lfm/lisp/proto/rev151105/IpAddressBinaryBuilder.java;h=810d6cf7be2048e17ff0fd5d52be53817a23f906;hb=HEAD" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=lispflowmapping.git;a=blob;f=mappingservice/lisp-proto/src/main/java/org/opendaylight/yang/gen/v1/urn/opendaylight/lfm/lisp/proto/rev151105/IpAddressBinaryBuilder.java;h=810d6cf7be2048e17ff0fd5d52be53817a23f906;hb=HEAD</a></p> <p>Robert gave a quick look at the implementation (at the design forum), and said it should work as-is. However, if I try a IpAddressBinaryBuilder.getDefaultInstance("127.0.0.1") for example, I will get an exception.</p> <p>The exception from the original bug report for example is trying to log a packet address, where the address is stored in an Ipv4AddressBinary type.</p> <p>Some additional info, I retested things, since the original report was a while ago. When I add an Ipv4AddressBinary object to the datastore and read it back with RESTCONF, it is represented like this: "fwAAAQ==", which is the expected base64 encoding of the binary data (127.0.0.1). However, an IpAddressBinary object, which is the union, looks like this: "[B@6fadb49c" which looks an awful lot like a reference instead of the object inside. Hope this helps fix the bug quicker.</p> <p>fix: <br/> master - <a href="https://git.opendaylight.org/gerrit/#/c/38272/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38272/</a><br/> Be - <a href="https://git.opendaylight.org/gerrit/#/c/38358/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38358/</a></p> <p>(In reply to Peter Kajsa from comment #7)<br/> &gt; fix: <br/> &gt; master - <a href="https://git.opendaylight.org/gerrit/#/c/38272/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38272/</a><br/> &gt; Be - <a href="https://git.opendaylight.org/gerrit/#/c/38358/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38358/</a></p> <p>I just tried the suggested fix. I still see "[B@125afdf3" for an ip-address-binary based field in RESTCONF output. The _value member in the IpAddressBinary object however looks ok. Here's some code I used to test the logging output, after reading an IPv4 address from a packet:</p> <p> if (sourceRloc instanceof Inet4Address) {<br/> Ipv4AddressBinary ipv4 = new Ipv4AddressBinary(sourceRloc.getAddress());<br/> IpAddressBinary ip = new IpAddressBinary(ipv4);<br/> LOG.info("Ipv4AddressBinary: {} | IpAddressBinary: {}", ipv4, ip);<br/> }</p> <p>The output looks like this:</p> <p>2016-05-04 12:55:09,426 | INFO | lisp-sb-6-1 | MapRegisterSerializer | 255 - org.opendaylight.lispflowmapping.mappingservice.lisp-proto - 1.4.0.SNAPSHOT | Ipv4AddressBinary: Ipv4AddressBinary [_value=<span class="error">&#91;127, 0, 0, 1&#93;</span>] | IpAddressBinary: IpAddressBinary [_ipv4AddressBinary=Ipv4AddressBinary [_value=<span class="error">&#91;127, 0, 0, 1&#93;</span>], _value=<span class="error">&#91;f, w, A, A, A, Q, =, =&#93;</span>]</p> <p>RESTCONF output still shows the memory reference.</p> <p>I just pushed some code that I use for RESTCONF testing here:<br/> <a href="https://github.com/ljakab/lispflowmapping/tree/ip-address-binary" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/ljakab/lispflowmapping/tree/ip-address-binary</a></p> <p>Please let us know, whether the exception from your first comment (java.lang.IllegalStateException: Could not construct instance ...) still persists ? I think it should be ok now.</p> <p>However, there could be the same problem somewhere in Restconf as well, so we will look at it.</p> <p>(In reply to Peter Kajsa from comment #9)<br/> &gt; Please let us know, whether the exception from your first comment<br/> &gt; (java.lang.IllegalStateException: Could not construct instance ...) still<br/> &gt; persists ? I think it should be ok now.</p> <p>I can't reproduce that exception anymore, so I think it's ok.</p> <p>&gt; <br/> &gt; However, there could be the same problem somewhere in Restconf as well, so<br/> &gt; we will look at it.</p> <p>Thanks!</p> <p>(In reply to Lori Jakab from comment #10)<br/> &gt; (In reply to Peter Kajsa from comment #9)<br/> &gt; &gt; Please let us know, whether the exception from your first comment<br/> &gt; &gt; (java.lang.IllegalStateException: Could not construct instance ...) still<br/> &gt; &gt; persists ? I think it should be ok now.<br/> &gt; <br/> &gt; I can't reproduce that exception anymore, so I think it's ok.</p> <p>Actually, now that I tried to build some code using the union, I still see issues regardless of RESTCONF. You can take a look at the unit tests from the mappingservice.implementation module after applying this patch <a href="https://git.opendaylight.org/gerrit/#/c/38496/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38496/</a></p> <p> LispMappingServiceTest.onAddMappingTest_noTransportAddress:196<br/> Argument(s) are different! Wanted:<br/> lispSB.sendMapNotify(<br/> SendMapNotifyInput [_mapNotify=MapNotify [_keyId=1, augmentation=[]], _transportAddress=TransportAddress [_ipAddress=IpAddressBinary [_ipv4AddressBinary=Ipv4AddressBinary [_value=<span class="error">&#91;1, 2, 3, 0&#93;</span>], _value=[<span class="error">&#91;, B, @, 4, d, 0, 4, 0, 2, b&#93;</span>], _port=PortNumber <span class="error">&#91;_value=4342&#93;</span>, augmentation=[]], augmentation=[]]<br/> );<br/> -&gt; at org.opendaylight.lispflowmapping.implementation.LispMappingServiceTest.onAddMappingTest_noTransportAddress(LispMappingServiceTest.java:196)<br/> Actual invocation has different arguments:<br/> lispSB.sendMapNotify(<br/> SendMapNotifyInput [_mapNotify=MapNotify [_keyId=1, augmentation=[]], _transportAddress=TransportAddress [_ipAddress=IpAddressBinary [_ipv4AddressBinary=Ipv4AddressBinary [_value=<span class="error">&#91;1, 2, 3, 0&#93;</span>], _value=[<span class="error">&#91;, B, @, 1, 6, 0, c, 3, e, c, 1&#93;</span>], _port=PortNumber <span class="error">&#91;_value=4342&#93;</span>, augmentation=[]], augmentation=[]]</p> <p>If you take a look at the IpAddressBinary _value, it still shows a memory reference instead of a base64 string.</p> <p>(In reply to Lori Jakab from comment #11)<br/> &gt; If you take a look at the IpAddressBinary _value, it still shows a memory<br/> &gt; reference instead of a base64 string.</p> <p>Or the bytes themselves, as it's shown for Ipv4AddressBinary _value.</p> <p>Yangtools union codec fix: <a href="https://git.opendaylight.org/gerrit/#/c/38669/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38669/</a></p> <p>Please retest with the both patches and let us know the result. Thanks.<br/> MD-SAL: <a href="https://git.opendaylight.org/gerrit/#/c/38272/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38272/</a><br/> Yangtools: <a href="https://git.opendaylight.org/gerrit/#/c/38669/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38669/</a></p> <p>The two patches together fix all issues, including correct encoding in RESTCONF output. Thanks!</p> <p>mdsal Be: <a href="https://git.opendaylight.org/gerrit/38358" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/38358</a></p> <p>yangtools need a manual cherry-pick.</p> <p>Yangtools Be: <a href="https://git.opendaylight.org/gerrit/#/c/38853/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38853/1</a></p> Development External issue ID 5446 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02wi7: