https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-151 mdsal <p>It will make it much easier to work with List properties if in addition to setter &amp; getter we can add "adder" &amp; "remover" of elements, e.g. if the property type is List&lt;Node&gt; and today we have "void setNode(List&lt;Node&gt; node)" &amp; "List&lt;Node&gt; getNodes()", we should add also "void addNode(Node node)" and "delNode(Node node)" to make it easy to use.</p> <p>Operating System: All<br/> Platform: All</p> MDSAL-151

Add "add"/"del" utility methods to builders.

Improvement Resolved Done Jie Han Sharon Aicler Tue, 5 Apr 2016 20:33:19 +0000 Thu, 13 Sep 2018 02:48:12 +0000 Thu, 13 Sep 2018 02:48:12 +0000 Binding V2 codegen 0 5 <p>(In reply to Sharon Aicler from comment #0)<br/> &gt; It will make it much easier to work with List properties if in addition to<br/> &gt; setter &amp; getter we can add "adder" &amp; "remover" of elements, e.g. if the<br/> &gt; property type is List&lt;Node&gt; and today we have "void setNode(List&lt;Node&gt;<br/> &gt; node)" &amp; "List&lt;Node&gt; getNodes()", we should add also "void addNode(Node<br/> &gt; node)" and "delNode(Node node)" to make it easy to use.</p> <p>Hi Sharon Aicler</p> <p>I can take up this . Can you provide us more details on this requirement </p> <p>Thanks &amp; Regards,<br/> Dhevendran K</p> <p>Hi Dhevendran,<br/> This is pretty simple.... say today you have a yang def as follows:<br/> container my-container{<br/> list my-list {<br/> }<br/> }</p> <p>Today the generated method inside MyContainer builder will be:<br/> public void setMyList(List&lt;MyList&gt; lst)</p> { impl.myList = lst; }<br/> public List&lt;MyList&gt; getMyKList(){ return impl.myList; }<br/> <br/> I am suggesting add helper methods of "add" and "del"<br/> public void setMyList(List&lt;MyList&gt; lst){ impl.myList = lst; } <p> public List&lt;MyList&gt; getMyKList()</p> { return impl.myList; } <p> public void addMyList(MyList element){<br/> if(this.impl.myList==null)</p> { this.impl.myList = new ArrayList(); } <p> this.impl.myList.add(element);<br/> }<br/> public void delMyList(MyList element)</p> { this.impl.myList.remove(element); } <p>So bottom line a developer should not instantiate a list every time and allow the builder to do it.</p> <p>H Sharon Aicler</p> <p>Thanks for your input. I will get back to you on this</p> <p>Thanks &amp; Regards,<br/> Dhevendran K</p> <p>Hey Sharon,</p> <p>I think one can add the method signatures to ChildOf node in listToGenType method, and then in the BaseTemplate.xtend define methods to generate adder and remover methods by getting the method signatures through type.getMethodSignatures() in BaseTemplate.</p> <p>Is this a natural way of achieving it?</p> <p>Thank you</p> <p>Regards,<br/> Alay</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/67999/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/67999/</a></p> Development External issue ID 5673 External issue URL Issue Type Rank 0|i02wmn: