https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-194 mdsal <p>Boron:<br/> <a href="https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-boron/904/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-boron/904/</a></p> <p>Carbon:<br/> <a href="https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-carbon/30/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-carbon/30/</a></p> <p>sandbox replication to have less logs with just 1 suite:<br/> <a href="https://jenkins.opendaylight.org/sandbox/job/bgpcep-csit-1node-userfeatures-only-boron/2/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/sandbox/job/bgpcep-csit-1node-userfeatures-only-boron/2/</a></p> <p>exception:</p> <p>2016-08-22 12:02:56,916 | ERROR | on-dispatcher-63 | DataTreeChangeListenerActor | 172 - org.opendaylight.controller.sal-distributed-datastore - 1.4.0.SNAPSHOT | Error notifying listener org.opendaylight.controller.md.sal.binding.impl.BindingClusteredDOMDataTreeChangeListenerAdapter@154bfb5a<br/> java.lang.ClassCastException: com.sun.proxy.$Proxy204 cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.AfiSafi2<br/> at org.opendaylight.protocol.bgp.openconfig.impl.BGPOpenConfigMappingServiceImpl.toAddPathCapability(BGPOpenConfigMappingServiceImpl.java:124)<span class="error">&#91;213:org.opendaylight.bgpcep.bgp-openconfig-impl:0.6.0.SNAPSHOT&#93;</span><br/> at Proxye8c70dbd_9d3b_44cb_8805_66bfff157211.toAddPathCapability(Unknown Source)<span class="error">&#91;:&#93;</span><br/> at Proxyc915a486_1205_4d5f_9f62_be2b4720a69f.toAddPathCapability(Unknown Source)<span class="error">&#91;:&#93;</span></p> <p>Operating System: All<br/> Platform: All</p> MDSAL-194

exception while configuring bgp peer (boron and carbon)

Bug Resolved Done Unassigned Peter Gubka Mon, 22 Aug 2016 12:22:24 +0000 Mon, 6 Aug 2018 15:00:41 +0000 Sat, 4 Aug 2018 01:45:22 +0000 Fluorine Oxygen SR3 Binding codegen Binding runtime 0 5 <p>Attachment karaf.log.gz has been added with description: karaf log</p> <p>Possibly yangtools/mdsal bug - problem addresses via email - <a href="https://lists.opendaylight.org/pipermail/yangtools-dev/2016-August/001549.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/yangtools-dev/2016-August/001549.html</a></p> <p>A temporary workaround should be possible in BGP code.</p> <p>master: <a href="https://git.opendaylight.org/gerrit/44875" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/44875</a></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/44875/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/44875/1</a><br/> Attempted fix in Yangtools shows another exception:</p> <p>2016-08-31 10:08:47,083 | ERROR | on-dispatcher-65 | DataTreeChangeListenerActor | 200 - org.opendaylight.controller.sal-distributed-datastore - 1.5.0.SNAPSHOT | Error notifying listener org.opendaylight.controller.md.sal.binding.impl.BindingClusteredDOMDataTreeChangeListenerAdapter@69f546e2<br/> java.lang.ClassCastException: com.sun.proxy.$Proxy210 cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.AfiSafi2<br/> at org.opendaylight.protocol.bgp.openconfig.impl.BGPOpenConfigMappingServiceImpl.toAddPathCapability(BGPOpenConfigMappingServiceImpl.java:125)<span class="error">&#91;334:org.opendaylight.bgpcep.bgp-openconfig-impl:0.7.0.SNAPSHOT&#93;</span><br/> at Proxy580841b1_fd76_4386_a70a_c33a64826007.toAddPathCapability(Unknown Source)<span class="error">&#91;:&#93;</span><br/> at Proxydb312b39_aa4c_4eac_bc86_1129d5460378.toAddPathCapability(Unknown Source)<span class="error">&#91;:&#93;</span><br/> at org.opendaylight.protocol.bgp.rib.impl.config.BgpPeer.getBgpParameters(BgpPeer.java:141)<span class="error">&#91;307:org.opendaylight.bgpcep.bgp-rib-impl:0.7.0.SNAPSHOT&#93;</span></p> <p>&gt; another exception</p> <p>Well, it is basically the same one.</p> <p>There are two augmentations in play here, AfiSafi1 and AfiSafi2, which are really completely equivalent, as they end up targeting instantiations of the same grouping:</p> <p>package org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614;<br/> import org.opendaylight.yangtools.yang.binding.Augmentation;<br/> import org.opendaylight.yangtools.yang.binding.DataObject;<br/> import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.BgpNeighborAddPathsConfig;<br/> import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.multiprotocol.rev151009.bgp.common.afi.safi.list.AfiSafi;</p> <p>public interface AfiSafi1<br/> extends<br/> DataObject,<br/> Augmentation&lt;AfiSafi&gt;,<br/> BgpNeighborAddPathsConfig</p> <p>AfiSafi2 looks exactly the same. Note that we are looking for AfiSafi2 here. Based on the model (bgp-openconfig-extensions) and the call trace, we should be looking up AfiSafi1 (as that augments neighbor, AfiSafi2 augments global). This is something yangtools probably confused and should be rectified by the proposed patch.</p> <p>Now when DTCL is being invoked, we go through LazyDataObject and since we have not touched getAugmentations(), but are targeting a single one, we end up calling through DataObjectCodecContext.streamChild() and after some mucking around in augmentationByClassOrEquivalentClass().</p> <p>We then proceed to scan all real augmentations and check if any of them are equivalent using BindingReflections.isSubstitutionFor() &#8211; which returns true, as the classes are really equivalent. Hence we instantiate a proxy for AfiSafi1, thinking it is a valid replacement for AfiSafi2 and return that &#8211; leading to ClassCastException.</p> <p>So aside from bgpcep fix, <a href="https://git.opendaylight.org/gerrit/44961" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/44961</a>, which should rectify the lookup and ClassCastException, we need to solve the problem in mdsal. I can think of two avenues:</p> <ul class="alternate" type="square"> <li>teach BindingReflections to detect this problem (though it is not clear what check can be done at the class level).</li> <li>teach code generator to not emit both AfiSafi1 and AfiSafi2 &#8211; they can be safely squashed since their targets are already squashed by the binding spec</li> </ul> <p>I think we should implement the second option, as it lowers the number of classes and prevents this sort of confusion.</p> <p>The ClassCastException has disappeared, but the confusion about AfiSafi1/AfiSafi2 needs to be cleaned up in MD-SAL. Reducing severity and dropping target release.</p> <p>&gt; the confusion about AfiSafi1/AfiSafi2 needs to be cleaned up in MD-SAL</p> <p>Do we have a unit test proving the confusion has been cleaned up indeed (or another Bug tracking it if not)?</p> <p>Of course we do. <a href="https://jira.opendaylight.org/browse/MDSAL-328" title="ClassCastException when accessing augmentations" class="issue-link" data-issue-key="MDSAL-328"><del>MDSAL-328</del></a>.</p> <p>Oh, Now I see the fix: <a href="https://git.opendaylight.org/gerrit/72961" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/72961</a></p> <p>It seems that in order for Jira to show the link to a related Change, the issue name has to be written in the first line of the commit message.</p> <p>&gt; in order for Jira to show the link to a related Change</p> <p>And now I see the gerrit links in <a href="https://jira.opendaylight.org/browse/MDSAL-328" title="ClassCastException when accessing augmentations" class="issue-link" data-issue-key="MDSAL-328"><del>MDSAL-328</del></a>.<br/> Not sure why I did not see them before, I recall the link to related Openflowplugin bug...</p> Duplicate YANGTOOLS-883 BGPCEP-528 BGPCEP-537 Development External issue ID 6497 External issue URL Issue Type Rank 0|i02ww7: