https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-202 mdsal <p>There are Boron SR1 Autorelease Build Failures on mdsal binding jobs tests.</p> <p><a href="https://logs.opendaylight.org/releng/jenkins092/autorelease-release-boron/42/_console-output.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/autorelease-release-boron/42/_console-output.log.gz</a></p> <p><b>13:17:14</b> <span class="error">&#91;INFO&#93;</span> *--- maven-surefire-plugin:2.18.1:test (default-test) @<br/> mdsal-binding-java-api-generator &#8212; *<b>13:17:14</b> <span class="error">&#91;INFO&#93;</span> Surefire report directory: /w/workspace/autorelease-release-boron/mdsal/binding/mdsal-binding-java-api-generator/target/surefire-reports<br/> <b>13:17:21</b> Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.765 sec &lt;&lt;&lt; FAILURE! - in org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest<br/> <b>13:17:21</b> testGenerationContextReferenceExtension(org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest) Time elapsed: 0.027 sec &lt;&lt;&lt; ERROR!<br/> <b>13:17:21</b> org.opendaylight.yangtools.yang.parser.spi.meta.SomeModifiersUnresolvedException: Some of FULL_DECLARATION modifiers for statements were not resolved.<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.spi.source.SourceException.throwIf(SourceException.java:96)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.ContextBuilder.setArgument(ContextBuilder.java:34)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.argumentValue(StatementContextWriter.java:40)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl.enterStatement(YangStatementParserListenerImpl.java:84)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser$StatementContext.enterRule(YangStatementParser.java:113)<br/> <b>13:17:21</b> at org.antlr.v4.runtime.tree.ParseTreeWalker.enterRule(ParseTreeWalker.java:66)<br/> <b>13:17:21</b> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:49)<br/> <b>13:17:21</b> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> <b>13:17:21</b> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> <b>13:17:21</b> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl.writeFull(YangStatementSourceImpl.java:98)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.loadStatements(SourceSpecificContext.java:321)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.loadPhaseStatements(BuildGlobalContext.java:239)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildGlobalContext.java:198)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:128)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:38)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:49)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:53)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest.generateTestSources(CompilationTest.java:666)<br/> <b>13:17:21</b> at org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest.testGenerationContextReferenceExtension(CompilationTest.java:444)<br/> <b>13:17:21</b></p> <p>Operating System: All<br/> Platform: All</p> MDSAL-202

MDSAL Boron SR1 Autorelease Build Failure

Bug Resolved Done Robert Varga A H Fri, 21 Oct 2016 21:27:57 +0000 Fri, 9 Mar 2018 18:00:17 +0000 Sun, 23 Oct 2016 21:05:39 +0000 0 2 <p>Could it be related these two patches?</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/47223/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/47223/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/47200/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/47200/</a></p> <p>&gt; Could it be related these two patches?<br/> &gt; <a href="https://git.opendaylight.org/gerrit/#/c/47223/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/47223/</a><br/> &gt; <a href="https://git.opendaylight.org/gerrit/#/c/47200/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/47200/</a></p> <p>No, I'm 99.9% sure that this isn't cause by either of those two... I've just (locally) reverted both, one after the other as well as both together; but the same test failure still occurs. So this must be caused by something else..</p> <p>Note that on master this CompilationTest.testGenerationContextReferenceExtension fails as well.</p> <p>I'll now spend a max. 1/2h time boxed to debug the test and try to understand and fix the failure. (If do not comment any further in this issue, I was unsuccessful.)</p> <p>I've just found that this test failure is caused by commit c157a9dd65426473b7cd87de68d6639c9e91f403 which was for <a href="https://jira.opendaylight.org/browse/YANGTOOLS-692" title="Parser: duplicate ModelDefinedStatementDefinitions" class="issue-link" data-issue-key="YANGTOOLS-692"><del>YANGTOOLS-692</del></a> "Define a namespace to hold model-defined statements" .. reverting everything up to that patch fixes this test. I'll now try to revert only that patch, to see if that alone is sufficient.</p> <p>NB: It MAY well be that the problem is more in that test than the patch, but Robert should make that determination in the coming days. I'll limit myself to identify which change introduced the test failure here.</p> <p>&gt; revert only that patch, to see if that alone is sufficient</p> <p>Indeed it is; so I've raised <a href="https://git.opendaylight.org/gerrit/#/c/47389/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/47389/</a>, which will fix this CompilationTest failure. Again it's possible that this is more of a problem in that test than a real issue - I'm unable to tell (Robert will).</p> <p><a href="https://jira.opendaylight.org/browse/YANGTOOLS-692" title="Parser: duplicate ModelDefinedStatementDefinitions" class="issue-link" data-issue-key="YANGTOOLS-692"><del>YANGTOOLS-692</del></a> seems to be about "just" a memory optimization; so my recommendation, given that this is a Blocker for Boron SR1 release, would be that someone merge my c/47389 revert - and close this issue as done. I've re-opened <a href="https://jira.opendaylight.org/browse/YANGTOOLS-692" title="Parser: duplicate ModelDefinedStatementDefinitions" class="issue-link" data-issue-key="YANGTOOLS-692"><del>YANGTOOLS-692</del></a> so that it can be re-introduced after rework, or just fix up CompilationTest (and it will have to be done on both stable/boron and master there).</p> <p>master: <a href="https://git.opendaylight.org/gerrit/47399" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/47399</a><br/> boron: <a href="https://git.opendaylight.org/gerrit/47403" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/47403</a></p> <p>The "just" optimization has a side effect of actually fixing a bug, which allowed this invalid YANG to pass validation.</p> Development External issue ID 7009 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02wxz: