https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-229 mdsal <p>CheckedFuture is being removed from Guava, which means that we need to make an API-incompatible change before we can upgrade.</p> <p>mdsal-dom-api is one of the affected APIs, which needs cooperation with downstreams.</p> <p>Operating System: All<br/> Platform: All</p> MDSAL-229

mdsal-dom-api: get rid of CheckedFuture

Epic Medium Resolved Done Tom Pantelis Robert Varga Wed, 25 Jan 2017 20:46:42 +0000 Mon, 6 Aug 2018 08:28:48 +0000 Mon, 6 Aug 2018 08:28:48 +0000 Fluorine 0 5 <p>We have three options here:</p> <p>1) The approach we have taken in Binding V2, where we have an explicit callback interface of two methods</p> <p>2) Augment 1) with using BiConsumer&lt;Throwable, T result&gt;, allowing the use of lambdas, but having callers having to check failures first</p> <p>3) Switch to using java.util.CompletionStage</p> <p>Options 1&amp;2 have the benefit of not being tied to a particular Future-like contract, hence are open to bridging:</p> <p>RpcService s;<br/> CompletableFuture&lt;T&gt; f = new CompletableFuture();</p> <p>s.invokeRpc(..., (t, r) -&gt; {<br/> if (t != null) </p> { f.completeExceptionally(t); } <p> else </p> { f.complete(r); } <p>}</p> <p>With the same approach being possible for Guava, Scala and others. It also does not give semblance of having a synchronous get() interface.</p> <p>CompletionStage is similarly flexible, with converters for Scala being readily available &#8211; but has one wrinkle, that of CompletionStage#toCompletableFuture(). That method exposes complete(), which is not appropriate and can actually be not implemented. This would leave us vulnerable to users assuming CompletionStages can be converted and that being broken when a different implementation is substituted.</p> <p>I think I prefer #2 as the core API with a library of utilities bridging callbacks to popular Future-likes:</p> <p>RpcService s:<br/> ListenableFuture&lt;T&gt; f = GuavaRpcServiceAdaptor.invokeRpc(s, ...);</p> <p>where GuavaRpcServiceAdaptor will provide briding to the future, which can then be composited as usual.</p> <p>Since the bug is unassigned I'm currently assigning it to you.</p> <p>Please assign to the relevant person. </p> Relates MDSAL-283 MDSAL-284 MDSAL-337 Development External issue ID 7684 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02x3z: