[MDSAL-261] IllegalArgumentException thrown when uses a grouping which name is not unique

Fri, 9 Mar 2018 18:00:21 +0000

An IllegalArgumentException thrown when uses a grouping which name is not unique such as "grouping A & container A" shown below, and then the wrong target node "container A" would be found by findOriginalTargetFromGrouping.
sample yang models：
1)
module groupings {
namespace "yang:test:main:my:groupings";
prefix s;
revision 2017-05-15 {
}

grouping A{
container A1 {
leaf leaf-A-A1

{ type string; }

}
}

container A{
leaf leaf-A

{ type string; }

}
}

2)
module uses-augment-recursive {
namespace "yang:test:main:my:uses-augment-recursive";
prefix r;

revision 2017-05-19 {
}

import groupings

{ prefix "grp"; }

grouping D{
uses "grp:A" {
augment "A1" {
leaf D-aug-A1

{ type string; }

}
}
}
}

java.lang.IllegalArgumentException: Failed to generate code for augment in UsesEffectiveStatementImpl[groupingPath=AbsoluteSchemaPath

{path=[(yang:test:main:my:groupings?revision=2017-05-15)A]}

]

at org.opendaylight.mdsal.binding.javav2.generator.impl.AugmentToGenType.findOriginalTargetFromGrouping(AugmentToGenType.java:277)
at org.opendaylight.mdsal.binding.javav2.generator.impl.AugmentToGenType.usesAugmentationToGenTypes(AugmentToGenType.java:230)
at org.opendaylight.mdsal.binding.javav2.generator.impl.GenHelperUtil.processUsesAugments(GenHelperUtil.java:243)
at org.opendaylight.mdsal.binding.javav2.generator.impl.GenHelperUtil.groupingToGenType(GenHelperUtil.java:872)
at org.opendaylight.mdsal.binding.javav2.generator.impl.GenHelperUtil.groupingsToGenTypes(GenHelperUtil.java:829)
at org.opendaylight.mdsal.binding.javav2.generator.impl.ModuleToGenType.generate(ModuleToGenType.java:50)
at org.opendaylight.mdsal.binding.javav2.generator.impl.BindingGeneratorImpl.generateTypes(BindingGeneratorImpl.java:126)
at org.opendaylight.mdsal.binding.javav2.java.api.generator.GeneratorJavaFileTest.myGeneratedFilesTest(GeneratorJavaFileTest.java:38)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

OpenDaylight JIRA

[MDSAL-261] IllegalArgumentException thrown when uses a grouping which name is not unique