https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-29 mdsal <p>Yangtools will currently generate code like:</p> <p>throw new IllegalArgumentException(String.format("Invalid length: {}, expected: {}.", value, lengthConstraints));</p> <p>This is incorrect since {} is a slf4j-style format specifier when you want a format string.</p> <p>Operating System: Linux<br/> Platform: PC</p> MDSAL-29

Incorrect use of format strings in generated code when backing type is an array

Improvement Resolved Cannot Reproduce Jakub Toth Rob Adams Thu, 12 Jun 2014 18:34:35 +0000 Fri, 9 Mar 2018 18:00:03 +0000 Fri, 13 Jan 2017 15:04:20 +0000 0 7 <p>The attached patch fixes the format string bug, but when I apply, the unit tests fail because of an apparent different bug.</p> <p>Failed tests: test(org.opendaylight.yangtools.sal.java.api.generator.test.TypedefCompilationTest): expected:&lt;Invalid length: abcd[, expected: [<span class="error">&#91;5‥11&#93;</span>]].&gt; but was:&lt;Invalid length: abcd[e, expected: [<span class="error">&#91;6‥10&#93;</span>]].&gt;</p> <p>Attachment 1193.patch has been added with description: Fixes format bug</p> <p>The failed test was not a real bug but a bug in the unit test that was masked by the previous format string bug.</p> <p>Fixed in:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/7965/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/7965/</a></p> <p>Reopening with low priority, as the format string does not return useful value, when the value is an array. Quoting findbugs warning: </p> <p>'One of the arguments being formatted with a format string is an array. This will be formatted using a fairly useless format, such as [I@304282, which doesn't actually show the contents of the array. Consider wrapping the array using Arrays.asList(...) before handling it off to a formatted.'</p> <p>Added as blocking issue for Topic: Decrease Technical Debt.</p> <p>fix needs cherry-pick to Boron</p> Blocks MDSAL-55 YANGTOOLS-361 Development External issue ID 1193 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02vvj: