https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-294 mdsal <p>Having a @CheckReturnValue annotation always generated would make perfect sense IMHO, because we could then use that in static code analysis to ensure that all users of the RPC do check the Future RpcResult for errors - even if there is no Output.</p> <p>The "@CheckReturnValue on YANG RPC generated interfaces extending RpcService" thread on <a href="https://lists.opendaylight.org/pipermail/mdsal-dev/2017-November/thread.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/mdsal-dev/2017-November/thread.html</a> has the full background.</p> MDSAL-294

Add @CheckReturnValue on YANG RPC generated interfaces extending RpcService

Improvement Medium Verified Done Jie Han Jie Han Fri, 3 Nov 2017 00:45:52 +0000 Thu, 28 Jun 2018 23:33:58 +0000 Thu, 28 Jun 2018 23:33:58 +0000 Binding codegen Binding V2 codegen 0 3 <p>This would be great!</p> <p>Hi M. ,<br/> <a href="https://git.opendaylight.org/gerrit/65063" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/65063</a><br/> I hava no idea about the failure, everythig goes well in my local environment,<br/> Can you help me figure out why?</p> <p>javax.annotation classes are not available in karaf's production environment.</p> <p>Should we split the generator implementaion from runtime correlative in mdsal-binding-generator-impl,<br/> and put it into a saperate directory?</p> <p>This change should be part of the generated template, which is already split out.</p> <p>I see, I'll try to add it in template tomorrow. Thanks Robert.</p> <p>Well, actually the problem is that you are referring to the annotation class itself &#8211; were you to encode the string literals directly, your patch would work just fine</p> <p>Yes, I have thought about the way using the string directly, but I feel that's not enough strict<img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>This is, naturally, good, impacting projects who have already enforced FindBugs non-violation and who do have code that ignores RPC returns.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/65379/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/65379/</a> has related fix in genius. I'm about to add a small new util in infrautils to make it easier.</p> Development Rank 0|i03767: