https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-3 mdsal <p>Greetings,<br/> in ietf-yang-types project there is generated class MacAddress having following flaws:</p> <ul class="alternate" type="square"> <li>Pattern is not thread safe - should not be compiled once in static block</li> <li>field patterns is not accessible so it can't be really validated</li> </ul> <p>Questions/Suggestions:</p> <ul class="alternate" type="square"> <li>why is it not validated in contructor (string version)?</li> <li>if it is not efficient to validate at creation time, can the regex pattern list be exposed to validate later?</li> </ul> <p>Operating System: All<br/> Platform: All</p> MDSAL-3

MacAddress flaws

Improvement Resolved Done Unassigned Michal Rehak Thu, 5 Dec 2013 10:37:54 +0000 Fri, 9 Mar 2018 18:00:01 +0000 Mon, 17 Oct 2016 08:25:41 +0000 0 5 <p>The thread safety issues have been fixed. The proposed changes will be address after Hydrogen release by introducing a static factory method of the form:</p> <p>public static MacAddress checkedCreate(String value);</p> <p>which will perform validation.</p> <p>investigating</p> <p>following changes were made<br/> method checkedCreate generation was added to ClassTemplate.xtend</p> <ul class="alternate" type="square"> <li>situation when union type is generated isn't fixed (how many<br/> checkedCreate methods should be generated - one for every union type<br/> with pattern or one common checkedCreate method?)</li> <li>building constant PATTERN_CONSTANT_NAME and pattern list was removed<br/> from TypeProviderImpl and was moved directly to ClassTemplate.xtend</li> </ul> <p><a href="https://git.opendaylight.org/gerrit/#/c/5589/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/5589/</a></p> <p>This has been partially fixed. The checkCreate has not been created and needs to be addressed in the next binding spec.</p> <p>Patterns are enforced in the constructor and there is an IetfInetUtils class to help with known-good MAC address creation.</p> Development External issue ID 210 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02vpr: