https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-310 mdsal <p>It is impossible to construct instance identifier, which will explicitly reference choice / case. This makes binding instance identifier not suffiecient expresive,<br/> since it is impossible to uniquelly reference nodes in following situation:</p> <p>Module 1:<br/> grouping foo {<br/> container bar {</p> <p> }<br/> }</p> <p> choice bar {<br/> case foo </p> { uses foo; } <p> }</p> <p>Module 2</p> <p> augment bar {<br/> case foo2 </p> { uses foo; } <p> }</p> <p>Operating System: All<br/> Platform: All</p> MDSAL-310

Instance Identifier is unable to represent Choice / Case, only children

Bug Medium Resolved Done Jie Han Tony Tkacik Fri, 1 Aug 2014 14:02:43 +0000 Thu, 13 Sep 2018 02:47:45 +0000 Thu, 13 Sep 2018 02:47:45 +0000 Binding V2 codegen Binding V2 runtime 0 6 <p>&gt; in following situation</p> <p>This is very similar to description of "two sibling nodes with the same local name" in <a href="https://tools.ietf.org/html/draft-lhotka-netmod-yang-json-02#section-3.1" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-lhotka-netmod-yang-json-02#section-3.1</a></p> <p>How does ODL distinguish "foomod:bar" from "barmod:bar" (leafs in that link), and why does it not work for distinguishing "module1:bar" from "module2:bar" (inner containers in this Bug)?</p> <p>See RFC 7950 section 6.2.1:</p> <blockquote><p>o All leafs, leaf-lists, lists, containers, choices, rpcs, actions,<br/> notifications, anydatas, and anyxmls defined (directly or through<br/> a "uses" statement) within a parent node or at the top level of<br/> the module or its submodules share the same identifier namespace.<br/> This namespace is scoped to the parent node or module, unless the<br/> parent node is a case node.<font color="red"> In that case, the namespace is scoped<br/> to the closest ancestor node that is not a case or choice node</font>.</p></blockquote> <p>So, the yang defined above seems illegal as there're two 'bar' containers.</p> <p>Detection of node name collision should be completed by yangtool parser, move this bug to YANGTOOLS.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/68134/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68134/</a></p> <p>This issue has nothing to do with YangInstanceIdentifier nor organization of anything in yangtools. This concerns only the design of InstanceIdentifier, as defined in binding – SchemaContext provides all information required to make it work.</p> <p>Please do not hijack issues to completely unrelated issues.</p> <p>Not at all I thought, the Instance Idendifier does not need to represent Choice/Case, it's nothing to do with binding, as in description I got that why the issue created is totally because there are name collision, the immediate idea of reporter to resolve that is to reference choice/case, but that's not the root cause.</p> <p>What should the binding instance identifier of choice/case's descendant data nodes finally be?<br/> For yang snippet:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> module test {   ...   container top {     choice top-choice {        <span class="code-keyword">case</span> case1 {              container cont-in-case1 {  }               choice case1-choice {                       <span class="code-keyword">case</span> case11 {                             container cont-in-case11 { }                       }                }        }   } } module aug-test {   ...   augment <span class="code-quote">"/test:top/top-choice/case1"</span> {           choice aug-case1-choice {                       <span class="code-keyword">case</span> case12 {                             container cont-in-case12 { }                       }             }   } } </pre> </div></div> <p>1.II for 'cont-in-case1' could be:<br/> A) InstanceIdentifier.builder(Top.class).child(ContInCase1.class) .build()or<br/> B) InstanceIdentifier.builder(Top.class).child(TopChoice.class).child(Case1.class).child(ContInCase1.class) .build()</p> <p>2.II for 'cont-in-case11' could be:<br/> A) InstanceIdentifier.builder(Top.class).child(ContInCase11.class) or <br/> B) InstanceIdentifier.builder(Top.class).child(TopChoice.class).child(Case1.class).child(Case1Choice.class).child(Case11.class) <br/> .child(ContInCase11.class).build()</p> <p>3.II for 'cont-in-case12' could be:<br/> A) InstanceIdentifier.builder(Top.class).child(ContInCase12.class).build() or<br/> B) InstanceIdentifier.builder(Top.class).child(TopChoice.class).child(Case1.class).augment(Case1Augment.class)<br/> .child(AugCase1Choice.class).child(Case12.class).child(CintInCase12.class).build()</p> <p>Since choice and case are not data tree nodes, so I prefer to choose option A).</p> <p>Instance identifier should not reference choice/case.<br/> MDSAL master: <a href="https://git.opendaylight.org/gerrit/68099" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/68099</a></p> <p>Based on the analysis done in <a href="https://jira.opendaylight.org/browse/MDSAL-45" title="InstanceIdentifier does not properly capture choice-case child relationship" class="issue-link" data-issue-key="MDSAL-45"><del>MDSAL-45</del></a> and <a href="https://jira.opendaylight.org/browse/MDSAL-342" title="DataObjectModification not able find child via getModifiedChildContainer" class="issue-link" data-issue-key="MDSAL-342"><del>MDSAL-342</del></a>, this issue should focus on addressability of choice/case statements <b>only</b>. I.e. solving the problem of 'how can I read the entire choice, so that I can decide which case it actually is?'. Note this has implications on DataTreeChangeListener: if InstanceIdentifier can address choices, we need to teach DataObjectModification how to represent a change inside a particular case and also the choice becoming a different case.</p> <p><a href="https://git.opendaylight.org/gerrit/68099" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/68099</a></p> Blocks MDSAL-237 Relates MDSAL-45 Development External issue ID 1466 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02vyn: