https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-321 mdsal <p>A simple test model:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>    container foo {         leaf foo {             type enumeration {                 enum "foo";             }         }     } </pre> </div></div> <p>results in compilation failure:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project mdsal-binding-test-model: Compilation failure: Compilation failure: [ERROR] /home/nite/odl/mdsal/binding/mdsal-binding-test-model/target/generated-sources/mdsal-binding/org/opendaylight/yang/gen/v1/opendaylight/nested/types/norev/Foo.java:[98,69] cannot find symbol [ERROR]   symbol:   class Foo [ERROR]   location: interface org.opendaylight.yang.gen.v1.opendaylight.nested.types.norev.Foo [ERROR] /home/nite/odl/mdsal/binding/mdsal-binding-test-model/target/generated-sources/mdsal-binding/org/opendaylight/yang/gen/v1/opendaylight/nested/types/norev/Foo.java:[31,12] interface org.opendaylight.yang.gen.v1.opendaylight.nested.types.norev.Foo is already defined in package org.opendaylight.yang.gen.v1.opendaylight.nested.types.norev </pre> </div></div> MDSAL-321

Binding V1 generates incorrect code for nested classes

Bug Medium Resolved Done Robert Varga Robert Varga Mon, 12 Mar 2018 14:22:54 +0000 Wed, 2 May 2018 09:52:42 +0000 Wed, 2 May 2018 09:52:16 +0000 Oxygen SR1 Fluorine Binding codegen 0 1 <p>This failure is a violation of JLS9 section 8.1:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>It is a compile-time error if a class has the same simple name as any of its enclosing classes or interfaces.</pre> </div></div> <p>Which means that we need to understand nesting so that we do not ever generated something like:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>class Foo { public static class Foo { public static class Foo { } } }</pre> </div></div> <p>In that block the first nested class must not have the name 'Foo'. Assuming we pick 'Foo$' as the replacement, the second nested class must not have names 'Foo' or 'Foo$'.</p> <p>At first glance this seems to be specifically triggered by enumerations.</p> <p>Solving this will be a bit of a ride, as we do not have the FQCN hierarchy captured anywhere – we use packageName to represent both the root module package and nested class's parent, hence crawling back is not a nice option, fraught with performance and correctness issues.</p> <p>Preliminary cut:</p> <p>remote:   <a href="https://git.opendaylight.org/gerrit/69407" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/69407</a> Add binding.model.api.TypeName<br/> remote:   <a href="https://git.opendaylight.org/gerrit/69408" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/69408</a> Integrate TypeName as Identifier</p> <p> </p> <p>This will be deeply invasive change, as it is forcing getting the packageName story in the codebase straight.</p> <p>The fix itself: <a href="https://git.opendaylight.org/gerrit/69599" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/69599</a></p> <p> </p> Blocks MDSAL-320 Development Rank 0|i03bkf: