https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-332 mdsal <p>As an example ietf-routing model (<a href="https://tools.ietf.org/html/rfc8349#page-16)" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc8349#page-16)</a> contains address-family as an Identity and also as grouping. This leads to two classes with the same name in one package to be generated. This then causes naming conflicts for these classes during build.</p> MDSAL-332

Class name conflict if identity and grouping share the same name in one package

Bug High Resolved Done Robert Varga Michal Cmarada Thu, 5 Apr 2018 08:49:10 +0000 Fri, 27 Jul 2018 10:59:41 +0000 Fri, 27 Jul 2018 10:59:41 +0000 Fluorine 0 4 <p>This should properly be supported by introducing identifier namespace in binding v2 as well as 'action' statement.</p> <p>Is it possible to fix it in binding v1?</p> <p>It may be possible, but that requires some analysis. What is the error reported in Fluorine?</p> <p>Michal: were you able to reproduce the issue using Fluorine?</p> <p>Using Fluorine the model builds, it just fails in Oxygen.</p> <p>I used these patches to test it:<br/> Oxygen: <a href="https://git.opendaylight.org/gerrit/#/c/72983/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72983/</a><br/> Fluorine: <a href="https://git.opendaylight.org/gerrit/#/c/72984/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72984/</a></p> <p>error output from build in attachement</p> <p>Right, but the fact it compiles is actually wrong, as we are ending up with overwritten files and completely wrong type hierarchy:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [WARNING] Naming conflict <span class="code-keyword">for</span> type <span class="code-quote">'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.test.module.rev180614.AddressFamily'</span>: file with same name already exists and will not be generated. </pre> </div></div> <p>So yes, this is fixable, but it requires rather extensive work:</p> <ul> <li>mdsal-binding-generator-impl needs to perform two-phase name assignment to detect the conflict</li> <li>a conflict-free naming scheme for use when a conflict occurs needs to be designed and implemented</li> </ul> <p>Conflicts will be resolved as follows:</p> <ul> <li>identities get a $I suffix</li> <li>groupings get a $G suffix</li> <li>typedefs get a $T suffix</li> </ul> <p>For now we will treat a conflict as an error path, recording what needs to be remapped and retrying the entire mapping attempt.</p> Relates MDSAL-350 Development Rank 0|i03crr: