https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-355 mdsal <p>Input parameter sequence of constructor of generated type or builder follows alphabetical and case-insensitive order, which differs with IdentifiableItemCodec expectation.</p> <p> </p> <p>IdentifiableItemCodec.java: </p> <p>(q1, q2) -&gt; q1.getLocalName().compareTo*IgnoreCase*(q2.getLocalName()</p> <p> </p> <p>ClassTempate.xtend:</p> <p>Collections.sort(sorted, [p1, p2|<br/> p1.name.compareTo(p2.name)<br/> ]);</p> <p> </p> <p>BuilderTemplate.xtend</p> <p>«Collections.sort(keyProps,<br/> [ p1, p2 |<br/> return p1.name.compareTo(p2.name)<br/> ])<br/> »</p> <p> </p> MDSAL-355

IdentifiableItemCodec should ignore case when sorting keys

Bug Medium Resolved Done Robert Varga Huafei Zhang Fri, 22 Jun 2018 02:31:11 +0000 Tue, 9 Oct 2018 15:37:31 +0000 Tue, 9 Oct 2018 15:37:31 +0000 Fluorine SR1 Oxygen SR4 3.0.1 Binding runtime 0 2 <p>Key properties names are not QName.localNames. Is there a testcase which does currently work?</p> <p>It's hard to provide an existing test case. We found this issue in our controller application. <br/> we have a list with a composite key</p> <p> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> list OspfStatLsdbBrief { key <span class="code-quote">"AreaIndex LsaType LsId AdvRtr"</span>; leaf AreaIndex { type int32; description <span class="code-quote">"Area Index"</span>; } leaf LsaType { type uint8; description <span class="code-quote">"LSA Type"</span>; } leaf LsId { type int32; description <span class="code-quote">"LSA ID"</span>; } leaf AdvRtr { type string; description <span class="code-quote">"Advertised Router"</span>; } } </pre> </div></div> <p>when decode a list entry accessing YangInstanceIdentifier by calling method "InstanceIdentifier&lt;?&gt; fromYangInstanceIdentifier(@Nonnull YangInstanceIdentifier dom)" of service</p> <blockquote><p>&lt;reference id="mappingCodec"<br/> interface="org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer"/&gt;</p></blockquote> <p>an java.lang.ClassCastException thrown:</p> <p>----------------------------------------------------------------------------------------------------------------------------------------------------------------</p> <blockquote><p>java.lang.ClassCastException: Cannot cast java.lang.Integer to java.lang.Short<br/> at java.lang.invoke.MethodHandleImpl.newClassCastException(MethodHandleImpl.java:361)<br/> at java.lang.invoke.MethodHandleImpl.castReference(MethodHandleImpl.java:356)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.deserialize(IdentifiableItemCodec.java:100)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.deserialize(IdentifiableItemCodec.java:30)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.KeyedListNodeCodecContext.getBindingPathArgument(KeyedListNodeCodecContext.java:73)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.BindingCodecContext.getCodecContextNode(BindingCodecContext.java:169)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.InstanceIdentifierCodec.deserialize(InstanceIdentifierCodec.java:36)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.InstanceIdentifierCodec.deserialize(InstanceIdentifierCodec.java:19)<br/> at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry.fromYangInstanceIdentifier(BindingNormalizedNodeCodecRegistry.java:92)<br/> at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.fromYangInstanceIdentifier(BindingToNormalizedNodeCodec.java:171)<br/> at Proxy995bc85b_803c_4f1a_9934_7430940d1b66.fromYangInstanceIdentifier(Unknown Source)<br/> at com.utstar.qx.sal.connect.qx.util.QxBaseOps.get(QxBaseOps.java:166)</p></blockquote> <p>---------------------------------------------------------------------------------------------------------------------------------------------------------</p> <p>This is because the constructor parameter from instance identifier is injected with wrong order.</p> <p>Fixing code of either xxtemplate.xtend or IdentifiableItemCodec will work.</p> <p>I see – the problem is that "LsId" and "LsaType" compare differently. This usually does not happen, as standard models usually end up using capitalization from the use of dashes, which is what the comparison was designed to overcome. Alas the shortcut does not work, as we really need to enlist binding-generator types and use them to establish the order arguments.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=zhfinder" class="user-hover" rel="zhfinder">zhfinder</a> does <a href="https://git.opendaylight.org/gerrit/76650" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/76650</a> fix the issue for you?</p> Development Rank 0|i03ftj: