https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-387 mdsal <p>I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, based on Oxygen SR3 code, and see extensive "TLAB Allocations" related to an excessive HashMap.resize() from IdentifiableItemCodec.serialize().</p> <p>Wondering if perhaps we could improve this by pre-allocating correctly sized Map?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">HashMap$Node[] java.util.HashMap.resize() 7552 <span class="code-object">Object</span> java.util.HashMap.putVal(<span class="code-object">int</span>, <span class="code-object">Object</span>, <span class="code-object">Object</span>, <span class="code-object">boolean</span>, <span class="code-object">boolean</span>) 7552 <span class="code-object">Object</span> java.util.HashMap.put(<span class="code-object">Object</span>, <span class="code-object">Object</span>) 7366 YangInstanceIdentifier$NodeIdentifierWithPredicates org.opendaylight.mdsal.binding.dom.codec.impl.IdentifiableItemCodec.serialize(InstanceIdentifier$IdentifiableItem) 2842 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.IdentifiableItemCodec.serialize(<span class="code-object">Object</span>) 2842 void org.opendaylight.mdsal.binding.dom.codec.impl.KeyedListNodeCodecContext.addYangPathArgument(InstanceIdentifier$PathArgument, List) 1699 DataContainerCodecContext org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.bindingPathArgumentChild(InstanceIdentifier$PathArgument, List) 1699 DataContainerCodecContext org.opendaylight.mdsal.binding.dom.codec.impl.BindingCodecContext.getCodecContextNode(InstanceIdentifier, List) 1699 Map$Entry org.opendaylight.mdsal.binding.dom.codec.impl.BindingCodecContext.newWriter(InstanceIdentifier, NormalizedNodeStreamWriter) 1692 Map$Entry org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNode(InstanceIdentifier, DataObject) 1692 Map$Entry org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(InstanceIdentifier, DataObject) 1692 void org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(LogicalDatastoreType, InstanceIdentifier, DataObject, <span class="code-object">boolean</span>) 1692 void org.opendaylight.openflowplugin.common.txchain.TransactionChainManager.writeToTransaction(LogicalDatastoreType, InstanceIdentifier, DataObject, <span class="code-object">boolean</span>) 1692 void org.opendaylight.openflowplugin.impl.device.DeviceContextImpl.writeToTransaction(LogicalDatastoreType, InstanceIdentifier, DataObject) 1692 <span class="code-object">Void</span> org.opendaylight.openflowplugin.impl.statistics.StatisticsGatheringUtils.lambda$deleteAllKnownFlows$6(InstanceIdentifier, TxFacade, Optional) 1145 <span class="code-object">Object</span> org.opendaylight.openflowplugin.impl.statistics.StatisticsGatheringUtils$$Lambda$1924.1642152062.apply(<span class="code-object">Object</span>) 1145 <span class="code-object">Object</span> com.google.common.util.concurrent.AbstractTransformFuture$TransformFuture.doTransform(Function, <span class="code-object">Object</span>) 1145 <span class="code-object">Object</span> com.google.common.util.concurrent.AbstractTransformFuture$TransformFuture.doTransform(<span class="code-object">Object</span>, <span class="code-object">Object</span>) 1145 void com.google.common.util.concurrent.AbstractTransformFuture.run() 1145 void com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(<span class="code-object">Runnable</span>) 1145 void com.google.common.util.concurrent.AbstractFuture.executeListener(<span class="code-object">Runnable</span>, Executor) 1145 void com.google.common.util.concurrent.AbstractFuture.addListener(<span class="code-object">Runnable</span>, Executor) 1145 void com.google.common.util.concurrent.AbstractFuture$TrustedFuture.addListener(<span class="code-object">Runnable</span>, Executor) 1145 ListenableFuture com.google.common.util.concurrent.AbstractTransformFuture.create(ListenableFuture, Function, Executor) 1145 ListenableFuture com.google.common.util.concurrent.Futures.transform(ListenableFuture, Function, Executor) 1145 void org.opendaylight.openflowplugin.impl.statistics.StatisticsGatheringUtils.deleteAllKnownFlows(TxFacade, InstanceIdentifier, DeviceFlowRegistry) 1145 void org.opendaylight.openflowplugin.impl.services.AbstractMultipartRequestOnTheFlyCallback.startCollecting() 1145 void org.opendaylight.openflowplugin.impl.services.AbstractMultipartRequestOnTheFlyCallback.onSuccess(OfHeader) 1145 void org.opendaylight.openflowplugin.impl.services.AbstractMultipartRequestOnTheFlyCallback.onSuccess(<span class="code-object">Object</span>) 1145 <span class="code-object">boolean</span> org.opendaylight.openflowjava.protocol.impl.core.connection.OutboundQueueEntry.complete(OfHeader) 1145 <span class="code-object">boolean</span> org.opendaylight.openflowjava.protocol.impl.core.connection.StackedSegment.completeEntry(OutboundQueueEntry, OfHeader) 1145 OutboundQueueEntry org.opendaylight.openflowjava.protocol.impl.core.connection.StackedSegment.pairRequest(OfHeader) 1145 <span class="code-object">boolean</span> org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractStackedOutboundQueue.pairRequest(OfHeader) 1145 <span class="code-object">boolean</span> org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.onMessage(OfHeader) 1145 void org.opendaylight.openflowjava.protocol.impl.core.connection.ConnectionAdapterImpl.consumeDeviceMessage(DataObject) 1145 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractConnectionAdapterStatistics.consume(DataObject) 1145 void org.opendaylight.openflowjava.protocol.impl.core.connection.ConnectionAdapterImpl.consume(DataObject) 1145 void org.opendaylight.openflowjava.protocol.impl.core.DelegatingInboundHandler.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145 ChannelHandlerContext io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145 ChannelHandlerContext io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.handler.codec.MessageToMessageDecoder.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145 ChannelHandlerContext io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ChannelHandlerContext, CodecOutputList, <span class="code-object">int</span>) 1145 void io.netty.handler.codec.ByteToMessageDecoder.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145 ChannelHandlerContext io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ChannelHandlerContext, CodecOutputList, <span class="code-object">int</span>) 1145 void io.netty.handler.codec.ByteToMessageDecoder.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145 ChannelHandlerContext io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.handler.timeout.IdleStateHandler.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void org.opendaylight.openflowjava.protocol.impl.core.IdleHandler.channelRead(ChannelHandlerContext, <span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(<span class="code-object">Object</span>) 1145 void io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext, <span class="code-object">Object</span>) 1145</pre> </div></div> MDSAL-387

Excessive HashMap.resize() from IdentifiableItemCodec.serialize()

Improvement Medium Resolved Done Robert Varga Michael Vorburger Tue, 13 Nov 2018 11:18:07 +0000 Mon, 3 Dec 2018 14:57:41 +0000 Mon, 3 Dec 2018 14:57:40 +0000 Oxygen SR3 Fluorine SR2 3.0.3 0 2 <p>There is something similar very here in another code path here as well:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>HashMap$Node[] java.util.HashMap.resize() 200 Object java.util.HashMap.putVal(int, Object, Object, boolean, boolean) 200 Object java.util.HashMap.put(Object, Object) 200 ModifiedNode org.opendaylight.yangtools.yang.data.impl.schema.tree.ModifiedNode.modifyChild(YangInstanceIdentifier$PathArgument, ModificationApplyOperation, Version) 81 OperationWithModification org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTreeModification.resolveModificationFor(YangInstanceIdentifier) 81 void org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTreeModification.write(YangInstanceIdentifier, NormalizedNode) 81 void org.opendaylight.controller.sal.core.spi.data.SnapshotBackedWriteTransaction.write(YangInstanceIdentifier, NormalizedNode) 81</pre> </div></div> <p>I do both cases are HashMap's lazy initialization to default size, in this case it's certainly okay.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a> seems to be making changes in this area, apparently in reaction to his -1 &amp; -2 on changes I proposed related to this which he didn't like, but has not tagged the respective changes with this JIRA... so just to clarify, may I ask, does that work address what was raised in this issue:</p> <ul> <li><a href="https://git.opendaylight.org/gerrit/#/c/78073/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/78073</a></li> <li><a href="https://jira.opendaylight.org/browse/YANGTOOLS-917" title="Allow OffsetMaps to be efficiently instantiated" class="issue-link" data-issue-key="YANGTOOLS-917"><del>YANGTOOLS-917</del></a> </li> </ul> <p>so should this be closed as Done? If so, for which ODL release? Post-Neon, Neon, Fluorine, Oxygen?</p> <p>Or is this still TBD by building on top of your recent work?</p> <p>Tx.</p> <p>Most of this was refactored as part of adoption of <a href="https://jira.opendaylight.org/browse/YANGTOOLS-917" title="Allow OffsetMaps to be efficiently instantiated" class="issue-link" data-issue-key="YANGTOOLS-917"><del>YANGTOOLS-917</del></a>, with the last bit being specialization of single-leaf keys.</p> Relates YANGTOOLS-917 Development Rank 0|i03kdz: