https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-388 mdsal <p>One of the very top "TLAB allocation" (cumulative nearing 100 GiB - that's a hell of a lot, no?) observed in a JFR from internal scale testing based on Oxygen SR3 code, which seems to contributed to excessive GC, is the code path below.</p> <p>I'm seeing this with slight variations, curiously always from openflowplugin (is it doing anything obviously wrong here, which could be improved?). Just wondering if there is any way that this could be optimized to cause less object allocation? Could that reflection stuff it seems to be doing here perhaps be cached?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">void java.lang.<span class="code-object">Class</span>$MethodArray.&lt;init&gt;(<span class="code-object">int</span>) 34969 Method java.lang.<span class="code-object">Class</span>.getMethod0(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>) 34969 Method java.lang.<span class="code-object">Class</span>.privateGetMethodRecursive(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>, <span class="code-object">Class</span>$MethodArray) 34237 Method java.lang.<span class="code-object">Class</span>.getMethod0(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>) 34237 Method java.lang.<span class="code-object">Class</span>.privateGetMethodRecursive(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>, <span class="code-object">Class</span>$MethodArray) 31798 Method java.lang.<span class="code-object">Class</span>.getMethod0(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>) 31798 Method java.lang.<span class="code-object">Class</span>.privateGetMethodRecursive(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>, <span class="code-object">Class</span>$MethodArray) 20695 Method java.lang.<span class="code-object">Class</span>.getMethod0(<span class="code-object">String</span>, <span class="code-object">Class</span>[], <span class="code-object">boolean</span>) 20695 Method java.lang.<span class="code-object">Class</span>.getMethod(<span class="code-object">String</span>, <span class="code-object">Class</span>[]) 11300 <span class="code-object">boolean</span> org.opendaylight.yangtools.yang.binding.util.BindingReflections.isSubstitutionFor(<span class="code-object">Class</span>, <span class="code-object">Class</span>) 11300 DataContainerCodecPrototype org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.augmentationByClassOrEquivalentClass(<span class="code-object">Class</span>) 11300 DataContainerCodecPrototype org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.augmentationByClass(<span class="code-object">Class</span>) 11300 DataContainerCodecPrototype org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.streamChildPrototype(<span class="code-object">Class</span>) 11300 Optional org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.possibleStreamChild(<span class="code-object">Class</span>) 11300 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.getAugmentationImpl(<span class="code-object">Class</span>) 11300 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.invoke(<span class="code-object">Object</span>, Method, <span class="code-object">Object</span>[]) 11300 Augmentation com.sun.proxy.$Proxy503.getAugmentation(<span class="code-object">Class</span>) 11071 Optional org.opendaylight.openflowplugin.extension.api.GroupingResolver.getExtension(Augmentable) 11071 MatchEntry org.opendaylight.openflowplugin.extension.vendor.nicira.convertor.match.RegConvertor.convert(Extension) 11071 DataContainer org.opendaylight.openflowplugin.extension.vendor.nicira.convertor.match.RegConvertor.convert(Extension) 11071 MatchEntry org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.lambda$<span class="code-keyword">null</span>$4(ExtensionList, ByteBuf, ConvertorToOFJava) 11071 <span class="code-object">Object</span> org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer$$Lambda$2185.946006913.apply(<span class="code-object">Object</span>) 11071 Optional java.util.Optional.map(Function) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.lambda$serializeExtensionList$6(ByteBuf, ExtensionList) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer$$Lambda$2182.730382268.accept(<span class="code-object">Object</span>) 11071 void java.util.ArrayList.forEach(Consumer) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.serializeExtensionList(List, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.lambda$serializeHeader$2(ByteBuf, List) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer$$Lambda$2069.1596170542.accept(<span class="code-object">Object</span>) 11071 void java.util.Optional.ifPresent(Consumer) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.serializeHeader(Match, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.serialize(Match, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.match.MatchSerializer.serialize(DataContainer, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.messages.FlowMessageSerializer.writeMatch(FlowMessage, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.messages.FlowMessageSerializer.writeFlow(FlowMessage, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.messages.FlowMessageSerializer.serialize(FlowMessage, ByteBuf) 11071 void org.opendaylight.openflowplugin.impl.protocol.serialization.messages.FlowMessageSerializer.serialize(DataContainer, ByteBuf) 11071 void org.opendaylight.openflowjava.protocol.impl.serialization.SerializationFactory.messageToBuffer(<span class="code-object">short</span>, ByteBuf, DataObject) 11071 void org.opendaylight.openflowjava.protocol.impl.core.OFEncoder.encode(ChannelHandlerContext, MessageListenerWrapper, ByteBuf) 11071 void org.opendaylight.openflowjava.protocol.impl.core.OFEncoder.encode(ChannelHandlerContext, <span class="code-object">Object</span>, ByteBuf) 11071 void io.netty.handler.codec.MessageToByteEncoder.write(ChannelHandlerContext, <span class="code-object">Object</span>, ChannelPromise) 11071 void io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(<span class="code-object">Object</span>, ChannelPromise) 11071 void io.netty.channel.AbstractChannelHandlerContext.invokeWrite(<span class="code-object">Object</span>, ChannelPromise) 11071 void io.netty.channel.AbstractChannelHandlerContext.write(<span class="code-object">Object</span>, <span class="code-object">boolean</span>, ChannelPromise) 11071 ChannelFuture io.netty.channel.AbstractChannelHandlerContext.write(<span class="code-object">Object</span>, ChannelPromise) 11071 ChannelFuture io.netty.channel.AbstractChannelHandlerContext.write(<span class="code-object">Object</span>) 11071 ChannelFuture io.netty.channel.DefaultChannelPipeline.write(<span class="code-object">Object</span>) 11071 ChannelFuture io.netty.channel.AbstractChannel.write(<span class="code-object">Object</span>) 11071 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.writeMessage(OfHeader, <span class="code-object">long</span>) 11071 void org.opendaylight.openflowjava.protocol.impl.core.connection.OutboundQueueManager.writeMessage(OfHeader, <span class="code-object">long</span>) 11071 <span class="code-object">int</span> org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractStackedOutboundQueue.writeEntries(Channel, <span class="code-object">long</span>) 11071 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.writeAndFlush() 11071 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.flush() 10043 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager.lambda$<span class="code-keyword">new</span>$0() 10043 void org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractOutboundQueueManager$$Lambda$1465.2105557852.run() 10043 void io.netty.util.concurrent.AbstractEventExecutor.safeExecute(<span class="code-object">Runnable</span>) 10043 <span class="code-object">boolean</span> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasksFrom(Queue) 10043 <span class="code-object">boolean</span> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks() 10043 void io.netty.channel.nio.NioEventLoop.run() 10043 void io.netty.util.concurrent.SingleThreadEventExecutor$5.run() 10043 void io.netty.util.concurrent.FastThreadLocalRunnable.run() 10043 void java.lang.<span class="code-object">Thread</span>.run() 10043</pre> </div></div> MDSAL-388

Cache successful augmentation substitutions

Improvement Medium Resolved Done Robert Varga Michael Vorburger Tue, 13 Nov 2018 13:26:02 +0000 Wed, 26 Feb 2020 15:29:03 +0000 Mon, 19 Nov 2018 12:55:00 +0000 Fluorine SR2 Oxygen SR4 3.0.2 0 2 <p>GroupingResolver is doing something funky, I am not quite sure what and why – that is leading DataObjectCodecContext off of the fast path.</p> <p>Reminder: Need to double check how <a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-1050" title="Make Grouping{Loose}Resolver immutatable" class="issue-link" data-issue-key="OPNFLWPLUG-1050"><del>OPNFLWPLUG-1050</del></a> related to this ...</p> <p>Aside from me looking at GroupingResolver and screaming in anguish over public mutable collections.</p> <p> </p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=vorburger" class="user-hover" rel="vorburger">vorburger</a> if you are looking to improve things further, I would suggest looking at the reported stack trace and cleaning up OFP's use of capturing lambdas (like MatchSerializer.serializeHeader()'s use of Map.forEach()) and this wonderful pattern:</p> <p> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Foo nullableFoo; <span class="code-comment">// I can haz two <span class="code-keyword">new</span> objucts? coz is l33ter than <span class="code-quote">'<span class="code-keyword">if</span> (nullableFoo != <span class="code-keyword">null</span>)'</span>! </span>Optional.ofNullable(nullableFoo).ifPresent(nonnullFoo -&gt; { <span class="code-comment">// Moar codez goes here... </span>})</pre> </div></div> <p> </p> <p>OMG <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/tongue.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Duplicate MDSAL-59 Relates OPNFLWPLUG-1050 Development Rank 0|i03kfj: