OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [MDSAL-41] Provide support for custom Commit Cohorts https://jira.opendaylight.org/browse/MDSAL-41 mdsal <p><a href="https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:EverythingYouWantedtoKNowaboutOnDataChanged_butWasAfraidToAsk#Data_Commit_Handler_Issues" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:EverythingYouWantedtoKNowaboutOnDataChanged_butWasAfraidToAsk#Data_Commit_Handler_Issues</a></p> <p>I looked at 1209 and if new API provides fixes problems, please point to concrete example on how to overcome problems described in wiki.</p> <p>Operating System: All<br/> Platform: PC</p> MDSAL-41 Provide support for custom Commit Cohorts Bug Resolved Done Tony Tkacik Reinaldo Penno Sun, 27 Jul 2014 18:50:53 +0000 Fri, 9 Mar 2018 18:00:04 +0000 Fri, 10 Feb 2017 20:22:53 +0000 0 9 <p>Please</p> <p>(In reply to Tony Tkacik from comment #1)<br/> &gt; Please</p> <p>Accidentally submitted unfinished answer,</p> <p>Please could you insert body from wiki here, to track it in one place<br/> outside of wiki (since wiki is free for all).</p> <p>1- Commit Handler is called for every commit independent of attachment point. If I attach a Commit Handler to a Yang List in a specific model, I expect it to be called only for transaction at that level or lower, but it is called for every controller config transaction.<br/> 2 - Even though I return a failed transaction from callback handler, data is still pushed to the datastore. Basically a RESTconf PUT request triggers the callback which returns "RpcResultBuilder.&lt;Void&gt; failed().build()" (I also tried returning null), but data is not rolled back. This does not agree with documentation and defeats the core value of this construct.</p> <p><a href="https://jenkins.opendaylight.org/controller/job/controller-merge/lastSuccessfulBuild/artifact/target/apidocs/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.html" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/controller/job/controller-merge/lastSuccessfulBuild/artifact/target/apidocs/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.html</a></p> <p>"If error occured, the broker starts a commit rollback phase. "</p> <p>If I change the code below to honor a failed RpcResult from Provider, the transaction still goes through. It seems there is no stopping RESTconf from failing a transaction</p> <p> return Futures.transform(dataStoreCommit, new Function&lt;RpcResult&lt;TransactionStatus&gt;,RpcResult&lt;TransactionStatus&gt;&gt;() {<br/> @Override<br/> public RpcResult&lt;TransactionStatus&gt; apply(final RpcResult&lt;TransactionStatus&gt; input) {<br/> if(input.isSuccessful()) {<br/> for(DataCommitTransaction&lt;InstanceIdentifier&lt;? extends DataObject&gt;, DataObject&gt; subTx : subTrans ) {<br/> if (!subTx.finish().isSuccessful()) { //&lt;=== Changed Code<br/> LOG.error("Provider {} commit failed.", subTx.toString());<br/> RpcResult&lt;TransactionStatus&gt; rpcResult = RpcResultBuilder.&lt;TransactionStatus&gt;failed().build();<br/> return rpcResult;<br/> }<br/> }<br/> } else {<br/> LOG.error("Tx: {} Rollback - Datastore commit failed.",tx.getIdentifier());<br/> for(DataCommitTransaction&lt;InstanceIdentifier&lt;? extends DataObject&gt;, DataObject&gt; subTx : subTrans ) </p> { subTx.rollback(); } <p> }<br/> return input;<br/> }<br/> });</p> <p>It also important to point out that when I changed the code as above to honor the return value from provider, the initial controller configuration did not not go through as many errors were displayed. . In other words, it seems people have been relying on this bug.</p> <p>What's the progress on this one? Without this working I can not sanitize RESTconf operations</p> <p>This requires API enhancement for new DataBroker described in <a href="https://jira.opendaylight.org/browse/CONTROLLER-662" title="Datastore: expose AsyncConfigurationCommitCohort into DataBroker" class="issue-link" data-issue-key="CONTROLLER-662"><del>CONTROLLER-662</del></a> which will introduce new API AsyncConfigutationCommitCohort with better semantics then original deprecated DataCommitHandler.</p> <p>Requirements:</p> <ul class="alternate" type="square"> <li>I would like to attach a CommitHandler much like a data listener (to a specific leaf , subtree, etc). This is because certain portions of the tree will have different business logic associated with them. Some I will have to contact another external server, some will be just a matter of validating some of the input.</li> <li>I would like to define the error code and reason phrase RESTconf will send back. I do not want all errors to be 401. Based on the business logic output I will decide on the appropriate error. Of course if no error is passed from ODL Provider, infrastructure can return a default error</li> </ul> <ul class="alternate" type="square"> <li>Following up on above, I would like to be able to return 3XX code with appropriate payload. The reasons are many: Load-balancing, redirection to appropriate ODL or server instance that should handle resource, etc. This has been a long requirement since it is heavily used by business apps. This could be done with a Yang metadata data. A metadata-tag that we can change run-time with the URI to be used for redirection.</li> </ul> <p>move to Lithium</p> <p>Any update? I would like to incorporate the new API into SFC with plenty of time to test, give feedback, fix bugs, stabilize.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/14332/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/14332/</a></p> <p>Any update? Code review seems stuck and did not receive any updates either.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/17532/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17532/1</a> - Binding to DOM part</p> <p>DOM to Data Store part is yet pending.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/32602/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/32602/</a></p> <p>adding some keywords to make searching easier:<br/> validation data validate cohort cohorts</p> Blocks CONTROLLER-1233 Duplicate CONTROLLER-662 Development External issue ID 1435 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02vy7: