https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-505 mdsal <p>Current detection of circular leafref chains relies on parsing the expression multiple times and attempting to detect when we arrive at the same leafref.</p> <p>We should be able to improve this by tracking which leafref leaf nodes we have traversed, using a simple Collection.contains() to check we re-encountering a leafref.</p> MDSAL-505

Improve leafref cycle detection

Improvement Medium In Review Unresolved Samuel Schneider Robert Varga Mon, 23 Dec 2019 17:31:08 +0000 Fri, 19 Jan 2024 14:53:35 +0000 13.0.1 Binding codegen 0 2 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a><br/> I was looking in to this and I couldn't find any circular leafref chains detection. Only check for self-referencing leaf.<br/> Is something like this meant to be circular leafref chain?:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> list neighbor { description <span class="code-quote">"List of neighbors."</span>; leaf neighbor-id1 { type leafref { path <span class="code-quote">"../../neighbor/neighbor-id2"</span>; } description <span class="code-quote">"Neighbor."</span>; } leaf neighbor-id2 { type leafref { path <span class="code-quote">"../../neighbor/neighbor-id3"</span>; } description <span class="code-quote">"Neighbor."</span>; } leaf neighbor-id3 { type leafref { path <span class="code-quote">"../../neighbor/neighbor-id1"</span>; } description <span class="code-quote">"Neighbor."</span>; } } </pre> </div></div> <p>if so, attempt to generate from yang like this results in StackOverflowError.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Caused by: java.lang.StackOverflowError at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.AbstractTypeObjectGenerator.methodReturnElementType(AbstractTypeObjectGenerator.java) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.TypeReference$ResolvedLeafref.methodReturnType(TypeReference.java:61) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.AbstractTypeObjectGenerator.createMethodReturnElementType(AbstractTypeObjectGenerator.java:499) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.AbstractTypeObjectGenerator.methodReturnElementType(AbstractTypeObjectGenerator.java:485) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.TypeReference$ResolvedLeafref.methodReturnType(TypeReference.java:61) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.AbstractTypeObjectGenerator.createMethodReturnElementType(AbstractTypeObjectGenerator.java:499) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.AbstractTypeObjectGenerator.methodReturnElementType(AbstractTypeObjectGenerator.java:485) at org.opendaylight.mdsal.binding.generator@12.0.0-SNAPSHOT/org.opendaylight.mdsal.binding.generator.impl.reactor.TypeReference$ResolvedLeafref.methodReturnType(TypeReference.java:61) </pre> </div></div> Development Rank 0|i03qif: