https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-512 mdsal <p>When Controller peers with a router that is advertising vpnv6 route with ipv4 next-hop address, below exception is seen during session establishment. Issue is seen in all releases Fluorine and beyond.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>2020-01-02T11:47:30,092 | ERROR | opendaylight-cluster-data-notification-dispatcher-56 | DataTreeChangeListenerActor | 274 - org.opendaylight.controller.sal-clustering-commons - 1.8.1 | member-1-shard-default-operational: Error notifying listener org.opendaylight.controller.sal.core.compat.LegacyDOMDataBrokerAdapter$2$$Lambda$968/1234951622@264c7425 java.lang.IllegalArgumentException: Supplied value "10.176.0.235" does not match required pattern "((:|[0-9a-fA-F]{0,4}):)([0-9a-fA-F]{0,4}:){0,5}((([0-9a-fA-F]{0,4}:)?(:|[0-9a-fA-F]{0,4}))|(((25[0-5]|2[0-4][0-9]|[01]?[0-9]?[0-9])\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9]?[0-9])))(%[\p{N}\p{L}]+)?" at org.opendaylight.yangtools.yang.binding.CodeHelpers.checkPattern(CodeHelpers.java:130) ~[336:org.opendaylight.mdsal.yang-binding:0.13.1] at org.opendaylight.yangtools.yang.binding.CodeHelpers.checkPattern(CodeHelpers.java:149) ~[336:org.opendaylight.mdsal.yang-binding:0.13.1] at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv6Address.&lt;init&gt;(Ipv6Address.java:31) ~[322:org.opendaylight.mdsal.model.ietf-inet-types-2013-07-15:1.5.1] at org.opendaylight.mdsal.binding.dom.codec.impl.EncapsulatedValueCodec.deserialize(EncapsulatedValueCodec.java:73) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:196) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:370) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:152) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.invoke(LazyDataObject.java:75) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at com.sun.proxy.$Proxy360.getGlobal(Unknown Source) ~[203:org.opendaylight.bgpcep.bgp-concepts:0.10.1] at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev180329.next.hop.c.next.hop.ipv6.next.hop._case.Ipv6NextHop$StreamWriter.serialize(DataObjectSerializerPrototype.java) ~[203:org.opendaylight.bgpcep.bgp-concepts:0.10.1] at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev180329.next.hop.c.next.hop.Ipv6NextHopCase$StreamWriter.serialize(DataObjectSerializerPrototype.java) ~[203:org.opendaylight.bgpcep.bgp-concepts:0.10.1] at org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:351) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.util.ChoiceDispatchSerializer.serialize(ChoiceDispatchSerializer.java:46) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev180329.path.attributes.Attributes$StreamWriter.serialize(DataObjectSerializerPrototype.java) ~[217:org.opendaylight.bgpcep.bgp-parser-api:0.10.1] at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.vpn.rev180329.l3vpn.ip.route.VpnRoute$StreamWriter.serialize(DataObjectSerializerPrototype.java) ~[207:org.opendaylight.bgpcep.bgp-l3vpn:0.10.1] at org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:351) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNode(BindingNormalizedNodeCodecRegistry.java:117) ~[301:org.opendaylight.mdsal.binding-dom-codec:0.13.1] at org.opendaylight.mdsal.binding.dom.adapter.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:162) ~[300:org.opendaylight.mdsal.binding-dom-adapter:2.5.1] at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:37) ~[269:org.opendaylight.controller.sal-binding-broker-impl:1.8.1] at org.opendaylight.controller.md.sal.binding.impl.BindingDOMWriteTransactionAdapter.put(BindingDOMWriteTransactionAdapter.java:34) ~[269:org.opendaylight.controller.sal-binding-broker-impl:1.8.1] at org.opendaylight.protocol.bgp.rib.impl.EffectiveRibInWriter.writeRoutes(EffectiveRibInWriter.java:277) ~[223:org.opendaylig</pre> </div></div> MDSAL-512

Exception encountered while processing vpnv6 route

Bug High Resolved Done Ajay Lele Ajay Lele Mon, 6 Jan 2020 18:37:26 +0000 Tue, 7 Jan 2020 12:43:31 +0000 Tue, 7 Jan 2020 12:43:31 +0000 Fluorine SR3 4.0.8 5.0.6 3.0.14 6.0.0 4.0.9 5.0.7 3.0.15 models 0 1 <ul> <li>For IPv6 address-family, when next-hop address is an IPv4 address, it is encoded as IPv4-mapped IPv6 address as defined in <a href="https://tools.ietf.org/html/rfc4659#section-3.2.1.2" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc4659#section-3.2.1.2</a>. So this is how the route will be received from the router.</li> <li>Now even in case of oxygen and prior where this exception was not seen, contents of operational RIB for such a route showed ipv6-next-hop with an IPv4 address value. This itself does not seem right</li> </ul> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> "attributes": { "as-path": {}, "ipv6-next-hop": { "global": "10.176.0.235" },</pre> </div></div> <ul> <li>What seems to be happening is that the code used to convert received byte array to IPv6 address uses <a href="https://docs.oracle.com/javase/7/docs/api/java/net/Inet6Address.html" class="external-link" target="_blank" rel="nofollow noopener">https://docs.oracle.com/javase/7/docs/api/java/net/Inet6Address.html</a> and as mentioned in its "Special IPv6 address section", it automatically converts IPv4-mapped IPv6 address into an IPv4 address</li> <li>So the resultant Ipv6Address ends up having an IPv4 address in it (the validation is skipped during creation - refer to discussion in <a href="https://bugs.opendaylight.org/show_bug.cgi?id=2825" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=2825</a>, <a href="https://wiki.opendaylight.org/view/String_data_normalization_and_alternative_storage" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/String_data_normalization_and_alternative_storage</a>, <a href="https://git.opendaylight.org/gerrit/c/mdsal/+/34869" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/mdsal/+/34869</a>)</li> <li>Proposed fix is to change this logic such that an IPv4-mapped IPv6 address will get parsed into an IPv6 address. With this change, the operational RIB will show the corresponding IPv6 address in ipv6-next-hop field</li> </ul> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> "attributes": { "as-path": {}, "ipv6-next-hop": { "global": "::ffff:ab0:eb" },</pre> </div></div> Development Rank 0|i03qlj: