https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-517 mdsal <p> </p> <p>The following two models:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>module a { yang-version 1.1; namespace "a"; prefix a; grouping a-grp { action a-act { input { leaf a-action-input-leaf { type empty; } } } } container a-cont { uses a:a-grp; } } module b { yang-version 1.1; namespace "b"; prefix b; import a { prefix a; } augment "/a:a-cont/a:a-act/a:input" { description "An augmentation of a action input of module a"; leaf b-aug-leaf { type empty; } } }</pre> </div></div> <p>result in AbstractTypeGenerator.augmentationToGenTypes() failing:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ERROR] yang-to-sources: Unable to generate sources with org.opendaylight.mdsal.binding.maven.api.gen.plugin.CodeGeneratorImpl generator java.lang.NullPointerException: Target type not yet generated: InputEffectiveStatementImpl{path=AbsoluteSchemaPath{path=[(a)a-cont, (a)a-act, (a)input]}} at org.opendaylight.mdsal.binding.generator.impl.AbstractTypeGenerator.augmentationToGenTypes (AbstractTypeGenerator.java:796) at org.opendaylight.mdsal.binding.generator.impl.AbstractTypeGenerator.allAugmentsToGenTypes (AbstractTypeGenerator.java:375) at java.util.ArrayList.forEach (ArrayList.java:1257) at org.opendaylight.mdsal.binding.generator.impl.AbstractTypeGenerator.&lt;init&gt; (AbstractTypeGenerator.java:203) at org.opendaylight.mdsal.binding.generator.impl.CodegenTypeGenerator.&lt;init&gt; (CodegenTypeGenerator.java:32) at org.opendaylight.mdsal.binding.generator.impl.BindingGeneratorImpl.generateTypes (BindingGeneratorImpl.java:64) at org.opendaylight.mdsal.binding.maven.api.gen.plugin.CodeGeneratorImpl.generateSources (CodeGeneratorImpl.java:70) at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.generateSourcesWithOneGenerator (YangToSourcesProcessor.java:383) at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.generateSources (YangToSourcesProcessor.java:332) at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.conditionalExecute (YangToSourcesProcessor.java:159) at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesMojo.execute (YangToSourcesMojo.java:127)</pre> </div></div> <p> </p> MDSAL-517

Target type not yet generated with augmenting action inputs

Bug Medium Resolved Done Robert Varga Miroslav Kovac Thu, 27 Feb 2020 16:27:30 +0000 Sat, 29 Feb 2020 09:11:51 +0000 Sat, 29 Feb 2020 09:11:51 +0000 6.0.0 5.0.10 4.0.12 Binding codegen 0 2 <p>if the action in the grouping of the module a would be enhanced with container inside of the input and the augmation of the module b would have path to that container this would generate everything just fine</p> <p>The problem is that findChildNodeByPath() is not equipped to handle action's mode of generation – the action itself is generated at its instantiation, but its input/output structures are generated at its original definition. Hence in this example (a = foo, b=bar for clarity) it looks for:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>AbsoluteSchemaPath{path=[(foo)foo-cont, (foo)foo-act, (foo)input]}</pre> </div></div> <p>whereas the correct type should be</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>AbsoluteSchemaPath{path=[(foo)foo-grp, (foo)foo-act, (foo)input]}</pre> </div></div> <p>as present in the lookup. There is no way findChildNodeByPath() can now this trick, nor does augmentationToGenTypes() know enough (all it has is SchemaNodeIdentifier).</p> <p>Perhaps actionsToGenType() should register the paths it is reusing as proxies? Note these proxies need to be ignored for purposes of 'what Types do we need to generate'.</p> <p>While the case provided here is fixed, there is another problem, which is the following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>module baz { yang-version 1.1; namespace "baz"; prefix baz; import foo { prefix foo; } container baz-cont { uses foo:foo-grp { augment foo-act/input { leaf baz-aug-leaf { type string; } } } } } </pre> </div></div> Development Rank 0|i03r7z: