[MDSAL-544] DOMNotificationRouter does not guard against Exception being thrown

Tue, 28 Apr 2020 14:40:49 +0000

2020-01-20T12:11:30,739
 | ERROR | DOMNotificationRouter-disruptor-0 | 
FatalExceptionHandler            | 109 - com.lmax.disruptor - 3.4.2 | 
Exception processing: 17740 org.opendaylight.mdsal.dom.broker.DOMNotificationRouterEvent@5636abf1
java.lang.NullPointerException: null
                at c.a.e.c.o.s.CtlrEventTaskExecutor.processNetconfEvent(CtlrEventTaskExecutor.java:362) ~[?:?]
                at c.a.e.c.o.s.CtlrEventTaskExecutor.execute(CtlrEventTaskExecutor.java:212) ~[?:?]
                at c.a.e.c.o.s.CtlrEventsListenerImpl.onEvent(CtlrEventsListenerImpl.java:47) ~[?:?]
                at 
org.opendaylight.mdsal.binding.dom.adapter.invoke.NotificationListenerInvoker.invokeNotification(NotificationListenerInvoker.java:111)
 ~[?:?]
                at 
org.opendaylight.mdsal.binding.dom.adapter.BindingDOMNotificationListenerAdapter.onNotification(BindingDOMNotificationListenerAdapter.java:44)
 ~[?:?]
                at 
org.opendaylight.mdsal.dom.broker.DOMNotificationRouterEvent.deliverNotification(DOMNotificationRouterEvent.java:48)
 ~[?:?]
                at 
org.opendaylight.mdsal.dom.broker.DOMNotificationRouter.lambda$static$24(DOMNotificationRouter.java:75)
 ~[?:?]
                at 
com.lmax.disruptor.BatchEventProcessor.processEvents(BatchEventProcessor.java:168)
 [109:com.lmax.disruptor:3.4.2]
                at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:125) [109:com.lmax.disruptor:3.4.2]

this ends up killing the thread – which should have caused the entire platform to die, but I guess the environment is not set up for that.

We can lower this to a warning and continue processing.

OpenDaylight JIRA

[MDSAL-544] DOMNotificationRouter does not guard against Exception being thrown