[MDSAL-553] Add BindingMap to help with interfacing with keyed lists (Maps)

Wed, 30 Sep 2020 00:10:03 +0000

Current Builders allow setting properties only as an entire field. This is ends up being clunky, as we really want them to be built in a fluent way.

This is especially problematic with Map-based properties, as populating the map requires the product to be present to extract the key:

Map<Bar> bars = ...;
Bar tmp = new BarBuilder().setName("one").build();
bars.put(tmp.key(), tmp);
tmp = new BarBuilder().setName("two").build();
bars.put(tmp.key(), tmp);
Foo foo = new FooBuilder().setBar(bars).build();

with the empty/null equivalence, we can improve this to something like:

Foo foo = new FooBuilder()
    .addBar(new BarBuilder().setName("one").build())
    .addBar(new BarBuilder().setName("two").build())
    .build();

Since these methods are shifting backing structure maintenance to the builder, we also need to ensure proper encapsulation of copy mechanics.

OpenDaylight JIRA

[MDSAL-553] Add BindingMap to help with interfacing with keyed lists (Maps)