https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-598 mdsal <p>Controller's blueprint component has "clustered-app-config" stanza, which allows injection of root component from the configuration datastore into projects.</p> <p>This also supports inline value definition via CDATA, which is interpreted as an XML fragment, or an explicit XML file to be loaded up if the data does not exist in the datastore. See org.opendaylight.controller.blueprint.ext.DataStoreAppConfigMetadata for the gory details.</p> <p>Since we are moving away from Blueprint, we need a replacement component, one which will hopefully play nicely with OSGi DS.</p> <p> </p> MDSAL-598

Add support for datastore configuration OSGi DS injection

New Feature Low Confirmed Unresolved Unassigned Robert Varga Fri, 16 Oct 2020 17:39:52 +0000 Fri, 16 Oct 2020 19:56:19 +0000 0 1 <p>Most components should be fine with just injecting the appropriate interface, as that way they are in charge of how the change is propagated – i.e. via normal service bind/unbind. There are a few components, which ignore updates – which is really not what should be done and therefore we will ignore them for now.</p> <p>Hence the basic mode of operation should be something like this:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> @Component <span class="code-keyword">public</span> <span class="code-keyword">final</span> SomeComponent <span class="code-keyword">implements</span> ComponentService { @Reference ComponentDataObject config; } </pre> </div></div> <p>which will bind ComponentDataObject as a service in OSGi DS. Now we are faced with a slight problem: there is no provider for that service, as it is usually no provider. For that part we need to provide some amount of substrate, so that applications can easily create their component to provide the service, something like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> @Component <span class="code-comment">// Well, a bit more complicated, as it ends up being a factory component </span><span class="code-keyword">public</span> <span class="code-keyword">final</span> OSGiComponentDataObject <span class="code-keyword">extends</span> AbstractDatastoreConfiguration&lt;ComponentDataObject&gt; <span class="code-keyword">implements</span> ComponentDataObject { @Reference void bindDataBroker(DataBroker dataBroker) { <span class="code-keyword">super</span>.setDataBroker(dataBroker); } @Activate void activate() { <span class="code-keyword">super</span>.start(); } @Deactivate void deactivate() { <span class="code-keyword">super</span>.stop(); } } </pre> </div></div> <p> </p> <p>Once we have that working and have unblocked migration, we should take it a bit further and do:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> @Component <span class="code-keyword">public</span> <span class="code-keyword">final</span> SomeComponent <span class="code-keyword">implements</span> ComponentService { @Reference @DatastoreConfiguration ComponentDataObject config; } </pre> </div></div> <p>i.e. define our specific annotation, and create an annotation processor which will generate OSGiComponentDataObject into the current project.</p> <p>Based on a prototype in AAA's password service, this is probably going to be quite involved. See <a href="https://git.opendaylight.org/gerrit/c/aaa/+/93104" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/aaa/+/93104</a> .</p> <p>The problem is that it is quite a bit of code, which has a dependency on mdsal-binding-api, there is an unneeded proxy, etc.</p> <p>There is also the tiny issue of the bundle having a Require-Capability for a the config being exposed as a service – and that gets checked statically before the bundle is ever installed. We essentially would need to insert a runtime component which will provide the binding (very much like BluePrint extension, except at feature:install time!)</p> <p>This might not be feasible <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Development Rank 0|i03van: