https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-713 mdsal <p>CopyableNode is on its way out, yet we are using it in a few places related to codegen and binding runtime.</p> <p>Audit the users and replace use of this method with something reasonable.</p> MDSAL-713

Do not use CopyableNode.isAugmenting()

Task Medium In Review Unresolved Samuel Schneider Robert Varga Wed, 8 Dec 2021 12:46:33 +0000 Thu, 7 Sep 2023 11:59:56 +0000 Binding codegen Binding runtime 0 2 <p><b>choice</b> statements:</p> <ul> <li>when augmenting choice with extra <b>case</b>s there seems to be faulty behavior when using <em>shorthand case</em> (<a href="https://datatracker.ietf.org/doc/html/rfc7950#section-7.9.2" class="external-link" target="_blank" rel="nofollow noopener">https://datatracker.ietf.org/doc/html/rfc7950#section-7.9.2</a>)</li> <li>example with yang files:</li> </ul> <p>##1. <b>case.yang</b></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-json"> ... container locks { choice lock-type { <span class="code-keyword">case</span> partial-lock { list partial-lock { key lock-id; leaf lock-id { type uint32; } leaf-list select { type string; min-elements 1; } leaf-list locked-node { type string; } } } } } ... </pre> </div></div> <p>##2. <b>augment-case.yang</b></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-json"> ... <span class="code-keyword">import</span> <span class="code-keyword">case</span> { prefix cc; } augment <span class="code-quote">"cc:locks/cc:lock-type"</span> { <span class="code-keyword">case</span> autonomous-lock { container autonomous-def { leaf lock-id { type int32; } leaf lock-time { type uint32; } } } <span class="code-keyword">case</span> anonymous-lock { leaf lock-time { type uint32; } } leaf leaf-aug-<span class="code-keyword">case</span> { type string; } } ... </pre> </div></div> <p>The <em>EffectiveStatement</em> s in the <b>case</b> module, that were introduced via augmentation in the <b>augment-case</b> module are being reported as <b>isAugmenting() == true</b> (expected behaviour). Also, the leafs that are within those <em>case</em> statements are <b>isAugmenting() == true</b>, except for one. Although the <em>shorthand case</em> (not explicitly written in the yang file) is <b>isAugmenting() == true</b>, its child (leaf: <em>leaf-aug-case</em>) reports <b>isAugmenting() == false</b></p> <p>Seems legit, can you create a minimal reproducer unit test in yangtools' yang-parser-rfc7950, please?</p> <p>Test, reproducing this behavior, created and available here: <a href="https://git.opendaylight.org/gerrit/c/yangtools/+/106388" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/yangtools/+/106388</a></p> Development Epic Link YANGTOOLS-1348 Rank 0|i0410v: