https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-73 mdsal <p>As per <a href="http://openjdk.java.net/jeps/213" class="external-link" target="_blank" rel="nofollow noopener">http://openjdk.java.net/jeps/213</a>, using an underscore will become a hard error in JDK9. Update the binding specification to deal with this before the world breaks for us.</p> <p>Operating System: All<br/> Platform: All</p> MDSAL-73

Java Bindings: do not generate underscores in identifiers

Improvement Resolved Done Jakub Toth Robert Varga Thu, 5 Mar 2015 18:17:53 +0000 Fri, 9 Mar 2018 18:00:06 +0000 Fri, 10 Mar 2017 11:56:47 +0000 0 4 <p>&gt; In addition, using underscore ("_") as an identifier, which generates a warning as of Java SE 8, should be turned into an error in Java SE 9.</p> <p>&gt; Complete the removal, begun in Java SE 8, of underscore from the set of legal identifier names.</p> <p>Current bug summary mentions "underscores in identifiers", which is way more general than "underscores as identifiers".</p> <p>Typo on my part. The headline is correct.</p> <p>Link to the Java 9 technical task: <a href="https://bugs.openjdk.java.net/browse/JDK-8061549" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.openjdk.java.net/browse/JDK-8061549</a></p> <p>just to confirm, underscores are allowed in constant names and enum values in generated Java code</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/51132/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/51132/</a></p> <p>&gt; <a href="https://git.opendaylight.org/gerrit/#/c/51132/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/51132/</a></p> <p>That fixes enums, but I do not think it fixes other identifies, such as leaf names. At least there are no unit tests for non-enum namespaces.</p> <p>Right, but given merged utility</p> <p>NonJavaCharsConverter.java:</p> <p>public static String convertIdentifier(final String identifier, final JavaIdentifier javaIdentifier)</p> <p>does the rest of the job.</p> <p>TODO: Jakub, please add more JUnit tests dealing with non enum inputs.</p> Blocks MDSAL-40 Development External issue ID 2791 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02w5b: