https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/MDSAL-746 mdsal <p>Separate from <a href="https://jira.opendaylight.org/browse/MDSAL-743" title="Add BitsTypeObject" class="issue-link" data-issue-key="MDSAL-743"><del>MDSAL-743</del></a>, which defines the headline term, let's improve how we storage the individual bits. With <a href="https://jira.opendaylight.org/browse/MDSAL-744" title="Map bits type to primitive boolean" class="issue-link" data-issue-key="MDSAL-744"><del>MDSAL-744</del></a> we promise to provide a boolean value. Most of the bits we encounter have a very limited number of possible bits, let's say there are three classes:</p> <ul> <li>up to 32 bits, which should use an 'int' for storage</li> <li>up to 64 bits, which should use a 'long' for storage</li> <li>more than 64 bits, which should use an int[] for storage]</li> </ul> <p>Specialize codegen to recognize these three classes and store the set bits in the appropriate storage class, providing the required methods on bit operations. This will drop storage requirements (when compared to <a href="https://jira.opendaylight.org/browse/MDSAL-743" title="Add BitsTypeObject" class="issue-link" data-issue-key="MDSAL-743"><del>MDSAL-743</del></a>) by additional factor of 8, providing a 32x/64x improvement when compared to current Boolean storage.</p> MDSAL-746

Improve BitsTypeObject storage

Improvement Medium Confirmed Unresolved Unassigned Robert Varga pt Mon, 11 Apr 2022 20:22:17 +0000 Tue, 9 Jan 2024 13:05:32 +0000 14.0.0 Binding codegen 0 1 <p><a href="https://jira.opendaylight.org/browse/YANGTOOLS-1426" title="Consider bits type storage" class="issue-link" data-issue-key="YANGTOOLS-1426">YANGTOOLS-1426</a> proposes to make similar improvements on yang.data.api level. While mdsal is free to its own thing (because "codegen"!) it would be nice if we could share some of the solution space.</p> <p>So we are in a bit of a pickle w.r.t. serialization, I think.</p> <p>serialVersionUID is based on properties, but it really needs to reflect resulting class layout as well to be really accurate.</p> <p>The problem is that the current patch does <b>not</b> change serial version, even when fields change from individual booleans to ints/whatever.</p> <p>I am not sure what to about this: I think serialVersionUID needs to capture both the properties and the resulting layout (hence mdsal-binding-generator needs to know about these).</p> <p>Lets punt this for the next release.</p> <p>I think we should do this only after <a href="https://jira.opendaylight.org/browse/MDSAL-764" title="Refactor binding-model-api" class="issue-link" data-issue-key="MDSAL-764">MDSAL-764</a>, which will give us a proper structure for what kinds of things we want to generate. Once we have that, we will have a BitsTypeObjectArchetype, which can capture the layout vs. properties difference, thus communicating clearly what needs to be generated and how.</p> <p>On java-api-generator side this also implies creating a BitsTypeObjectTemplate and pulling bits-related special-cases there.</p> Blocks MDSAL-744 MDSAL-764 Relates YANGTOOLS-1426 Development Epic Link MDSAL-742 Rank 0|i0423r: