[MDSAL-797] Union's stringValue() does not handle BitsTypeObject

Relates — Thu, 8 Dec 2022 21:55:42 +0000

Detected in downstream integration. For the following snippet:

  typedef access-operations-type {
    type bits {
      bit create {
      }
      bit read {
      }
      bit update {
      }
      bit delete {
      }
      bit exec {
      }
    }
  }

  leaf access-operations {
    type union {
      type matchall-string-type;
      type access-operations-type;
    }
    default *;
  }

we end up generating this code:

        public String stringValue() {
            if (_matchallStringType != null) {
                return _matchallStringType.getValue().toString();
            }
            if (_accessOperationsType != null) {
                return Arrays.toString(_accessOperationsType.getValue());
            }
            throw new IllegalStateException("No value assigned");
        }

The reference in Arrays.toString() is wrong – it needs to call values(), as there is no getValue() method ever since we have BitsTypeObject.

OpenDaylight JIRA

[MDSAL-797] Union's stringValue() does not handle BitsTypeObject