https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-1158 netconf <p>When sending a GET request to the test-tool device with, for example, the 'toaster2' model, it responds with a 500 error when asked for the 'Accept: application/yang' header.</p> <p><a href="http://192.168.56.100:8181/rests/modules/network-topology:network-topology/topology=topology-netconf/node=36001-sim-device/yang-ext:mount/toaster2/2009-11-20" class="external-link" target="_blank" rel="nofollow noopener">http://192.168.56.100:8181/rests/modules/network-topology:network-topology/topology=topology-netconf/node=36001-sim-device/yang-ext:mount/toaster2/2009-11-20</a></p> <p>The same request but with "Accept: application/yin+xml" header is working.</p> <ul> <li>Sending application/yang headers is working for controller models.</li> <li>In Karaf logs, there are no errors.</li> <li>Creating SchemaExportContext is successful for the device model. The exception is thrown in YangSchemaExportBodyWriter with the message:  "Unable to retrieve source from SourceProvider."</li> </ul> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>0 = {StackTraceElement@25842} "org.opendaylight.restconf.nb.rfc8040.jersey.providers.YangSchemaExportBodyWriter.writeTo(YangSchemaExportBodyWriter.java:42)" 1 = {StackTraceElement@25843} "org.opendaylight.restconf.nb.rfc8040.jersey.providers.YangSchemaExportBodyWriter.writeTo(YangSchemaExportBodyWriter.java:28)" 2 = {StackTraceElement@25844} "org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:242)" 3 = {StackTraceElement@25845} "org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:227)" 4 = {StackTraceElement@25846} "org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)" 5 = {StackTraceElement@25847} "org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:85)"</pre> </div></div> <p>The issue arises from the invocation of <tt>context.sourceProvider()</tt> within the <tt>YangSchemaExportBodyWriter</tt> class. This <tt>DOMYangTextSourceProvider</tt> contains controller models. Probably it will be required to explore alternative methods for generating the <tt>YangTextSchemaSource</tt>. For example, as it is done in <br/> YinSchemaExportBodyWriter.</p> NETCONF-1158

RestconfSchemaService returns 500 for device model

Bug Medium Open Unresolved Ivan Hrasko Peter Suna pick-next pt Tue, 19 Sep 2023 12:31:59 +0000 Thu, 12 Oct 2023 13:20:13 +0000 7.0.0 restconf-nb 0 1 <p>The issue here is that we are using `DOMYangTextSourceProvider` from the controller instead of from the device in <a href="https://github.com/opendaylight/netconf/blob/master/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/ParserIdentifier.java#L218" class="external-link" target="_blank" rel="nofollow noopener">ParseIdentifier#toSchemaExportContextFromIdentifier()</a></p> <p>To obtain the `DOMYangTextSourceProvider` for the device, we need to retrieve it from the device service, which is currently empty due to missing SchemaSourceProvider in the DOMSchemaService.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">final</span> Optional&lt;DOMSchemaService&gt; service = point.getMountPoint().getService(DOMSchemaService.class); service.get().getExtensions().getInstance(DOMYangTextSourceProvider.class); </pre> </div></div> <p>When the <a href="https://github.com/opendaylight/netconf/blob/fb67854c7137cefa6224d0e088d9b401de1eef22/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceMount.java#L67" class="external-link" target="_blank" rel="nofollow noopener">DOMMountPoint is prepared</a>, DOMSchemaService is created without SchemaSourceProvider.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> mountBuilder.addService(DOMSchemaService.class, FixedDOMSchemaService.of(() -&gt; initialCtx)); </pre> </div></div> <p>Device SchemaSourceProvider can be obtained from DeviceSources created <a href="https://github.com/opendaylight/netconf/blob/fb67854c7137cefa6224d0e088d9b401de1eef22/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/NetconfDevice.java#L151" class="external-link" target="_blank" rel="nofollow noopener">here</a>.</p> <p> </p> Development Rank 0|i046jb: