https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-1215 netconf <p>We are using ODL Boron.</p> <p>Mandatory attributes inside RPC input are not honoured , therefore RPC’s can be invoked without passing mandatory attributes.</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>rpc say-hello { input { leaf name { type string; mandatory true; } } } </pre> </div></div> <p> </p> <p>Whereas with RESTCONF url’s the mandatory attributes validation is happening</p> <p>RESTCONF ERROR:<br/> There is no Error to the North Bound(In the APIDOCS page), but in the server side, below logs are printed, CDS is not updated with the values as the validation is failed.</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Caused by: java.lang.IllegalArgumentException: Node (urn:opendaylight:params:xml:ns:yang:normalizednodedemo?revision=2015-01-05)emp-list[ {(urn:opendaylight:params:xml:ns:yang:normalizednodedemo?revision=2015-01-05)name=vikram} ] is missing mandatory descendant /(urn:opendaylight:params:xml:ns:yang:normalizednodedemo?revision=2015-01-05)age at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[58:com.google.guava:18.0.0] at org.opendaylight.yangtools.yang.data.impl.schema.tree.MandatoryLeafEnforcer$Strict.enforceOnTreeNode(MandatoryLeafEnforcer.java:60)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.MandatoryLeafEnforcer$Strict.enforceOnTreeNode(MandatoryLeafEnforcer.java:53)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.ListEntryModificationStrategy.applyWrite(ListEntryModificationStrategy.java:41)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.apply(SchemaAwareApplyOperation.java:216)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.mutateChildren(AbstractNodeContainerModificationStrategy.java:139)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.applyTouch(AbstractNodeContainerModificationStrategy.java:252)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.applyMerge(AbstractNodeContainerModificationStrategy.java:170)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.apply(SchemaAwareApplyOperation.java:207)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation.checkMinMaxElements(MinMaxElementsValidation.java:76)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation.checkMergeApplicable(MinMaxElementsValidation.java:114)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:131)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkChildPreconditions(AbstractNodeContainerModificationStrategy.java:305)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkMergeApplicable(AbstractNodeContainerModificationStrategy.java:313)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:131)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.StructuralContainerModificationStrategy.checkApplicable(StructuralContainerModificationStrategy.java:99)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkChildPreconditions(AbstractNodeContainerModificationStrategy.java:305)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkTouchApplicable(AbstractNodeContainerModificationStrategy.java:288)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:125)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.RootModificationApplyOperation.checkApplicable(RootModificationApplyOperation.java:72)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeTip.validate(AbstractDataTreeTip.java:37)[74:org.opendaylight.yangtools.yang-data-impl:1.0.0.Boron] </pre> </div></div> <p> </p> <p>RPC ERROR:<br/> Since there is no validation, it is returning the SUCCESSFUL RPC result to the North Bound</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-1215

Mandatory attributes in RPC input are not honoured

Bug Highest Confirmed Unresolved Unassigned Vikram Darsi pick-next pt Mon, 27 Mar 2017 15:58:25 +0000 Wed, 3 Jan 2024 17:31:33 +0000 7.0.0 restconf-nb 0 2 <p>Hi Vikram,</p> <p>well, looking at the stack trace, mandatory node validation in yangtools part works the way it should.</p> <p>The mandatory node "age" is not present in the "emp-list" list entry and that is the reason why the exception is thrown.</p> <p>Hi Igor Foltin</p> <p>Yes, with RESTCONF the mandatory attributes presence is validated. Bug descriptions says, the same validation is not performed while invoking RPC's (when its input does not have mandatory attributes)</p> <p>Could you please provide the exact steps you took to reproduce this behaviour?</p> <p>Thanks</p> <p>Please find the steps followed:</p> <p>1. Created sample project using the below command</p> <p>mvn archetype:generate -DarchetypeGroupId=org.opendaylight.controller -DarchetypeArtifactId=opendaylight-startup-archetype -DarchetypeRepository=<a href="http://nexus.opendaylight.org/content/repositories/opendaylight.release/" class="external-link" target="_blank" rel="nofollow noopener">http://nexus.opendaylight.org/content/repositories/opendaylight.release/</a> -DarchetypeCatalog=<a href="http://nexus.opendaylight.org/content/repositories/opendaylight.release/archetype-catalog.xml" class="external-link" target="_blank" rel="nofollow noopener">http://nexus.opendaylight.org/content/repositories/opendaylight.release/archetype-catalog.xml</a> -DarchetypeVersion=1.2.0-Boron</p> <p>2. api/src/main/yang/normalizednodedemo.yang</p> <p>module normalizednodedemo {<br/> yang-version 1;<br/> namespace "urn:opendaylight:params:xml:ns:yang:normalizednodedemo";<br/> prefix "normalizednodedemo";</p> <p> revision "2015-01-05" </p> { description "Initial revision of normalizednodedemo model"; } <p> rpc say-hello {<br/> input{<br/> leaf name</p> { type string; mandatory true; } <p> }<br/> }<br/> }</p> <p>3. impl/src/main/resources/impl-blueprint.xml</p> <p>&lt;?xml version="1.0" encoding="UTF-8"?&gt;<br/> &lt;!-- vi: set et smarttab sw=4 tabstop=4: --&gt;<br/> &lt;!--<br/> Copyright © 2016 AdvaOptical.com and others. All rights reserved.</p> <p>This program and the accompanying materials are made available under the<br/> terms of the Eclipse Public License v1.0 which accompanies this distribution,<br/> and is available at <a href="http://www.eclipse.org/legal/epl-v10.html" class="external-link" target="_blank" rel="nofollow noopener">http://www.eclipse.org/legal/epl-v10.html</a><br/> --&gt;<br/> &lt;blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"<br/> xmlns:odl="http://opendaylight.org/xmlns/blueprint/v1.0.0"<br/> odl:use-default-for-reference-types="true"&gt;</p> <p> &lt;reference id="dataBroker"<br/> interface="org.opendaylight.controller.md.sal.binding.api.DataBroker"<br/> odl:type="default" /&gt;</p> <p> &lt;bean id="provider"<br/> class="com.adva.ensemble.controller.impl.NormalizedNodeDemoProvider"<br/> init-method="init" destroy-method="close"&gt;<br/> &lt;argument ref="dataBroker" /&gt;<br/> &lt;/bean&gt;</p> <p> &lt;bean id="rpcDemo"<br/> class="com.adva.ensemble.controller.impl.NNRpcDemo"&gt;<br/> &lt;/bean&gt;</p> <p> &lt;odl:rpc-implementation ref="rpcDemo" /&gt;<br/> &lt;/blueprint&gt;</p> <p>4. impl/src/main/java<br/> com.adva.ensemble.controller.impl.NNRpcDemo</p> <p>package com.adva.ensemble.controller.impl;</p> <p>import java.util.concurrent.Future;</p> <p>import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.normalizednodedemo.rev150105.NormalizednodedemoService;<br/> import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.normalizednodedemo.rev150105.SayHelloInput;<br/> import org.opendaylight.yangtools.yang.common.RpcResult;<br/> import org.opendaylight.yangtools.yang.common.RpcResultBuilder;</p> <p>public class NNRpcDemo implements NormalizednodedemoService{</p> <p> @Override<br/> public Future&lt;RpcResult&lt;Void&gt;&gt; sayHello(SayHelloInput input) </p> { return RpcResultBuilder.&lt;Void&gt;success().buildFuture(); } <p>}</p> <p>5. mvn clean install -Pq</p> <p>6. karaf/target/assembly&gt; bin/karaf debug</p> <p>7. Launch APIDocs page: <a href="http://localhost:8181/apidoc/explorer/index.html" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/apidoc/explorer/index.html</a></p> <p> Invoke RPC : <a href="http://localhost:8181/restconf/operations/normalizednodedemo:say-hello" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operations/normalizednodedemo:say-hello</a></p> <p> JSON : {<br/> "input":{</p> <p> }<br/> }</p> <p> RESPONSE : 200 <br/> RESPONSE CODE : No Content</p> <p> NOTE: Mandatory attributes are not passed in the input.</p> <p>Thanks<br/> Vikram</p> <p>screenshot is attached which shows RPC invocation success when mandatory attributes are not passed</p> <p>Attachment RPCInvocation.png has been added with description: RPCInvocation Image that is showing success when mandatory attrs are not passed</p> <p>We will need to extract MandatoryLeafEnforcer – and probably some other portions of org.opendaylight.yangtools.yang.data.impl.schema.tree into yang-data-util where it would be usable by codecs.</p> Blocks YANGTOOLS-1259 Development External issue ID 8088 External issue URL Issue Type Rank 0|i0299b: