https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-234 netconf <p>we already have RESTCONF PATCH support (draft-ietf-netconf-yang-patch) for nodes in ODL's data store. Can we please extend that support to mounted NETCONF data stores?</p> <p>I guess the challenge here is that one RESTCONF PATCH will translate to multiple different NETCONF operations within a single transaction? At any rate this is required for real-world operation where you're managing your network using RESTCONF.</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-234

support RESTCONF PATCH for mounted NETCONF nodes

Improvement Resolved Done Ivan Hrasko Giles Heron Tue, 26 Jul 2016 17:00:16 +0000 Fri, 15 Mar 2019 22:22:27 +0000 Thu, 11 May 2017 07:48:48 +0000 restconf-nb 0 7 <p>Gerrit Patch:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/45073/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45073/</a></p> <p>Some PATCH edit operations do bot work properly on mounted devices due to <a href="https://bugs.opendaylight.org/show_bug.cgi?id=6681" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=6681</a></p> <p>Gerrit patch for old restconf is waiting for review:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/45073/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45073/</a></p> <p>Gerrit patch for new restconf: <a href="https://git.opendaylight.org/gerrit/#/c/46123/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46123/</a></p> <p>To work with transaction chains on mount point s you need: <a href="https://git.opendaylight.org/gerrit/#/c/45575/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45575/</a></p> <p>adaptation for Beryllium:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/46533/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46533/</a></p> <p>Will this be in Beryllium-SR4 and Boron-SR1?</p> <p>(In reply to Giles Heron from comment #8)<br/> &gt; Will this be in Beryllium-SR4 and Boron-SR1?</p> <p>Hi Giles,</p> <p>This is in both releases.</p> <p>Regards,</p> <p>Jakub Toth</p> <p>do you have any examples of using this to edit a mounted resource?</p> <p>See for example: <a href="https://lists.opendaylight.org/pipermail/netconf-dev/2016-October/000718.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/netconf-dev/2016-October/000718.html</a></p> <p>yup - I saw that. Still wasn't able to make it work <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>might start by trying a non-mounted model</p> <p>Yes, try first non-mounted, mounted is the same, only URi changes.</p> <p>I could see below challenges while executing HTTP PATCH on a netconf mount point.</p> <p>Version : Boron<br/> Issue reg : HTTP PATCH<br/> Module : ietf-yang-patch.yang</p> <p>1. Is yang patch not supported to change configuaration datastore on mount point ?<br/> 2. If this is supported on mount point, Is ODL controller expecting ietf-yang-patch module from mount point ? I don’t see this module under “schema” directory of ODL controller.<br/> 3. When we tried to emit this module from mount point we could see import failing for “import ietf-restconf </p> { prefix rc; } <p>”, but still it is listed under available-capability for mount point and seeing below error while trying to add config in yang-patch format.</p> <p>HTTP PATCH method:</p> <p>PATCH /restconf/config/network-topology:network-topology/topology/topology-netconf/node/device1/yang-ext:mount/ietf-yang-patch:yang-patch HTTP/1.1<br/> Host: 10.209.1.8:8181</p> <p>Headers:</p> <p>Accept: application/yang.patch-status+xml<br/> Content-Type: application/yang.patch+json</p> <p>Body:</p> <p>{<br/> "ietf-yang-patch:yang-patch": {<br/> "patch-id": "test",<br/> "edit": {<br/> "edit-id": "edit1",<br/> "operation": "create",<br/> "target": "/interfaces",<br/> "interface": {<br/> "name": "ge-0/0/0",<br/> "unit": {<br/> "name": "0",<br/> "family": {<br/> "inet": {<br/> "address": </p> { "name": "19.1.1.1/30" } <p> }<br/> }<br/> }<br/> }<br/> }<br/> }<br/> }</p> <p>Response:</p> <p>{<br/> "errors": {<br/> "error": [</p> { "error-type": "protocol", "error-tag": "unknown-element", "error-message": "\"yang-ext\" module does not exist in mount point." } <p> ]<br/> }<br/> }</p> <p>karaf Log:</p> <p>2017-04-28 14:36:59,488 | WARN | ssing-executor-1 | NetconfDevice | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch}: Unable to build schema context, unsatisfied imports {RevisionSourceIdentifier [name=ietf-yang-patch@2017-02-22]=[ModuleImportImpl [n ame=ietf-restconf, revision=null, semanticVersion=0.0.0]]}, will reattempt with resolved only<br/> 2017-04-28 14:36:59,488 | DEBUG | ssing-executor-1 | NetconfDevice | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | {}: Unable to build schema context, unsatisfied imports {}, will reattempt with resolved only<br/> SchemaResolutionException{unsatisfiedImports={RevisionSourceIdentifier [name=ietf-ya<br/> at org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$AssembleSources.apply(SharedSchemaContextFactory.java:203)[62:org.opendayli<br/> ght.yangtools.yang-parser-impl:1.0.1.Boron-SR1]<br/> at org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$AssembleSources.apply(SharedSchemaContextFactory.java:170)[62:org.opendayli<br/> ght.yangtools.yang-parser-impl:1.0.1.Boron-SR1]<br/> at com.google.common.util.concurrent.Futures$ChainingListenableFuture.run(Futures.java:906)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at com.google.common.util.concurrent.ExecutionList.add(ExecutionList.java:101)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at com.google.common.util.concurrent.AbstractFuture.addListener(AbstractFuture.java:170)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at com.google.common.util.concurrent.Futures.transform(Futures.java:567)<span class="error">&#91;38:com.google.guava:18.0.0&#93;</span><br/> at org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory.createSchemaContext(SharedSchemaContextFactory.java:104)[62:org.opendayligh<br/> t.yangtools.yang-parser-impl:1.0.1.Boron-SR1]<br/> at org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory.createSchemaContext(SharedSchemaContextFactory.java:72)[62:org.opendaylight<br/> .yangtools.yang-parser-impl:1.0.1.Boron-SR1]<br/> at org.opendaylight.yangtools.yang.model.repo.api.SchemaContextFactory.createSchemaContext(SchemaContextFactory.java:37)[59:org.opendaylight.yangtool<br/> s.yang-model-api:1.0.1.Boron-SR1]<br/> at org.opendaylight.netconf.sal.connect.netconf.NetconfDevice$SchemaSetup.setUpSchema(NetconfDevice.java:451)[263:org.opendaylight.netconf.sal-netcon<br/> f-connector:1.4.1.Boron-SR1]<br/> at org.opendaylight.netconf.sal.connect.netconf.NetconfDevice$SchemaSetup.run(NetconfDevice.java:428)[263:org.opendaylight.netconf.sal-netconf-connec<br/> tor:1.4.1.Boron-SR1]<br/> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:266)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:266)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">&#91;:1.8.0_121&#93;</span><br/> 2017-04-28 14:36:59,488 | TRACE | ssing-executor-1 | NetconfDevice | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{patch} <p>: Trying to build schema context from [RevisionSourceIdentifier <span class="error">&#91;name=show-version@2017-01-01&#93;</span>]<br/> 2017-04-28 14:36:59,494 | DEBUG | ssing-executor-1 | NetconfDevice | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch}: Schema context built successfully from [RevisionSourceIdentifier <span class="error">&#91;name=show-version@2017-01-01&#93;</span>]<br/> 2017-04-28 14:36:59,494 | INFO | ssing-executor-1 | MasterSalFacade | 267 - org.opendaylight.netconf.topology-singleton - 1.1.1.Boron-SR1 |<br/> RemoteDevice{patch} <p>: Creating master data broker for device<br/> 2017-04-28 14:36:59,496 | DEBUG | ssing-executor-1 | NetconfDeviceSalProvider | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch}: TOPOLOGY Mountpoint exposed into MD-SAL org.opendaylight.controller.md.sal.dom.broker.impl.mount.DOMMountPointServiceImpl$MountRegis<br/> tration@671e331<br/> 2017-04-28 14:36:59,497 | DEBUG | ssing-executor-1 | KeepaliveSalFacade | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{patch} <p>: Netconf session initiated, starting keepalives<br/> 2017-04-28 14:36:59,497 | DEBUG | lt-dispatcher-55 | NetconfNodeActor | 267 - org.opendaylight.netconf.topology-singleton - 1.1.1.Boron-SR1 |<br/> RemoteDevice</p> {patch}: Master is ready.<br/> 2017-04-28 14:36:59,497 | TRACE | ssing-executor-1 | KeepaliveSalFacade | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{patch} <p>: Scheduling next keepalive in 120 SECONDS<br/> 2017-04-28 14:36:59,497 | INFO | ssing-executor-1 | NetconfDevice | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch}: Netconf connector initialized successfully<br/> 2017-04-28 14:36:59,497 | TRACE | dispatcher-58809 | NetconfDeviceTopologyAdapter | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{patch} <p>: Update device state transaction DOM-CHAIN-65-1 merging operational data started.<br/> 2017-04-28 14:36:59,498 | TRACE | dispatcher-58809 | NetconfDeviceTopologyAdapter | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch}: Update device state transaction DOM-CHAIN-65-1 merging operational data ended.<br/> 2017-04-28 14:36:59,498 | TRACE | dispatcher-58809 | NetconfDeviceTopologyAdapter | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{patch} <p>: Committing Transaction update:DOM-CHAIN-65-1<br/> 2017-04-28 14:36:59,499 | TRACE | ommitFutures-211 | NetconfDeviceTopologyAdapter | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {patch} <p>: Transaction(update) DOM-CHAIN-65-1 SUCCESSFUL<br/> 2017-04-28 14:37:26,077 | TRACE | p219366924-80317 | BrokerFacade | 269 - org.opendaylight.netconf.sal-rest-connector - 1.4.1.Boron-SR1 |<br/> Read OPERATIONAL via Restconf: /(urn:TBD:params:xml:ns:yang:network-topology?revision=2013-10-21)network-topology/topology/topology[</p> {(urn:TBD:params:xml:ns: yang:network-topology?revision=2013-10-21)topology-id=topology-netconf} <p>]<br/> 2017-04-28 14:37:26,077 | DEBUG | p219366924-80317 | BrokerFacade | 269 - org.opendaylight.netconf.sal-rest-connector - 1.4.1.Boron-SR1 |<br/> Reading result data from transaction.<br/> 2017-04-28 14:37:47,617 | TRACE | ssing-executor-8 | KeepaliveSalFacade | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice</p> {deploy}: Invoking keepalive RPC<br/> 2017-04-28 14:37:47,618 | TRACE | ssing-executor-8 | NetconfDeviceCommunicator | 263 - org.opendaylight.netconf.sal-netconf-connector - 1.4.1.Boron-SR<br/> 1 | RemoteDevice{deploy} <p>: Sending message &lt;rpc message-id="m-285" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"&gt;<br/> &lt;get-config&gt;<br/> &lt;source&gt;</p> <p>Hi</p> <p>Yang PATCH is supported on mount points in latest Boron (SR-3).</p> <p>message:</p> <p>{<br/>   "errors": {<br/>     "error": [<br/>       </p> {         "error-type": "protocol",         "error-tag": "unknown-element",         "error-message": "\"yang-ext\" module does not exist in mount point."       } <p>    ]<br/>   }<br/> }</p> <p>wants to tell you that module "ietf-yang-patch" does not exist behind mount point (its different bug solved in next releases:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/52724/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/52724/</a>).</p> <p>ietf-yang-patch describes Yang PATCH data message structure, it is not located on mount point or controller itself.<br/> I do not understand why you want to use it.<br/> Try to use another module which you are sure is present behind mount point.</p> <p>Regards</p> <p>See examples:<br/> <a href="https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Restconf" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Restconf</a></p> <p>Just change URI to point to your mount point.</p> Blocks NETCONF-273 Duplicate NETCONF-266 Development External issue ID 6272 External issue URL Issue Type ODL SR Target Milestone Rank 0|i01xa7: