OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[NETCONF-242] Bump apache mina version from the pre-release to current release https://jira.opendaylight.org/browse/NETCONF-242 netconf <p>Initial work had to be reverted in <a href="https://git.opendaylight.org/gerrit/#/c/42627/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/42627/</a><br/> due to failures in establishing netconf connections.</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-242

Bump apache mina version from the pre-release to current release

Bug Resolved Done Unassigned Tomas Cere Mon, 1 Aug 2016 08:32:59 +0000 Fri, 15 Mar 2019 22:22:27 +0000 Mon, 19 Mar 2018 22:01:30 +0000 Oxygen netconf 1 3 <p>The cause for the revert is in: <a href="https://bugs.opendaylight.org/show_bug.cgi?id=6273" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=6273</a></p> <p>The root cause is:</p> <p>2016-07-26 12:54:04,004 | WARN | oupCloseable-3-1 | ChannelInitializer | 112 - io.netty.common - 4.0.37.Final | Failed to initialize a channel. Closing: <span class="error">[id: 0x3b162577]</span><br/> java.lang.NoSuchMethodError: org.apache.mina.core.service.SimpleIoProcessorPool.<init>(Ljava/lang/Class;Ljava/util/concurrent/Executor;ILjava/nio/channels/spi/SelectorProvider;)V<br/> at org.apache.sshd.common.io.mina.MinaServiceFactory.<init>(MinaServiceFactory.java:44)<br/> at org.apache.sshd.common.io.mina.MinaServiceFactoryFactory.create(MinaServiceFactoryFactory.java:49)<br/> at org.apache.sshd.common.io.DefaultIoServiceFactoryFactory.create(DefaultIoServiceFactoryFactory.java:49)<br/> at org.apache.sshd.common.helpers.AbstractFactoryManager.getIoServiceFactory(AbstractFactoryManager.java:101)<br/> at org.apache.sshd.client.SshClient.createConnector(SshClient.java:714)<br/> at org.apache.sshd.client.SshClient.start(SshClient.java:441)<br/> at org.opendaylight.netconf.nettyutil.handler.ssh.client.AsyncSshHandler.<clinit>(AsyncSshHandler.java:52)<br/> at org.opendaylight.netconf.client.SshClientChannelInitializer.initialize(SshClientChannelInitializer.java:34)<br/> at org.opendaylight.netconf.client.NetconfClientDispatcherImpl$4.initializeChannel(NetconfClientDispatcherImpl.java:117)<br/> at org.opendaylight.netconf.client.NetconfClientDispatcherImpl$4.initializeChannel(NetconfClientDispatcherImpl.java:114)<br/> at org.opendaylight.protocol.framework.ReconnectPromise$1.initializeChannel(ReconnectPromise.java:52)<br/> at org.opendaylight.protocol.framework.ReconnectPromise$1.initializeChannel(ReconnectPromise.java:49)<br/> at org.opendaylight.protocol.framework.AbstractDispatcher$3.initChannel(AbstractDispatcher.java:194)<br/> at org.opendaylight.protocol.framework.AbstractDispatcher$3.initChannel(AbstractDispatcher.java:191)<br/> at io.netty.channel.ChannelInitializer.channelRegistered(ChannelInitializer.java:68)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:136)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:122)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:115)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRegistered(DefaultChannelPipeline.java:1253)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:136)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:122)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.DefaultChannelPipeline.fireChannelRegistered(DefaultChannelPipeline.java:784)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:445)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:368)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:418)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:358)<span class="error">[112:io.netty.common:4.0.37.Final]</span><br/> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:394)<span class="error">[113:io.netty.transport:4.0.37.Final]</span><br/> at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)<span class="error">[112:io.netty.common:4.0.37.Final]</span><br/> at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:145)<span class="error">[112:io.netty.common:4.0.37.Final]</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">[:1.8.0_91]</span></p> <p>which boils down to sshd-core requiring mina-core-2.0.13, not 2.0.7 as defaulting in karaf somewhere. This should be fixed by pulling in proper version via a feature.</p> <p><a href="https://git.opendaylight.org/gerrit/42911" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/42911</a></p> <p>Adding mina-core into the feature def doesn't seem to help, needs more analysis to check if karaf isn't adding it onto the classpath.</p> <p>We can probably handle this in the same way as the Aries Proxy overrides; I'm working on a patch.</p> <p>I've pushed <a href="https://git.opendaylight.org/gerrit/43034" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/43034</a> which produces a Karaf assembly with up-to-date Mina and sshd-core.</p> <p>I forgot to mention that the previous patch (against odlparent) also needs <a href="https://git.opendaylight.org/gerrit/42649" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/42649</a> against controller to work. You need to rebuild odlparent, controller, then integration/distribution.</p> <p>Thanks for the patch Stephen, it fixed the issues with netconf with the mina bump, however the karaf client script seems to be broken now:</p> <p>bin\> ./client -u karaf<br/> Error: A JNI error has occurred, please check your installation and try again<br/> Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/sshd/client/UserInteraction<br/> at java.lang.Class.getDeclaredMethods0(Native Method)<br/> at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)<br/> at java.lang.Class.privateGetMethodRecursive(Class.java:3048)<br/> at java.lang.Class.getMethod0(Class.java:3018)<br/> at java.lang.Class.getMethod(Class.java:1784)<br/> at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544)<br/> at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526)<br/> Caused by: java.lang.ClassNotFoundException: org.apache.sshd.client.UserInteraction<br/> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)<br/> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)<br/> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)<br/> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)<br/> ... 7 more</p> <p>(In reply to Tomas Cere from comment #7)<br/> > Thanks for the patch Stephen, it fixed the issues with netconf with the mina<br/> > bump, however the karaf client script seems to be broken now:</p> <p>Thanks for the test! Robert suspected the sshd-core bump would break Karaf, I was in the process of checking...</p> <p>(In reply to Tomas Cere from comment #7)<br/> > Thanks for the patch Stephen, it fixed the issues with netconf with the mina<br/> > bump, however the karaf client script seems to be broken now:<br/> > <br/> > bin\> ./client -u karaf</p> <p>Does it work for you if you edit bin/client so the line containing sshd-core reads</p> <p> CLASSPATH="$CLASSPATH:$KARAF_HOME/system/org/apache/sshd/sshd-core/0.14.0/sshd-core-0.14.0.jar"</p> <p>(It logs sensible stuff on my system but I then get the "EC KeyPairGenerator not available" error.)</p> <p>(In reply to Stephen Kitt from comment #9)<br/> > (In reply to Tomas Cere from comment #7)<br/> > > Thanks for the patch Stephen, it fixed the issues with netconf with the mina<br/> > > bump, however the karaf client script seems to be broken now:<br/> > > <br/> > > bin\> ./client -u karaf<br/> > <br/> > Does it work for you if you edit bin/client so the line containing sshd-core<br/> > reads<br/> > <br/> > <br/> > CLASSPATH="$CLASSPATH:$KARAF_HOME/system/org/apache/sshd/sshd-core/0.14.0/<br/> > sshd-core-0.14.0.jar"<br/> > <br/> > (It logs sensible stuff on my system but I then get the "EC KeyPairGenerator<br/> > not available" error.)</p> <p>After upgrading my JDK it works for me, I'll update the odlparent patch.</p> <p>Ok now we have a weird behavior. It works fine the first time when you run karaf and install odl-netconf-connector-all, but when you restart karaf the </p> <p>java.lang.NoSuchMethodError: org.apache.mina.core.service.SimpleIoProcessorPool.<init>(Ljava/lang/Class;Ljava/util/concurrent/Executor;ILjava/nio/channels/spi/SelectorProvider;)V</p> <p>is back.</p> <p>We need karaf-4.1.x, after which we can jump to 1.4.0.</p> <p>Now that Karaf 4 is in place, any interest in resuming work on updating to 1.6.0 or 1.7.0?</p> <p> </p> <p>We are currently using 1.6.0, which is what is shipping with karaf-4.1.x – that bump occurred in Oxygen. I would suggest integrating 1.7.0 when we bump to karaf-4.2.x, as keeping the versions aligned is beneficial in side-stepping issues.</p> <p>Fixed with bump to odlparent-3.0.x. If upgrading to 1.7.0 before karaf-4.2.x comes down (which is not happening in Fluorine) is of interest, please file a separate issue.</p> <p>Excellent; thanks. I'll commence testing a variety of netconf devices with Oxygen to benefit from 1.6.0, and file separate bugs if/as they occur.</p> <p> </p> Blocks ODLPARENT-86 Development External issue ID 6318 External issue URL Issue Type Rank 0|i01xbz: