<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:14:32 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[NETCONF-248] Incorrect handling of configuration failures in SAL netconf connector</title>
                <link>https://jira.opendaylight.org/browse/NETCONF-248</link>
                <project id="10142" key="NETCONF">netconf</project>
                    <description>&lt;p&gt;Version: 1.1.0-SNAPSHOT (Boron) (master branch)&lt;/p&gt;

&lt;p&gt;SAL netconf connector handles invalid configuration just by logging warning message what casues that RESTCONF response indicates result code 200 OK.&lt;/p&gt;

&lt;p&gt;Possible solution:&lt;br/&gt;
&lt;a href=&quot;https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=blob;f=netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java;h=4001c3186b385d16b376421256c9ac66c3dba224;hb=refs/heads/master#l192&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=blob;f=netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java;h=4001c3186b385d16b376421256c9ac66c3dba224;hb=refs/heads/master#l192&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;In the method onSuccess() there&apos;s a check isSuccess(). If the isSuccess returns false, then the warning message is logged. But there should be used the same handling as in the method onFailure().&lt;/p&gt;

&lt;p&gt;See attached logs for more details.&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="21261">NETCONF-248</key>
            <summary>Incorrect handling of configuration failures in SAL netconf connector</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="jmorvay@cisco.com">Jakub Morvay</assignee>
                                    <reporter username="tjanciga">Tomas Janciga</reporter>
                        <labels>
                    </labels>
                <created>Fri, 5 Aug 2016 08:14:22 +0000</created>
                <updated>Fri, 15 Mar 2019 22:22:28 +0000</updated>
                            <resolved>Wed, 21 Sep 2016 12:00:53 +0000</resolved>
                                                                    <component>netconf</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>6</watches>
                                                                                                                <comments>
                            <comment id="39573" author="tjanciga" created="Fri, 5 Aug 2016 08:14:22 +0000"  >&lt;p&gt;Attachment netconf_sal_connector_karaf.log has been added with description: Karaf logs showing the configuration sent, it&apos;s processing and the warning message logged instead of the appropriate handling.&lt;/p&gt;</comment>
                            <comment id="39566" author="jmorvay@cisco.com" created="Tue, 9 Aug 2016 08:12:54 +0000"  >&lt;p&gt;Alexis, &lt;/p&gt;

&lt;p&gt;If you are working on this bug, I assume it is real bug, so can you also set status to CONFIRMED?&lt;/p&gt;</comment>
                            <comment id="39567" author="adetalhouet" created="Tue, 9 Aug 2016 11:10:49 +0000"  >&lt;p&gt;Done, thanks.&lt;/p&gt;</comment>
                            <comment id="39568" author="adetalhouet" created="Tue, 9 Aug 2016 12:04:27 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/43229/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/43229/&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="39569" author="rudolf.brisuda@pantheon.tech" created="Thu, 25 Aug 2016 09:32:39 +0000"  >&lt;p&gt;The actual solution rely on blocking get. I fixed it in: &lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/44646/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/44646/&lt;/a&gt;&lt;br/&gt;
where exceptions are raised in submit method.&lt;/p&gt;</comment>
                            <comment id="39570" author="rudolf.brisuda@pantheon.tech" created="Thu, 25 Aug 2016 09:41:44 +0000"  >&lt;p&gt;I abandoned posted url and I made only new patch in &lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/43229/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/43229/&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="39571" author="jmorvay@cisco.com" created="Mon, 5 Sep 2016 12:11:53 +0000"  >&lt;p&gt;Needs to be merged also to Boron&lt;/p&gt;</comment>
                            <comment id="39572" author="jmorvay@cisco.com" created="Mon, 5 Sep 2016 12:13:26 +0000"  >&lt;p&gt;Here&apos;s patch for stable/boron:&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/45054/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/45054/&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="12686" name="netconf_sal_connector_karaf.log" size="373374" author="tomas.janciga@pantheon.tech" created="Fri, 5 Aug 2016 08:14:22 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6343</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=6343]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10204" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>ODL SR Target Milestone</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10307"><![CDATA[Boron-1]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i01xdb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>