https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-403 netconf <p>Do not mix read and write operations in one loop. </p> <p>This change is needed for old restconf (BrokerFacade.java) and also for new restconf (RestconfDataServiceImpl and its utility helper classes).</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-403

Eliminate blocking checks in loops, so the checks are done in parallel

Bug Resolved Done Vladyslav Marchenko Ivan Hrasko Fri, 21 Apr 2017 10:42:20 +0000 Tue, 23 Feb 2021 18:45:01 +0000 Tue, 23 Feb 2021 18:45:01 +0000 1.13.0 restconf-nb 0 2 <p>This is follow up issue of <a href="https://bugs.opendaylight.org/show_bug.cgi?id=7868" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=7868</a></p> <p>Changes are made only for rfc4080!<br/> According to RFC6241, we need to do "if exists" check for "delete" and "create"operations.<br/> Currently we have two scenarios: <br/> 1) when device is connected and we execute operation on device's datastore (using NetconfRestconfStrategy.java)<br/> 2) execute operation on local controller's datastore (using MdsalRestconfStrategy.java)</p> <p>If request goes via NetconfRestconfStrategy.java we don't need to check existence on the controller side. As implementation of &lt;edit-config&gt; with "delete"/"create"operations - first must do "if exists" check. As en example see org.opendaylight.netconf.mdsal.connector.ops.EditConfig.java</p> <p>If request goes via MdsalRestconfStrategy.java, first we need to do "if exists" check.<br/> Read requests in this case, are collected in a batch and then collecting the results. (The same as was done in <a href="https://git.opendaylight.org/gerrit/c/netconf/+/55224" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/55224</a>)</p> <p>For testing performance this script was used (with device simulator):<br/> python cluster_rest_script.py --host localhost --port 8181 --threads 1 --itemcount 10000 --ipr 10000 --debug add</p> <p>Before this patch:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <th class='confluenceTh'> Local datastore </th> <th class='confluenceTh'>Device's datastore </th> </tr> <tr> <td class='confluenceTd'> ~ 98 sec </td> <td class='confluenceTd'> &gt; 600 sec (failed by timeout)</td> </tr> </tbody></table> </div> <p>After this patch:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <th class='confluenceTh'> Local datastore </th> <th class='confluenceTh'>Device's datastore </th> </tr> <tr> <td class='confluenceTd'> ~ 1,5 sec </td> <td class='confluenceTd'> ~ 15 sec </td> </tr> </tbody></table> </div> Blocks NETCONF-405 Relates NETCONF-743 Development External issue ID 8268 External issue URL Issue Type ODL SR Target Milestone Rank 0|i01ybr: