https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-42 netconf <p>its a good practice to have a default case for all switch statements</p> <p>public class NetconfChunkAggregator extends ByteToMessageDecoder </p> <p>in the function --&gt; protected void decode</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-42

default case

Bug Resolved Won't Do Shivani Pathak Shashidhar Shekar Mon, 29 Jun 2015 12:36:07 +0000 Fri, 15 Mar 2019 22:22:12 +0000 Tue, 15 Dec 2015 09:25:57 +0000 netconf 0 2 <p>Move to NETCONFI project.</p> <p>In NetconfChunkAggregator switch statement expression is an Enumerated type. Value for the same is fetched as below:</p> <p>private State state=State.HEADER_ONE; </p> <p>Always the first case with label HEADER_ONE will get executed </p> <p>case HEADER_ONE:</p> { final byte b = in.readByte(); checkNewLine(b, "Malformed chunk header encountered (byte 0)"); state = State.HEADER_TWO; initChunk(); break; } <p>Hence default case is not required as per my analysis.</p> <p>Please suggest if there is a necessity to do so.</p> <p>Looked it over and you are correct, no need for a default case here.</p> Development External issue ID 3886 External issue URL Issue Type ODL SR Target Milestone Rank 0|i01w3j: