https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-452 netconf <p>This is affecting Nitrogen CSIT. Robot symptom is prefixes missing <span class="error">&#91;0&#93;</span>, but the reason is visible in configurer tool log <span class="error">&#91;1&#93;</span> and in karaf.log <span class="error">&#91;2&#93;</span> (at 05:45:12,953):</p> <p>2017-08-14 05:45:12,953 | ERROR | qtp573170128-423 | ContainerResponse | 33 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container<br/> java.lang.NullPointerException<br/> at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.checkInstanceIdentifierReferencesData(AbstractDOMBrokerWriteTransaction.java:87)<br/> at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.put(AbstractDOMBrokerWriteTransaction.java:79)<br/> at org.opendaylight.netconf.sal.restconf.impl.BrokerFacade.simplePostPut(BrokerFacade.java:941)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.BrokerFacade.makeNormalPost(BrokerFacade.java:890)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.BrokerFacade.postData(BrokerFacade.java:707)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.BrokerFacade.postDataViaTransaction(BrokerFacade.java:689)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.BrokerFacade.commitConfigurationDataPost(BrokerFacade.java:468)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.RestconfImpl.createConfigurationData(RestconfImpl.java:973)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.RestconfImpl.createConfigurationData(RestconfImpl.java:920)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.restconf.impl.StatisticsRestconfServiceWrapper.createConfigurationData(StatisticsRestconfServiceWrapper.java:157)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netconf.sal.rest.impl.RestconfCompositeWrapper.createConfigurationData(RestconfCompositeWrapper.java:92)<span class="error">&#91;313:org.opendaylight.netconf.sal-rest-connector:1.6.0.SNAPSHOT&#93;</span></p> <p>It is possible that this is just a consequence of the preceding <a href="https://jira.opendaylight.org/browse/BGPCEP-683" title="example-bgp-rib does not exist when updating peer configuration" class="issue-link" data-issue-key="BGPCEP-683"><del>BGPCEP-683</del></a> symptoms.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/log.html.gz#s1-s5-t5-k2-k2-k1-k6" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/log.html.gz#s1-s5-t5-k2-k2-k1-k6</a><br/> <span class="error">&#91;1&#93;</span> <a href="https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/bgp_app_peer_initial_post_tc1.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/bgp_app_peer_initial_post_tc1.log.gz</a><br/> <span class="error">&#91;2&#93;</span> <a href="https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/odl1_karaf.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-nitrogen/113/odl1_karaf.log.gz</a></p> <p>Operating System: All<br/> Platform: All</p> NETCONF-452

NPE when adding routes to app-peer

Bug Resolved Done Jakub Morvay Vratko Polak Mon, 14 Aug 2017 13:57:35 +0000 Fri, 15 Mar 2019 22:22:43 +0000 Fri, 13 Oct 2017 13:25:19 +0000 restconf-nb 0 3 <p>&gt; It is possible that this is just a consequence of the preceding <a href="https://jira.opendaylight.org/browse/BGPCEP-683" title="example-bgp-rib does not exist when updating peer configuration" class="issue-link" data-issue-key="BGPCEP-683"><del>BGPCEP-683</del></a> symptoms.</p> <p>It is not, as <span class="error">&#91;3&#93;</span> fixes <a href="https://jira.opendaylight.org/browse/BGPCEP-683" title="example-bgp-rib does not exist when updating peer configuration" class="issue-link" data-issue-key="BGPCEP-683"><del>BGPCEP-683</del></a> but this symptom is still visible in gate job tool log <span class="error">&#91;4&#93;</span>.</p> <p>Also, Claudio says this is a Restconf bug, so changing component.</p> <p><span class="error">&#91;3&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/62636/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62636/1</a><br/> <span class="error">&#91;4&#93;</span> <a href="https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-gate-userfeatures-only-nitrogen/7/bgp_app_peer_initial_post_tc1.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-gate-userfeatures-only-nitrogen/7/bgp_app_peer_initial_post_tc1.log.gz</a></p> <p>&gt; gate job tool log <span class="error">&#91;4&#93;</span>.</p> <p>Restconf request details copied here.</p> <p>method: POST</p> <p>URL: 10.29.12.209:8181/restconf/config/bgp-rib:application-rib/10.29.12.209/tables/bgp-types:ipv4-address-family/bgp-types:unicast-subsequent-address-family/</p> <p>XML data:<br/> &lt;ipv4-routes xmlns="urn:opendaylight:params:xml:ns:yang:bgp-inet"&gt;<br/> &lt;ipv4-route&gt;<br/> &lt;prefix&gt;8.0.1.0/28&lt;/prefix&gt;<br/> &lt;path-id&gt;0&lt;/path-id&gt;<br/> &lt;attributes&gt;<br/> &lt;ipv4-next-hop&gt;<br/> &lt;global&gt;192.0.2.1&lt;/global&gt;<br/> &lt;/ipv4-next-hop&gt;&lt;as-path/&gt;<br/> &lt;multi-exit-disc&gt;<br/> &lt;med&gt;0&lt;/med&gt;<br/> &lt;/multi-exit-disc&gt;<br/> &lt;local-pref&gt;<br/> &lt;pref&gt;100&lt;/pref&gt;<br/> &lt;/local-pref&gt;<br/> &lt;originator-id&gt;<br/> &lt;originator&gt;41.41.41.41&lt;/originator&gt;<br/> &lt;/originator-id&gt;<br/> &lt;origin&gt;<br/> &lt;value&gt;igp&lt;/value&gt;<br/> &lt;/origin&gt;<br/> &lt;cluster-id&gt;<br/> &lt;cluster&gt;40.40.40.40&lt;/cluster&gt;<br/> &lt;/cluster-id&gt;<br/> &lt;/attributes&gt;<br/> &lt;/ipv4-route&gt;<br/> &lt;ipv4-route&gt;<br/> &lt;prefix&gt;8.0.1.16/28&lt;/prefix&gt;<br/> &lt;path-id&gt;0&lt;/path-id&gt;<br/> &lt;attributes&gt;<br/> &lt;ipv4-next-hop&gt;<br/> &lt;global&gt;192.0.2.1&lt;/global&gt;<br/> &lt;/ipv4-next-hop&gt;&lt;as-path/&gt;<br/> &lt;multi-exit-disc&gt;<br/> &lt;med&gt;0&lt;/med&gt;<br/> &lt;/multi-exit-disc&gt;<br/> &lt;local-pref&gt;<br/> &lt;pref&gt;100&lt;/pref&gt;<br/> &lt;/local-pref&gt;<br/> &lt;originator-id&gt;<br/> &lt;originator&gt;41.41.41.41&lt;/originator&gt;<br/> &lt;/originator-id&gt;<br/> &lt;origin&gt;<br/> &lt;value&gt;igp&lt;/value&gt;<br/> &lt;/origin&gt;<br/> &lt;cluster-id&gt;<br/> &lt;cluster&gt;40.40.40.40&lt;/cluster&gt;<br/> &lt;/cluster-id&gt;<br/> &lt;/attributes&gt;<br/> &lt;/ipv4-route&gt;<br/> &lt;ipv4-route&gt;<br/> &lt;prefix&gt;8.0.1.32/28&lt;/prefix&gt;<br/> &lt;path-id&gt;0&lt;/path-id&gt;<br/> &lt;attributes&gt;<br/> &lt;ipv4-next-hop&gt;<br/> &lt;global&gt;192.0.2.1&lt;/global&gt;<br/> &lt;/ipv4-next-hop&gt;&lt;as-path/&gt;<br/> &lt;multi-exit-disc&gt;<br/> &lt;med&gt;0&lt;/med&gt;<br/> &lt;/multi-exit-disc&gt;<br/> &lt;local-pref&gt;<br/> &lt;pref&gt;100&lt;/pref&gt;<br/> &lt;/local-pref&gt;<br/> &lt;originator-id&gt;<br/> &lt;originator&gt;41.41.41.41&lt;/originator&gt;<br/> &lt;/originator-id&gt;<br/> &lt;origin&gt;<br/> &lt;value&gt;igp&lt;/value&gt;<br/> &lt;/origin&gt;<br/> &lt;cluster-id&gt;<br/> &lt;cluster&gt;40.40.40.40&lt;/cluster&gt;<br/> &lt;/cluster-id&gt;<br/> &lt;/attributes&gt;<br/> &lt;/ipv4-route&gt; <br/> &lt;/ipv4-routes&gt;</p> <p>I have tried to reproduce this manually, but it did not happen for me.<br/> I think Robot suite catches ODL in some transient state before it finishes booting up.</p> <p>I will continue my investigations on Sandbox.</p> <p>&gt; I will continue my investigations on Sandbox.</p> <p>When run with a logging change <span class="error">&#91;5&#93;</span>, the test passed <span class="error">&#91;6&#93;</span>.</p> <p>Meanwhile, Robert proposed <span class="error">&#91;7&#93;</span> a guard (so no increased logging as with my change), running that now.</p> <p><span class="error">&#91;5&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/62670/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62670/1</a><br/> <span class="error">&#91;6&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/bgpcep-csit-1node-userfeatures-only-nitrogen/1/bgp_app_peer_initial_post_tc1.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/bgpcep-csit-1node-userfeatures-only-nitrogen/1/bgp_app_peer_initial_post_tc1.log.gz</a><br/> <span class="error">&#91;7&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/62699/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62699/1</a></p> <p>Testing with logging change <span class="error">&#91;8&#93;</span> shows the reason is XML codec getting apparently empty input stream.</p> <p>By "shows" I mean karaf.log <span class="error">&#91;9&#93;</span> from sandbox contains the incriminating line:</p> <p>2017-09-06 12:56:22,244 | WARN | qtp444030204-142 | XmlNormalizedNodeBodyReader | 314 - org.opendaylight.netconf.sal-rest-connector - 1.6.0.SNAPSHOT | Reading empty payload!</p> <p><span class="error">&#91;8&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/62752/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62752/3</a><br/> <span class="error">&#91;9&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/bgpcep-csit-1node-userfeatures-only-nitrogen/5/odl1_karaf.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/bgpcep-csit-1node-userfeatures-only-nitrogen/5/odl1_karaf.log.gz</a></p> <p>One difference from other suites is that the Restconf request is constructed by a Python utility <span class="error">&#91;10&#93;</span> (instead of a Robot library) which sends data in chunks.<br/> Perhaps Carbon http server was joining this chunks for Restconf, but Nitrogen passes the input stream without reading all the data?</p> <p><span class="error">&#91;10&#93;</span> <a href="https://github.com/opendaylight/integration-test/blob/master/tools/fastbgp/bgp_app_peer.py" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/integration-test/blob/master/tools/fastbgp/bgp_app_peer.py</a></p> <p><a href="https://jira.opendaylight.org/browse/NETCONF-467" title="Restconf often invokes RPCs with null payload" class="issue-link" data-issue-key="NETCONF-467"><del>NETCONF-467</del></a> might be a duplicate, or at least a related problem<br/> <a href="https://bugs.opendaylight.org/show_bug.cgi?id=9125" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=9125</a></p> <p>(In reply to Vratko Polák from comment #6)<br/> &gt; One difference from other suites is that the Restconf request is constructed<br/> &gt; by a Python utility <span class="error">&#91;10&#93;</span> (instead of a Robot library) which sends data in<br/> &gt; chunks.<br/> &gt; Perhaps Carbon http server was joining this chunks for Restconf, but<br/> &gt; Nitrogen passes the input stream without reading all the data?</p> <p>Yeah, it looks like this is the case. Our implementation checks for empty payload incorrectly. In a case that the first chunk of payload's data is unavailable during processing request by our implementations of MessageBodyReader, it prematurely sorts out non-empty payload as empty payload. We read NormalizedNodeContext with null data and this ends with NPE from md-sal, because we want to store null data. </p> <p>Fix for Nitrogen:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63048/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/63048/</a></p> <p>Oxygen:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/63055/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/63055/</a></p> Duplicate NETCONF-467 Development External issue ID 8988 External issue URL Issue Type ODL SR Target Milestone Rank 0|i01ymn: