OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[NETCONF-462] TransactionChain created in RestConnectorProvider.start line 87 is never closed https://jira.opendaylight.org/browse/NETCONF-462 netconf <p>As found in see <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> motivated by <a href="https://jira.opendaylight.org/browse/CONTROLLER-1756" title="OOM due to huge Map in ShardDataTree" class="issue-link" data-issue-key="CONTROLLER-1756"><del>CONTROLLER-1756</del></a>:</p> <p>TransactionChain created in RestConnectorProvider.start line 87 is never closed</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-462

TransactionChain created in RestConnectorProvider.start line 87 is never closed

Bug Resolved Cannot Reproduce Unassigned Michael Vorburger Tue, 29 Aug 2017 21:57:17 +0000 Fri, 15 Mar 2019 22:22:44 +0000 Thu, 31 Aug 2017 13:23:48 +0000 restconf-nb 0 1 <p>Actually, it should be closed in RestConnectorProvider.close method.</p> <p>Please see:<br/> <a href="https://github.com/opendaylight/netconf/blob/b370572f7a18b3799c9b8d0050a5862937ddb863/restconf/sal-rest-connector/src/main/java/org/opendaylight/restconf/RestConnectorProvider.java#L138" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/netconf/blob/b370572f7a18b3799c9b8d0050a5862937ddb863/restconf/sal-rest-connector/src/main/java/org/opendaylight/restconf/RestConnectorProvider.java#L138</a></p> <p>Jakub, OK I see, so this is a case where ONE (and always only ever one, never more, can you confirm this?) TransactionChain is created and kept open for entire life time on ODL, and closed only on shutdown... correct? Then that's not a "leak" (of the kind I'm chasing for <a href="https://jira.opendaylight.org/browse/CONTROLLER-1756" title="OOM due to huge Map in ShardDataTree" class="issue-link" data-issue-key="CONTROLLER-1756"><del>CONTROLLER-1756</del></a> using <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a>) - and I'm OK if you just close this issue as RESOLVED INVALID or WONTFIX. </p> <p>Thanks for having had a look - I think it's valuable to record such findings here.</p> <p>PS: Maybe the "trace:transactions" CLI command from <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> in the future should have some sort of <span class="error">[hard-coded? :-(]</span> "white list" to not show e.g. this one - or can you think of a better way how it could be made "smart enough" to understand that e.g this TransactionChain is not a leak? Or perhaps I could just suppress anything that is only x1 and only start showing x2+ open TransactionChains - do you think that would be a good idea?</p> <p>(In reply to Michael Vorburger from comment #2)<br/> > Jakub, OK I see, so this is a case where ONE (and always only ever one,<br/> > never more, can you confirm this?) TransactionChain is created and kept open<br/> > for entire life time on ODL, and closed only on shutdown... correct? Then<br/> > that's not a "leak" (of the kind I'm chasing for <a href="https://jira.opendaylight.org/browse/CONTROLLER-1756" title="OOM due to huge Map in ShardDataTree" class="issue-link" data-issue-key="CONTROLLER-1756"><del>CONTROLLER-1756</del></a> using <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a>) -<br/> > and I'm OK if you just close this issue as RESOLVED INVALID or WONTFIX. </p> <p>Yeah, correct, this should be the case. Transaction chain is opened during creating restconf's blueprint container and closed during destroying the container. So closing this as RESOLVED INVALID.</p> <p>> Thanks for having had a look - I think it's valuable to record such findings<br/> > here.<br/> > <br/> > PS: Maybe the "trace:transactions" CLI command from <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> in the future<br/> > should have some sort of <span class="error">[hard-coded? :-(]</span> "white list" to not show e.g.<br/> > this one - or can you think of a better way how it could be made "smart<br/> > enough" to understand that e.g this TransactionChain is not a leak? Or<br/> > perhaps I could just suppress anything that is only x1 and only start<br/> > showing x2+ open TransactionChains - do you think that would be a good idea?</p> <p>Well, I can try to think about something but we should track this elsewhere and not in this bug. Maybe, we can discuss this in <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> or in some new improvement bug.</p> <p>> we should track this elsewhere and not in this bug. Maybe, we can<br/> > discuss this in <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> or in some new improvement bug.</p> <p>agreed and opened new <a href="https://jira.opendaylight.org/browse/CONTROLLER-1765" title="trace:transactions should suppress false TransactionChain positives, by white list, or showing only x2+ ?" class="issue-link" data-issue-key="CONTROLLER-1765"><del>CONTROLLER-1765</del></a> to further discuss what we could do about this!</p> Blocks CONTROLLER-1756 CONTROLLER-1765 Development External issue ID 9069 External issue URL Rank 0|i01yov: