OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [NETCONF-488] We call rpc addNetconfNode by restconf,attribute TcpOnly is default，After write datastore,the TcpOnly is null in datastore https://jira.opendaylight.org/browse/NETCONF-488 netconf <p>2017-11-24 17:45:05,855 | ERROR | on-dispatcher-51 | DataTreeChangeListenerActor | 199 - org.opendaylight.controller.sal-clustering-commons - 1.6.0 | member-1-shard-topology-config: Error notifying listener org.opendaylight.netconf.topology.impl.NetconfTopologyImpl@1c1e15a9<br/> java.lang.NullPointerException<br/> at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:782)<span class="error">&#91;71:com.google.guava:22.0.0&#93;</span><br/> at org.opendaylight.netconf.topology.AbstractNetconfTopology.setupConnection(AbstractNetconfTopology.java:224)<span class="error">&#91;344:netconf-topology-config:1.3.0&#93;</span><br/> at org.opendaylight.netconf.topology.AbstractNetconfTopology.connectNode(AbstractNetconfTopology.java:200)<span class="error">&#91;344:netconf-topology-config:1.3.0&#93;</span><br/> at org.opendaylight.netconf.topology.impl.NetconfTopologyImpl.onDataTreeChanged(NetconfTopologyImpl.java:125)<span class="error">&#91;344:netconf-topology-config:1.3.0&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41)<span class="error">&#91;193:org.opendaylight.controller.sal-binding-broker-impl:1.6.0&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:67)<span class="error">&#91;206:org.opendaylight.controller.sal-distributed-datastore:1.6.0&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:41)<span class="error">&#91;206:org.opendaylight.controller.sal-distributed-datastore:1.6.0&#93;</span><br/> at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:38)<span class="error">&#91;199:org.opendaylight.controller.sal-clustering-commons:1.6.0&#93;</span></p> NETCONF-488 We call rpc addNetconfNode by restconf,attribute TcpOnly is default，After write datastore,the TcpOnly is null in datastore Bug Medium Resolved Done Jakub Morvay Geng Xingyuan Sat, 25 Nov 2017 02:56:42 +0000 Tue, 5 Feb 2019 07:55:30 +0000 Tue, 5 Feb 2019 07:55:30 +0000 Sodium netconf 0 4 <p>Can modify method encryptPassword(AddNetconfNodeInput input)   in NetconfTopologyRPCProvider.java</p> <p>add </p> <p>builder.setTcpOnly(null == input.isTcpOnly()?false:input.isTcpOnly());  </p> <p>at line 66.</p> <p>Feel free to submit a patch</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=xygeng" class="user-hover" rel="xygeng">xygeng</a> any update on this issue?</p> <p>Actually I checked netconf-node-topology model and tcp-only leaf does not have any default value. So I am not sure why do you expect such behavior from NetconfTopologyRPCProvider (the class that implements and provides add-device RPC).</p> <p>On the other hand I think that tcp-only leaf should have some default value and it should default to false. We want to use more secure protocol by default.</p> <p>I created a patch that does this. It should also solve that NPE you saw when calling add-device RPC without tcp-only node defined.</p> Development Rank 0|i038fz: